Merge lp:~jelmer/ubuntu/natty/evolution-mapi/513394-recurring-events into lp:ubuntu/natty/evolution-mapi

Proposed by Jelmer Vernooij
Status: Merged
Merged at revision: 15
Proposed branch: lp:~jelmer/ubuntu/natty/evolution-mapi/513394-recurring-events
Merge into: lp:ubuntu/natty/evolution-mapi
Diff against target: 99 lines (+70/-0)
4 files modified
debian/changelog (+8/-0)
debian/control (+1/-0)
debian/patches/02_recurring_events (+60/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~jelmer/ubuntu/natty/evolution-mapi/513394-recurring-events
Reviewer Review Type Date Requested Status
Chuck Short (community) code Approve
Ubuntu branches Pending
Review via email: mp+49485@code.launchpad.net

Description of the change

Cherry pick the upstream changes to fix bug 513394.

Add "Enhances: evolution" to the evolution-mapi package, so it shows up as an "Add-on" in the software center.

To post a comment you must log in.
16. By Jelmer Vernooij

Add patch header.

17. By Jelmer Vernooij

use my ubuntu credentials.

Revision history for this message
Chuck Short (zulcss) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2011-02-01 13:07:04 +0000
+++ debian/changelog 2011-02-12 00:51:29 +0000
@@ -1,3 +1,11 @@
1evolution-mapi (0.32.1-0ubuntu2) natty; urgency=low
2
3 * Add patch 02_recurring_events: fix recurring events not showing from
4 Exchange 2007. LP: #513394
5 * Add 'Enhances: evolution' for evolution-mapi.
6
7 -- Jelmer Vernooij <jelmer@ubuntu.com> Sat, 12 Feb 2011 00:49:53 +0100
8
1evolution-mapi (0.32.1-0ubuntu1) natty; urgency=low9evolution-mapi (0.32.1-0ubuntu1) natty; urgency=low
210
3 * New upstream release.11 * New upstream release.
412
=== modified file 'debian/control'
--- debian/control 2011-02-01 13:07:04 +0000
+++ debian/control 2011-02-12 00:51:29 +0000
@@ -41,6 +41,7 @@
41 ${misc:Depends},41 ${misc:Depends},
42 evolution (>= 2.32),42 evolution (>= 2.32),
43 evolution (<< 2.33)43 evolution (<< 2.33)
44Enhances: evolution
44Description: Exchange support for the Evolution groupware suite45Description: Exchange support for the Evolution groupware suite
45 The Evolution MAPI provider adds support for Microsoft Exchange, 46 The Evolution MAPI provider adds support for Microsoft Exchange,
46 including Exchange 2007, to the Evolution groupware suite, using the 47 including Exchange 2007, to the Evolution groupware suite, using the
4748
=== added file 'debian/patches/02_recurring_events'
--- debian/patches/02_recurring_events 1970-01-01 00:00:00 +0000
+++ debian/patches/02_recurring_events 2011-02-12 00:51:29 +0000
@@ -0,0 +1,60 @@
1Description: Cherry-pick of fix for recurring events, Ubuntu bug 513394
2Origin: upstream, commit: f36cca5d32ce87a53684d950d53da75e266553ff,
3 commit:fc48cc0ae6f74f9ca292969fa034da6c48f1e6ef
4Bug: https://bugzilla.gnome.org/show_bug.cgi?id=604029
5Author: Milan Crha <mcrha@redhat.com>, Sean Finney <seanius@seanius.net>
6
7=== modified file 'src/libexchangemapi/exchange-mapi-cal-recur-utils.c'
8--- old/src/libexchangemapi/exchange-mapi-cal-recur-utils.c 2010-10-19 15:03:33 +0000
9+++ new/src/libexchangemapi/exchange-mapi-cal-recur-utils.c 2011-02-11 23:36:57 +0000
10@@ -656,8 +656,10 @@
11 /* some constant */
12 flag32 = *((guint32 *)ptr);
13 ptr += sizeof (guint32);
14+ /* It should be set, but not must. It can be, technically, any value.
15+ Seen were 0x3006, 0x3008, 0x3009. It affects format of extended exception info
16 if (flag32 != WRITER_VERSION2)
17- return FALSE;
18+ return FALSE; */
19
20 /* start time in mins */
21 flag32 = *((guint32 *)ptr);
22@@ -670,20 +672,11 @@
23 /* modified exceptions */
24 flag16 = *((guint16 *)ptr);
25 ptr += sizeof (guint16);
26- if (flag16 != 0x0)
27- return FALSE;
28-
29- /* reserved block1 size - has to be 0 */
30- flag32 = *((guint32 *)ptr);
31- ptr += sizeof (guint32);
32- if (flag32 != 0x0)
33- return FALSE;
34-
35- /* reserved block2 size - has to be 0 */
36- flag32 = *((guint32 *)ptr);
37- ptr += sizeof (guint32);
38- if (flag32 != 0x0)
39- return FALSE;
40+ /* FIXME: there are flag16 count modified exceptions here, which
41+ are variable in size, followed by a ReservedBlock1{Size,}
42+ and ReservedBlock2{Size,}. However, since we have nothing
43+ else to do until we are able to parse these modified
44+ instances, we just stop now. */
45
46 /* Set the recurrence */
47 {
48@@ -698,11 +691,6 @@
49 /* FIXME: this also has modified instances */
50 e_cal_component_set_exdate_list (comp, exdate_list);
51
52- g_print ("\n== MAPI to ICAL == The recurrence blob data is as follows:\n");
53- for (i = 0; i < ba->len; ++i)
54- g_print ("0x%02X ", ba->data[i]);
55- g_print("\n== End of stream ==\n");
56-
57 return TRUE;
58 }
59
60
061
=== modified file 'debian/patches/series'
--- debian/patches/series 2011-02-01 13:07:04 +0000
+++ debian/patches/series 2011-02-12 00:51:29 +0000
@@ -1,1 +1,2 @@
101_openchange_compat101_openchange_compat
202_recurring_events

Subscribers

People subscribed via source and target branches