Merge lp:~jelmer/bzr/reproducible-builds-1 into lp:bzr

Proposed by Jelmer Vernooij
Status: Merged
Approved by: Richard Wilbur
Approved revision: no longer in the source branch.
Merged at revision: 6603
Proposed branch: lp:~jelmer/bzr/reproducible-builds-1
Merge into: lp:bzr
Diff against target: 23 lines (+0/-3)
2 files modified
bzrlib/doc_generate/autodoc_man.py (+0/-2)
bzrlib/doc_generate/autodoc_rstx.py (+0/-1)
To merge this branch: bzr merge lp:~jelmer/bzr/reproducible-builds-1
Reviewer Review Type Date Requested Status
Richard Wilbur Approve
Review via email: mp+256747@code.launchpad.net

Commit message

(jelmer)Make bzr build reproducible for Debian.

Description of the change

Remove the generation timestamp from two doc files.

This makes the bzr build reproducible (multiple runs in the same environment produce the same files).

Debian is trying to make all package reproducible. For reasoning, see https://wiki.debian.org/ReproducibleBuilds/About

To post a comment you must log in.
Revision history for this message
Richard Wilbur (richard-wilbur) wrote :

Thanks for the changes and the link. I applaud the Debian project and their goals of reproducible builds and am happy to support these change.

+1

review: Approve
Revision history for this message
Richard Wilbur (richard-wilbur) wrote :

sent to pqm by email

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bzrlib/doc_generate/autodoc_man.py'
--- bzrlib/doc_generate/autodoc_man.py 2012-03-16 13:46:56 +0000
+++ bzrlib/doc_generate/autodoc_man.py 2015-04-18 22:05:19 +0000
@@ -189,8 +189,6 @@
189.\\\" \"%(bzrcmd)s help commands\"189.\\\" \"%(bzrcmd)s help commands\"
190.\\\" \"%(bzrcmd)s help <cmd>\"190.\\\" \"%(bzrcmd)s help <cmd>\"
191.\\\"191.\\\"
192.\\\" Generation time: %(timestamp)s
193.\\\"
194192
195.ie \\n(.g .ds Aq \\(aq193.ie \\n(.g .ds Aq \\(aq
196.el .ds Aq '194.el .ds Aq '
197195
=== modified file 'bzrlib/doc_generate/autodoc_rstx.py'
--- bzrlib/doc_generate/autodoc_rstx.py 2014-05-08 01:28:12 +0000
+++ bzrlib/doc_generate/autodoc_rstx.py 2015-04-18 22:05:19 +0000
@@ -144,7 +144,6 @@
144.. %(bzrcmd)s help commands144.. %(bzrcmd)s help commands
145.. %(bzrcmd)s help <cmd>145.. %(bzrcmd)s help <cmd>
146..146..
147.. Generation time: %(timestamp)s
148147
149"""148"""
150149