Merge lp:~jelmer/brz/log-unused-arg into lp:brz

[Jelmer Vernooij]

Remove unused argument specific_fileid from show_log.

Remove unused argument specific_fileid from show_log.

[Jelmer Vernooij (jelmer)]

review: Approve

=== modified file 'breezy/log.py'
--- breezy/log.py	2019-02-26 09:04:28 +0000
+++ breezy/log.py	2019-06-07 08:08:02 +0000
@@ -136,7 +136,6 @@
 
 def show_log(branch,
              lf,
-             specific_fileid=None,
              verbose=False,
              direction='reverse',
              start_revision=None,
@@ -154,9 +153,6 @@
 
     :param lf: The LogFormatter object showing the output.
 
-    :param specific_fileid: If not None, list only the commits affecting the
-        specified file, rather than all commits.
-
     :param verbose: If True show added/changed/deleted/renamed files.
 
     :param direction: 'reverse' (default) is latest to earliest; 'forward' is
@@ -177,23 +173,12 @@
     :param match: Dictionary of search lists to use when matching revision
       properties.
     """
-    # Convert old-style parameters to new-style parameters
-    if specific_fileid is not None:
-        file_ids = [specific_fileid]
-    else:
-        file_ids = None
     if verbose:
-        if file_ids:
-            delta_type = 'partial'
-        else:
-            delta_type = 'full'
+        delta_type = 'full'
     else:
         delta_type = None
     if show_diff:
-        if file_ids:
-            diff_type = 'partial'
-        else:
-            diff_type = 'full'
+        diff_type = 'full'
     else:
         diff_type = None
 
@@ -213,10 +198,11 @@
         raise errors.InvalidRevisionNumber(end_revision.revno)
 
     # Build the request and execute it
-    rqst = make_log_request_dict(direction=direction, specific_fileids=file_ids,
-                                 start_revision=start_revision, end_revision=end_revision,
-                                 limit=limit, message_search=search,
-                                 delta_type=delta_type, diff_type=diff_type)
+    rqst = make_log_request_dict(
+        direction=direction,
+        start_revision=start_revision, end_revision=end_revision,
+        limit=limit, message_search=search,
+        delta_type=delta_type, diff_type=diff_type)
     Logger(branch, rqst).show(lf)
 
 
@@ -1949,7 +1935,6 @@
         to_file.write('Added Revisions:\n')
         show_log(branch,
                  lf,
-                 None,
                  verbose=False,
                  direction='forward',
                  start_revision=base_idx + 1,
@@ -2034,7 +2019,7 @@
     if new_history != []:
         output.write('Added Revisions:\n')
         start_revno = new_revno - len(new_history) + 1
-        show_log(branch, lf, None, verbose=False, direction='forward',
+        show_log(branch, lf, verbose=False, direction='forward',
                  start_revision=start_revno)