Merge lp:~jelmer/brz/get-revisions-no-none into lp:brz

[Jelmer Vernooij]

Disallow Repository.get_revisions(revision_ids=None)

Don't allow Repository.get_revision_ids(None) to return all revision objects.

There were no tests for this behaviour, and there are no benefits that I can see. All current implementations (including client side RemoteRepository) just set revision_ids to self.all_revision_ids().

The only current users are check and reconcile.

[Martin Packman (gz)]

Looks good.

review: Approve

=== modified file 'breezy/bzr/groupcompress_repo.py'
--- breezy/bzr/groupcompress_repo.py	2017-06-11 13:48:12 +0000
+++ breezy/bzr/groupcompress_repo.py	2017-06-22 00:34:27 +0000
@@ -1136,7 +1136,7 @@
             raise AssertionError()
         vf = self.revisions
         if revisions_iterator is None:
-            revisions_iterator = self._iter_revisions(None)
+            revisions_iterator = self._iter_revisions(self.all_revision_ids())
         for revid, revision in revisions_iterator:
             if revision is None:
                 pass
 
=== modified file 'breezy/bzr/remote.py'
--- breezy/bzr/remote.py	2017-06-16 00:00:24 +0000
+++ breezy/bzr/remote.py	2017-06-22 00:34:27 +0000
@@ -2659,13 +2659,10 @@
 
     @needs_read_lock
     def get_revisions(self, revision_ids):
-        if revision_ids is None:
-            revision_ids = self.all_revision_ids()
-        else:
-            for rev_id in revision_ids:
-                if not rev_id or not isinstance(rev_id, bytes):
-                    raise errors.InvalidRevisionId(
-                        revision_id=rev_id, branch=self)
+        for rev_id in revision_ids:
+            if not rev_id or not isinstance(rev_id, bytes):
+                raise errors.InvalidRevisionId(
+                    revision_id=rev_id, branch=self)
         try:
             missing = set(revision_ids)
             revs = {}
 
=== modified file 'breezy/bzr/vf_repository.py'
--- breezy/bzr/vf_repository.py	2017-06-20 02:03:30 +0000
+++ breezy/bzr/vf_repository.py	2017-06-22 00:34:27 +0000
@@ -1133,12 +1133,9 @@
         :return: An iterator of (revid, revision) tuples. Absent revisions (
             those asked for but not available) are returned as (revid, None).
         """
-        if revision_ids is None:
-            revision_ids = self.all_revision_ids()
-        else:
-            for rev_id in revision_ids:
-                if not rev_id or not isinstance(rev_id, bytes):
-                    raise errors.InvalidRevisionId(revision_id=rev_id, branch=self)
+        for rev_id in revision_ids:
+            if not rev_id or not isinstance(rev_id, bytes):
+                raise errors.InvalidRevisionId(revision_id=rev_id, branch=self)
         keys = [(key,) for key in revision_ids]
         stream = self.revisions.get_record_stream(keys, 'unordered', True)
         for record in stream:
@@ -1680,7 +1677,7 @@
             raise AssertionError()
         vf = self.revisions
         if revisions_iterator is None:
-            revisions_iterator = self._iter_revisions(None)
+            revisions_iterator = self._iter_revisions(self.all_revision_ids())
         for revid, revision in revisions_iterator:
             if revision is None:
                 pass
 
=== modified file 'breezy/check.py'
--- breezy/check.py	2017-06-10 00:52:08 +0000
+++ breezy/check.py	2017-06-22 00:34:27 +0000
@@ -181,7 +181,8 @@
 
     def check_revisions(self):
         """Scan revisions, checking data directly available as we go."""
-        revision_iterator = self.repository._iter_revisions(None)
+        revision_iterator = self.repository._iter_revisions(
+            self.repository.all_revision_ids())
         revision_iterator = self._check_revisions(revision_iterator)
         # We read the all revisions here:
         # - doing this allows later code to depend on the revision index.
 
=== modified file 'doc/en/release-notes/brz-3.0.txt'
--- doc/en/release-notes/brz-3.0.txt	2017-06-20 22:54:06 +0000
+++ doc/en/release-notes/brz-3.0.txt	2017-06-22 00:34:27 +0000
@@ -148,6 +148,9 @@
  * ``ControlDir.find_bzrdirs`` has been renamed to
    ``ControlDir.find_controldirs``. (Jelmer Vernooij)
 
+ * ``Repository.get_revisions`` no longer accepts ``None`` as
+   argument. (Jelmer Vernooij)
+
 Internals
 *********