Merge lp:~jcsackett/launchpad/privacy-banner-with-better-info into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Curtis Hovey |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15305 |
Proposed branch: | lp:~jcsackett/launchpad/privacy-banner-with-better-info |
Merge into: | lp:launchpad |
Prerequisite: | lp:~jcsackett/launchpad/simplify-everything |
Diff against target: |
101 lines (+28/-6) 5 files modified
lib/lp/app/javascript/banners/banner.js (+1/-1) lib/lp/app/templates/banner-macros.pt (+10/-1) lib/lp/bugs/browser/bugtask.py (+4/-0) lib/lp/bugs/javascript/information_type_choice.js (+3/-0) lib/lp/bugs/javascript/tests/test_information_type_choice.js (+10/-4) |
To merge this branch: | bzr merge lp:~jcsackett/launchpad/privacy-banner-with-better-info |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Review via email: mp+107244@code.launchpad.net |
Commit message
Updates the privacy banner to show the appropriate information_type for the bug.
Description of the change
Summary
=======
This branch updates the use of the privacy banner on the bugtask index page to
show the appropriate information type in the banner.
Preimp
======
Spoke with Curtis Hovey, Steve Kowalik.
Implementation
==============
* updateText is updated to set 'text', not 'innerText'; 'text' works better in
dynamic updates in some browsers.
* lp.bugs.
information type title for the associated bug.
* the banner-macro privacy banner is updated to grab the view.informatio
attribute, if it exists. If it exist, the text is rendered as "This page
contains $info_type data." If not, the default message of "This page
contains private data." is used.
* information_
banner text based on the information_type the bug is changed to via the
portlet. The corresponding test is also updated.
Tests
=====
bin/test -vvc -t beta -t privacy -t banner -t type_choice --layer=YUI
QA
==
Go play with the privacy portlet information type choice picker on a bug
change. The privacy banner text should update with the information_type.
Reload the page a few times with different information_types; it should load
showing the appropriate message for the info type.
LoC
===
This is part of the disclosure project.
Lint
====
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
Thank you.