Merge lp:~jcsackett/charms/precise/charmworld/add-jenkins into lp:~juju-jitsu/charms/precise/charmworld/trunk

Proposed by j.c.sackett
Status: Merged
Approved by: j.c.sackett
Approved revision: 92
Merged at revision: 89
Proposed branch: lp:~jcsackett/charms/precise/charmworld/add-jenkins
Merge into: lp:~juju-jitsu/charms/precise/charmworld/trunk
Diff against target: 80 lines (+30/-2)
3 files modified
config.yaml (+15/-0)
production_overrides.ini (+3/-0)
scripts/write_config.py (+12/-2)
To merge this branch: bzr merge lp:~jcsackett/charms/precise/charmworld/add-jenkins
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+201582@code.launchpad.net

Commit message

Add necessary config options for triggering jenkins test builds of ingested charms.

Description of the change

This branch adds the jenkins ini file options for charmworld to the config, and updates the config generation to include them in building production.ini

This cannot be landed until https://code.launchpad.net/~jcsackett/charmworld/trigger-test-builds/+merge/201466 lands.

To post a comment you must log in.
91. By j.c.sackett

Fixed bad overrides.ini

92. By j.c.sackett

Remove remaining bad jenkins references.

Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'config.yaml'
--- config.yaml 2014-01-07 18:39:21 +0000
+++ config.yaml 2014-01-14 16:32:34 +0000
@@ -56,3 +56,18 @@
56 default: ''56 default: ''
57 description: |57 description: |
58 The lp credentials to use with charmworld ingest, if available.58 The lp credentials to use with charmworld ingest, if available.
59 charm_testing_url:
60 type: string
61 default: ''
62 description: |
63 The url of the testing service (e.g. jenkins) used for charm testing
64 charm_testing_token:
65 type: string
66 default: ''
67 description: |
68 The token needed for triggering builds
69 charm_testing_job:
70 type: string
71 default: ''
72 description: |
73 The name of the job running the test.
5974
=== modified file 'production_overrides.ini'
--- production_overrides.ini 2014-01-07 18:39:21 +0000
+++ production_overrides.ini 2014-01-14 16:32:34 +0000
@@ -7,6 +7,9 @@
7mongo.url =7mongo.url =
8lp_credentials_file = /home/webops_deploy/charmworld/charmbot_credentials.txt8lp_credentials_file = /home/webops_deploy/charmworld/charmbot_credentials.txt
9proof.port = 65439proof.port = 6543
10charm_testing_url =
11charm_testing_token =
12charm_testing_job =
1013
11[server:main]14[server:main]
12port = 654315port = 6543
1316
=== modified file 'scripts/write_config.py'
--- scripts/write_config.py 2014-01-02 14:19:13 +0000
+++ scripts/write_config.py 2014-01-14 16:32:34 +0000
@@ -21,7 +21,8 @@
2121
22def write_new_config(mongo_url, es_url, error_handler, charm_import_limit,22def write_new_config(mongo_url, es_url, error_handler, charm_import_limit,
23 worker_interval, default, override, target, es_replicas,23 worker_interval, default, override, target, es_replicas,
24 es_shards):24 es_shards, charm_testing_url, charm_testing_token,
25 charm_testing_job):
25 new_config = read_config([default, override])26 new_config = read_config([default, override])
26 new_config.set('app:main', 'mongo.url', mongo_url)27 new_config.set('app:main', 'mongo.url', mongo_url)
27 new_config.set('app:main', 'es_urls', es_url)28 new_config.set('app:main', 'es_urls', es_url)
@@ -45,6 +46,9 @@
45 'app:main', 'worker_interval', worker_interval)46 'app:main', 'worker_interval', worker_interval)
46 new_config.set('app:main', 'es_replicas', es_replicas)47 new_config.set('app:main', 'es_replicas', es_replicas)
47 new_config.set('app:main', 'es_shards', es_shards)48 new_config.set('app:main', 'es_shards', es_shards)
49 new_config.set('app:main', 'charm_testing_url', charm_testing_url)
50 new_config.set('app:main', 'charm_testing_token', charm_testing_token)
51 new_config.set('app:main', 'charm_testing_job', charm_testing_job)
48 with open(target, 'w') as output:52 with open(target, 'w') as output:
49 new_config.write(output)53 new_config.write(output)
5054
@@ -132,12 +136,18 @@
132 worker_interval = juju_config['worker-interval']136 worker_interval = juju_config['worker-interval']
133 es_shards = juju_config['es_shards']137 es_shards = juju_config['es_shards']
134 es_replicas = juju_config['es_replicas']138 es_replicas = juju_config['es_replicas']
139 charm_testing_url = juju_config['charm_testing_url']
140 charm_testing_token = juju_config['charm_testing_token']
141 charm_testing_job = juju_config['charm_testing_job']
135142
136 write_new_config(get_mongo_url(), get_elasticsearch_url(),143 write_new_config(get_mongo_url(), get_elasticsearch_url(),
137 get_error_handler(), charm_import_limit,144 get_error_handler(), charm_import_limit,
138 worker_interval, default=sys.argv[1],145 worker_interval, default=sys.argv[1],
139 override=sys.argv[2], target=sys.argv[3],146 override=sys.argv[2], target=sys.argv[3],
140 es_replicas=es_replicas, es_shards=es_shards)147 es_replicas=es_replicas, es_shards=es_shards,
148 charm_testing_url=charm_testing_url,
149 charm_testing_token=charm_testing_token,
150 charm_testing_job=charm_testing_job)
141151
142152
143if __name__ == '__main__':153if __name__ == '__main__':

Subscribers

People subscribed via source and target branches

to all changes: