Merge lp:~james-w/udd/drop_email_failures into lp:udd

[James Westby]

Hi,

The email-failures script output isn't going to anywhere that is being
read that I am aware of, so we should drop it.

Thanks,

James

[lp:~james-w/udd/drop_email_failures]

559. By James Westby on 2011-12-14

Merged drop-cricket into drop_email_failures.

[Martin Pool (mbp)]

I do get and scan the email, but I won't miss them if they stop.

  vote approve

review: Approve

[Vincent Ladeuil (vila)]

I don't get the email but would love to. Never found where I should add my email for that though.

Now, if I understand it correctly, this will send a single email for all failure where I'd prefer a single mail by failure.

My use case is that I sometimes postpone requeuing a failed import that looks spurious until I can capture the traceback somewhere. Receiving an email for such failures and being able to 'just hit delete' for the uninteresting ones would be ideal.

[Martin Pool (mbp)]

On 17 December 2011 00:43, Vincent Ladeuil <email address hidden> wrote:
> I don't get the email but would love to. Never found where I should add my email for that though.
>
> Now, if I understand it correctly, this will send a single email for all failure where I'd prefer a single mail by failure.
>
> My use case is that I sometimes postpone requeuing a failed import that looks spurious until I can capture the traceback somewhere. Receiving an email for such failures and being able to 'just hit delete' for the uninteresting ones would be ideal.

I think this is controlled by ~pkg_import/.forward. I've added you.
If it's useful and James doesn't find it too bad to have it in the
tree, let's leave it.

--
Martin

[James Westby (james-w)]

On Mon, 19 Dec 2011 18:03:24 +1100, Martin Pool <email address hidden> wrote:
> I think this is controlled by ~pkg_import/.forward. I've added you.
> If it's useful and James doesn't find it too bad to have it in the
> tree, let's leave it.

Yeah, if it's being used it won't be much work to keep it around.

Thanks,

James

[Vincent Ladeuil (vila)]

This has been used and useful so rejecting the proposal.

review: Disapprove

Unmerged revisions

559. By James Westby on 2011-12-14

Merged drop-cricket into drop_email_failures.

558. By James Westby on 2011-12-13

Merge trunk.

557. By James Westby on 2011-12-10

Drop it from the crontab too.

556. By James Westby on 2011-12-10

Drop email_failures as it isn't used.

=== removed file 'bin/email-failures'
--- bin/email-failures	2011-10-21 10:17:16 +0000
+++ bin/email-failures	1970-01-01 00:00:00 +0000
@@ -1,7 +0,0 @@
-#!/usr/bin/python
-
-from udd.scripts.email_failures import main
-
-
-if __name__ == '__main__':
-    main()
 
=== modified file 'importer.crontab'
--- importer.crontab	2011-11-08 13:06:03 +0000
+++ importer.crontab	2011-12-14 18:45:28 +0000
@@ -8,5 +8,4 @@
 */5 * * * * /usr/bin/python ${SCRIPTS_DIR}/categorise-failures
 */5 * * * * /usr/bin/python ${SCRIPTS_DIR}/add-import-jobs
 17 07 * * * /usr/bin/python ${SCRIPTS_DIR}/list-packages
-30 03 * * * /usr/bin/python ${SCRIPTS_DIR}/email-failures
 21 * * * * /usr/bin/python ${SCRIPTS_DIR}/graph-failures
 
=== removed file 'udd/scripts/email_failures.py'
--- udd/scripts/email_failures.py	2011-12-08 18:01:01 +0000
+++ udd/scripts/email_failures.py	1970-01-01 00:00:00 +0000
@@ -1,55 +0,0 @@
-import sys
-
-from udd import (
-    icommon,
-    iconfig,
-    )
-
-
-# Not ideal to declare this here but this is used by several local functions
-# below. Refactoring the whole script may help -- vila 2011-12-07
-conf = None # Will be set by main()
-
-
-def write_email(failures):
-    text = ""
-    for package, reason, when_failed in failures:
-        if reason == icommon.running_sentinel:
-            continue
-        text += "\n\n%s failed at %s due to:\n%s\n" % (
-            package, when_failed, reason.encode("ascii", "replace"))
-    return text
-
-
-def only_main(failures):
-    db = icommon.PackageDatabase(conf.get('pi.sqlite_package_file'))
-    main_packages = db.list_packages_in_main()
-    filtered = []
-    for failure in failures:
-        package = failure[0]
-        if package in main_packages:
-            filtered.append(failure)
-    return filtered
-
-
-def email_failures():
-    db = icommon.StatusDatabase(conf.get('pi.sqlite_file'))
-    failures = db.unemailed_failures()
-    failures = only_main(failures)
-    if failures:
-        content = write_email(failures)
-        print content
-        db.set_failures_emailed(failures)
-
-
-def main():
-    global conf
-    conf = iconfig.ImporterStack()
-    lock = icommon.lock_path(conf.get('pi.script_locks_dir'), 'email_failures')
-    if lock is None:
-        print "Another instance of email_failures is already running."
-        sys.exit(0)
-    try:
-        email_failures()
-    finally:
-        lock.close()
 
=== removed file 'udd/tests/test_email_failures.py'
--- udd/tests/test_email_failures.py	2011-12-08 18:01:01 +0000
+++ udd/tests/test_email_failures.py	1970-01-01 00:00:00 +0000
@@ -1,11 +0,0 @@
-from udd import tests
-
-from udd.scripts import email_failures
-
-
-class TestEmailFailures(tests.TestCaseWithConfig):
-
-    def test_empty(self):
-        email_failures.main()
-        # A lock has been created under the test hierarchy
-        self.assertTestPathExists('locks/scripts/email_failures')