Merge lp:~james-w/txstatsd/delta-configurable-processor into lp:txstatsd

Proposed by James Westby
Status: Merged
Approved by: Ricardo Kirkner
Approved revision: 112
Merged at revision: 111
Proposed branch: lp:~james-w/txstatsd/delta-configurable-processor
Merge into: lp:txstatsd
Diff against target: 43 lines (+20/-2)
2 files modified
txstatsd/server/configurableprocessor.py (+2/-2)
txstatsd/tests/test_configurableprocessor.py (+18/-0)
To merge this branch: bzr merge lp:~james-w/txstatsd/delta-configurable-processor
Reviewer Review Type Date Requested Status
Ricardo Kirkner (community) Approve
Review via email: mp+238546@code.launchpad.net

Commit message

Fix gauge delta support in ConfigurableMessageProcessor.

To post a comment you must log in.
112. By James Westby

Fix indentation.

Revision history for this message
Ricardo Kirkner (ricardokirkner) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'txstatsd/server/configurableprocessor.py'
--- txstatsd/server/configurableprocessor.py 2013-06-07 21:25:55 +0000
+++ txstatsd/server/configurableprocessor.py 2014-10-16 11:29:36 +0000
@@ -80,11 +80,11 @@
80 self.counter_metrics[key] = metric80 self.counter_metrics[key] = metric
81 self.counter_metrics[key].mark(value)81 self.counter_metrics[key].mark(value)
8282
83 def compose_gauge_metric(self, key, value):83 def compose_gauge_metric(self, key, value, delta=False):
84 if not key in self.gauge_metrics:84 if not key in self.gauge_metrics:
85 metric = GaugeMetricReporter(key, prefix=self.message_prefix)85 metric = GaugeMetricReporter(key, prefix=self.message_prefix)
86 self.gauge_metrics[key] = metric86 self.gauge_metrics[key] = metric
87 self.gauge_metrics[key].mark(value)87 self.gauge_metrics[key].mark(value, delta=delta)
8888
89 def compose_meter_metric(self, key, value):89 def compose_meter_metric(self, key, value):
90 if not key in self.meter_metrics:90 if not key in self.meter_metrics:
9191
=== modified file 'txstatsd/tests/test_configurableprocessor.py'
--- txstatsd/tests/test_configurableprocessor.py 2013-06-07 21:25:55 +0000
+++ txstatsd/tests/test_configurableprocessor.py 2014-10-16 11:29:36 +0000
@@ -174,3 +174,21 @@
174 messages[0])174 messages[0])
175 self.assertEqual(("test.metric.gorets.rate", 3.0, self.time_now),175 self.assertEqual(("test.metric.gorets.rate", 3.0, self.time_now),
176 messages[1])176 messages[1])
177
178
179class ComposeTests(TestCase):
180
181 def test_compose_gauge_metric(self):
182 configurable_processor = ConfigurableMessageProcessor()
183 configurable_processor.compose_gauge_metric('a', 1)
184 self.assertEqual(
185 configurable_processor.gauge_metrics['a'].value,
186 1)
187
188 def test_compose_gauge_metric_delta(self):
189 configurable_processor = ConfigurableMessageProcessor()
190 configurable_processor.compose_gauge_metric('a', 1)
191 configurable_processor.compose_gauge_metric('a', 1, delta=True)
192 self.assertEqual(
193 configurable_processor.gauge_metrics['a'].value,
194 2)

Subscribers

People subscribed via source and target branches