Merge lp:~james-page/charms/trusty/neutron-gateway/xenial into lp:~openstack-charmers-archive/charms/trusty/neutron-gateway/next

Proposed by James Page
Status: Merged
Merged at revision: 164
Proposed branch: lp:~james-page/charms/trusty/neutron-gateway/xenial
Merge into: lp:~openstack-charmers-archive/charms/trusty/neutron-gateway/next
Diff against target: 94 lines (+61/-10)
2 files modified
templates/mitaka/nova.conf (+34/-0)
tests/basic_deployment.py (+27/-10)
To merge this branch: bzr merge lp:~james-page/charms/trusty/neutron-gateway/xenial
Reviewer Review Type Date Requested Status
David Ames (community) Approve
Ryan Beisner (community) Approve
Review via email: mp+285862@code.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #375 neutron-gateway-next for james-page mp285862
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/375/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #298 neutron-gateway-next for james-page mp285862
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/298/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #149 neutron-gateway-next for james-page mp285862
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
2016-02-12 18:43:55,513 validate_config_data DEBUG: Validating config file data (fwaas in /etc/neutron/fwaas_driver.ini on neutron-gateway/0)...
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15027737/
Build: http://10.245.162.36:8080/job/charm_amulet_test/149/

Revision history for this message
David Ames (thedac) wrote :

This one also seems legit. I could not root cause it yet.

review: Needs Fixing
166. By James Page

Drop ec2 and objectstore checks for now

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #727 neutron-gateway-next for james-page mp285862
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/727/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #634 neutron-gateway-next for james-page mp285862
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/634/

167. By James Page

Fixup checks for neutron section in nova.conf

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #730 neutron-gateway-next for james-page mp285862
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/730/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #637 neutron-gateway-next for james-page mp285862
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/637/

168. By James Page

Fixup endpoint checks

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #744 neutron-gateway-next for james-page mp285862
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/744/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #650 neutron-gateway-next for james-page mp285862
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/650/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #281 neutron-gateway-next for james-page mp285862
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
2016-02-17 12:28:15,418 _validate_dict_data DEBUG: expected: {'quantum_port': '9696', 'auth_port': '35357', 'auth_protocol': 'http', 'keystone_host': <bound method OpenStackAmuletUtils.valid_ip of <charmhelpers.contrib.openstack.amulet.utils.OpenStackAmuletUtils object at 0x2b9bdd05d590>>, 'auth_host': <bound method OpenStackAmuletUtils.valid_ip of <charmhelpers.contrib.openstack.amulet.utils.OpenStackAmuletUtils object at 0x2b9bdd05d590>>, 'service_username': 'nova', 'service_tenant_name': 'services', 'service_protocol': 'http', 'service_tenant': 'services', 'quantum_url': <bound method OpenStackAmuletUtils.valid_url of <charmhelpers.contrib.openstack.amulet.utils.OpenStackAmuletUtils object at 0x2b9bdd05d590>>, 'service_password': <bound method OpenStackAmuletUtils.not_null of <charmhelpers.contrib.openstack.amulet.utils.OpenStackAmuletUtils object at 0x2b9bdd05d590>>, 'service_port': '5000', 'region': 'RegionOne', 'quantum_host': <bound method OpenStackAmuletUtils.valid_ip of <charmhelpers.contrib.openstack.amulet.utils.OpenStackAmuletUtils object at 0x2b9bdd05d590>>, 'private-address': <bound method OpenStackAmuletUtils.valid_ip of <charmhelpers.contrib.openstack.amulet.utils.OpenStackAmuletUtils object at 0x2b9bdd05d590>>, 'quantum_plugin': 'ovs'}
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15099836/
Build: http://10.245.162.36:8080/job/charm_amulet_test/281/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #284 neutron-gateway-next for james-page mp285862
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
juju-test.conductor.019-basic-trusty-mitaka DEBUG : Got exit code: 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15099927/
Build: http://10.245.162.36:8080/job/charm_amulet_test/284/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #297 neutron-gateway-next for james-page mp285862
    AMULET OK: passed

Build: http://10.245.162.36:8080/job/charm_amulet_test/297/

Revision history for this message
Ryan Beisner (1chb1n) :
review: Approve
Revision history for this message
David Ames (thedac) wrote :

LGTM, merging.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added directory 'templates/mitaka'
=== added file 'templates/mitaka/nova.conf'
--- templates/mitaka/nova.conf 1970-01-01 00:00:00 +0000
+++ templates/mitaka/nova.conf 2016-02-17 11:43:41 +0000
@@ -0,0 +1,34 @@
1# mitaka
2###############################################################################
3# [ WARNING ]
4# Configuration file maintained by Juju. Local changes may be overwritten.
5###############################################################################
6[DEFAULT]
7logdir=/var/log/nova
8state_path=/var/lib/nova
9root_helper=sudo nova-rootwrap /etc/nova/rootwrap.conf
10verbose= {{ verbose }}
11use_syslog = {{ use_syslog }}
12api_paste_config=/etc/nova/api-paste.ini
13enabled_apis=metadata
14multi_host=True
15# Access to neutron API services
16network_api_class=nova.network.neutronv2.api.API
17
18{% include "section-zeromq" %}
19
20[neutron]
21url={{ quantum_url }}
22auth_plugin=password
23project_name={{ service_tenant }}
24username={{ service_username }}
25password={{ service_password }}
26auth_url={{ service_protocol }}://{{ keystone_host }}:{{ service_port }}
27region={{ region }}
28service_metadata_proxy=True
29metadata_proxy_shared_secret={{ shared_secret }}
30
31{% include "section-rabbitmq-oslo" %}
32
33[oslo_concurrency]
34lock_path=/var/lock/nova
035
=== modified file 'tests/basic_deployment.py'
--- tests/basic_deployment.py 2016-01-22 04:29:30 +0000
+++ tests/basic_deployment.py 2016-02-17 11:43:41 +0000
@@ -193,6 +193,10 @@
193 'nova-scheduler',193 'nova-scheduler',
194 'nova-conductor']194 'nova-conductor']
195195
196 if self._get_openstack_release_string() >= 'liberty':
197 nova_cc_services.remove('nova-api-ec2')
198 nova_cc_services.remove('nova-objectstore')
199
196 commands = {200 commands = {
197 self.mysql_sentry: ['mysql'],201 self.mysql_sentry: ['mysql'],
198 self.keystone_sentry: ['keystone'],202 self.keystone_sentry: ['keystone'],
@@ -874,16 +878,29 @@
874 expected['oslo_concurrency'] = {878 expected['oslo_concurrency'] = {
875 'lock_path': '/var/lock/nova'879 'lock_path': '/var/lock/nova'
876 }880 }
877 expected['neutron'] = {881 if self._get_openstack_release() >= self.trusty_mitaka:
878 'auth_strategy': 'keystone',882 expected['neutron'] = {
879 'url': nova_cc_relation['quantum_url'],883 'url': nova_cc_relation['quantum_url'],
880 'admin_tenant_name': 'services',884 'auth_plugin': 'password',
881 'admin_username': 'nova',885 'project_name': 'services',
882 'admin_password': nova_cc_relation['service_password'],886 'username': 'nova',
883 'admin_auth_url': ep,887 'password': nova_cc_relation['service_password'],
884 'service_metadata_proxy': 'True',888 'auth_url': ep.split('/v')[0],
885 'metadata_proxy_shared_secret': u.not_null889 'region': 'RegionOne',
886 }890 'service_metadata_proxy': 'True',
891 'metadata_proxy_shared_secret': u.not_null
892 }
893 else:
894 expected['neutron'] = {
895 'auth_strategy': 'keystone',
896 'url': nova_cc_relation['quantum_url'],
897 'admin_tenant_name': 'services',
898 'admin_username': 'nova',
899 'admin_password': nova_cc_relation['service_password'],
900 'admin_auth_url': ep,
901 'service_metadata_proxy': 'True',
902 'metadata_proxy_shared_secret': u.not_null
903 }
887 else:904 else:
888 # Juno or earlier905 # Juno or earlier
889 expected['DEFAULT'].update({906 expected['DEFAULT'].update({

Subscribers

People subscribed via source and target branches