Merge lp:~izidor/gtg/bug1002463 into lp:~gtg/gtg/old-trunk
Proposed by
Izidor Matušov
Status: | Merged |
---|---|
Merged at revision: | 1184 |
Proposed branch: | lp:~izidor/gtg/bug1002463 |
Merge into: | lp:~gtg/gtg/old-trunk |
Diff against target: |
64 lines (+18/-11) 1 file modified
GTG/gtk/preferences.py (+18/-11) |
To merge this branch: | bzr merge lp:~izidor/gtg/bug1002463 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bertrand Rousseau (community) | run, code | Approve | |
Review via email: mp+107435@code.launchpad.net |
Description of the change
Solution for bug #1002463. Ignore request to open a configure dialog when no plugin is selected. Also cleaning of some code.
BTW: My original idea was to make About and Configure buttons unsensitive when no plugin is selected. However, when I unselect a plugin using CTRL + left mouse button, I still get a valid iterator of a previously selected plugin. Doing that again (the plugin is now selected), I get None iterator and disabled button. It is probably another bug in PyGTK. We will stick with ignoring the callback when no plugin is selected.
To post a comment you must log in.
It's more a workaround than a complete fix, but since it prevents GTG from crashing, and since pygtk doesn't help, it's still a worthy improvement. I've run the code and it works. So it's good for me, I approve, you can merge it.