Merge lp:~indicator-applet-developers/indicator-messages/ubuntu into lp:~ubuntu-desktop/indicator-messages/ubuntu

Proposed by Ted Gould
Status: Merged
Merged at revision: 205
Proposed branch: lp:~indicator-applet-developers/indicator-messages/ubuntu
Merge into: lp:~ubuntu-desktop/indicator-messages/ubuntu
Diff against target: 174 lines (+27/-55)
8 files modified
AUTHORS (+1/-0)
ChangeLog (+12/-0)
configure (+1/-1)
configure.ac (+1/-1)
debian/changelog (+8/-0)
debian/patches/lp_690668.patch (+0/-44)
debian/patches/series (+0/-1)
src/indicator-messages.c (+4/-8)
To merge this branch: bzr merge lp:~indicator-applet-developers/indicator-messages/ubuntu
Reviewer Review Type Date Requested Status
Ken VanDine Pending
Review via email: mp+77351@code.launchpad.net

Description of the change

Mem fix

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'AUTHORS'
--- AUTHORS 2011-08-25 14:01:27 +0000
+++ AUTHORS 2011-09-28 16:00:33 +0000
@@ -1,6 +1,7 @@
1# Generated by Makefile. Do not edit.1# Generated by Makefile. Do not edit.
22
3 Andrea Cimitan 3 Andrea Cimitan
4 Chow Loong Jin
4 Chris Coulson 5 Chris Coulson
5 cody 6 cody
6 David Barth 7 David Barth
78
=== modified file 'ChangeLog'
--- ChangeLog 2011-08-25 14:01:27 +0000
+++ ChangeLog 2011-09-28 16:00:33 +0000
@@ -1,5 +1,17 @@
1# Generated by Makefile. Do not edit.1# Generated by Makefile. Do not edit.
22
32011-09-28 Ted Gould <ted@gould.cx>
4
5 0.5.0
6
72011-09-21 Ted Gould <ted@gould.cx>
8
9 Memory leak on pixbufs
10
112011-01-21 Chow Loong Jin <hyperair@ubuntu.com>
12
13 Memory leaks fixes
14
32011-08-25 Ted Gould <ted@gould.cx>152011-08-25 Ted Gould <ted@gould.cx>
416
5 0.4.9517 0.4.95
618
=== modified file 'configure'
--- configure 2011-08-25 14:04:37 +0000
+++ configure 2011-09-28 16:00:33 +0000
@@ -2758,7 +2758,7 @@
27582758
2759# Define the identity of the package.2759# Define the identity of the package.
2760 PACKAGE=indicator-messages2760 PACKAGE=indicator-messages
2761 VERSION=0.4.952761 VERSION=0.5.0
27622762
27632763
2764cat >>confdefs.h <<_ACEOF2764cat >>confdefs.h <<_ACEOF
27652765
=== modified file 'configure.ac'
--- configure.ac 2011-08-25 13:45:34 +0000
+++ configure.ac 2011-09-28 16:00:33 +0000
@@ -4,7 +4,7 @@
4AC_PREREQ(2.53)4AC_PREREQ(2.53)
55
6AM_CONFIG_HEADER(config.h)6AM_CONFIG_HEADER(config.h)
7AM_INIT_AUTOMAKE(indicator-messages, 0.4.95)7AM_INIT_AUTOMAKE(indicator-messages, 0.5.0)
88
9AM_MAINTAINER_MODE9AM_MAINTAINER_MODE
1010
1111
=== modified file 'debian/changelog'
--- debian/changelog 2011-08-25 17:19:32 +0000
+++ debian/changelog 2011-09-28 16:00:33 +0000
@@ -1,3 +1,11 @@
1indicator-messages (0.5.0-0ubuntu1~ppa1) oneiric; urgency=low
2
3 * New upstream release.
4 * Fix memory leak (LP: #690668)
5 * Drop debian/patches/lp_690668.patch: Merged upstream
6
7 -- Ted Gould <ted@ubuntu.com> Wed, 28 Sep 2011 10:39:26 -0500
8
1indicator-messages (0.4.95-0ubuntu1) oneiric; urgency=low9indicator-messages (0.4.95-0ubuntu1) oneiric; urgency=low
210
3 * New upstream release.11 * New upstream release.
412
=== removed file 'debian/patches/lp_690668.patch'
--- debian/patches/lp_690668.patch 2011-08-25 14:07:53 +0000
+++ debian/patches/lp_690668.patch 1970-01-01 00:00:00 +0000
@@ -1,44 +0,0 @@
1=== modified file 'src/indicator-messages.c'
2--- old/src/indicator-messages.c 2011-01-14 19:10:10 +0000
3+++ new/src/indicator-messages.c 2011-01-21 20:08:53 +0000
4@@ -571,6 +571,7 @@
5 width,
6 height,
7 GDK_INTERP_BILINEAR);
8+ g_object_unref(pixbuf);
9 } else {
10 g_debug("Happy with icon sized %dx%d", gdk_pixbuf_get_width(pixbuf), gdk_pixbuf_get_height(pixbuf));
11 resized_pixbuf = pixbuf;
12@@ -578,10 +579,7 @@
13
14 gtk_image_set_from_pixbuf(GTK_IMAGE(mi_data->icon), resized_pixbuf);
15
16- /* The other pixbuf should be free'd by the dbusmenu. */
17- if (resized_pixbuf != pixbuf) {
18- g_object_unref(resized_pixbuf);
19- }
20+ g_object_unref(resized_pixbuf);
21
22 gtk_widget_show(mi_data->icon);
23 } else {
24@@ -633,6 +631,7 @@
25 width,
26 height,
27 GDK_INTERP_BILINEAR);
28+ g_object_unref(pixbuf);
29 } else {
30 g_debug("Happy with icon sized %dx%d", gdk_pixbuf_get_width(pixbuf), gdk_pixbuf_get_height(pixbuf));
31 resized_pixbuf = pixbuf;
32@@ -640,10 +639,7 @@
33
34 gtk_image_set_from_pixbuf(GTK_IMAGE(mi_data->icon), resized_pixbuf);
35
36- /* The other pixbuf should be free'd by the dbusmenu. */
37- if (resized_pixbuf != pixbuf) {
38- g_object_unref(resized_pixbuf);
39- }
40+ g_object_unref(resized_pixbuf);
41 }
42 gtk_misc_set_alignment(GTK_MISC(mi_data->icon), 0.0, 0.5);
43 gtk_box_pack_start(GTK_BOX(hbox), mi_data->icon, FALSE, FALSE, 0);
44
450
=== modified file 'debian/patches/series'
--- debian/patches/series 2011-02-24 17:41:07 +0000
+++ debian/patches/series 2011-09-28 16:00:33 +0000
@@ -1,1 +0,0 @@
1lp_690668.patch
20
=== modified file 'src/indicator-messages.c'
--- src/indicator-messages.c 2011-08-25 02:29:38 +0000
+++ src/indicator-messages.c 2011-09-28 16:00:33 +0000
@@ -653,6 +653,7 @@
653 width,653 width,
654 height,654 height,
655 GDK_INTERP_BILINEAR);655 GDK_INTERP_BILINEAR);
656 g_object_unref(pixbuf);
656 } else {657 } else {
657 g_debug("Happy with icon sized %dx%d", gdk_pixbuf_get_width(pixbuf), gdk_pixbuf_get_height(pixbuf));658 g_debug("Happy with icon sized %dx%d", gdk_pixbuf_get_width(pixbuf), gdk_pixbuf_get_height(pixbuf));
658 resized_pixbuf = pixbuf;659 resized_pixbuf = pixbuf;
@@ -660,10 +661,7 @@
660 661
661 gtk_image_set_from_pixbuf(GTK_IMAGE(mi_data->icon), resized_pixbuf);662 gtk_image_set_from_pixbuf(GTK_IMAGE(mi_data->icon), resized_pixbuf);
662663
663 /* The other pixbuf should be free'd by the dbusmenu. */664 g_object_unref(resized_pixbuf);
664 if (resized_pixbuf != pixbuf) {
665 g_object_unref(resized_pixbuf);
666 }
667665
668 gtk_widget_show(mi_data->icon);666 gtk_widget_show(mi_data->icon);
669 } else {667 } else {
@@ -715,6 +713,7 @@
715 width,713 width,
716 height,714 height,
717 GDK_INTERP_BILINEAR);715 GDK_INTERP_BILINEAR);
716 g_object_unref(pixbuf);
718 } else {717 } else {
719 g_debug("Happy with icon sized %dx%d", gdk_pixbuf_get_width(pixbuf), gdk_pixbuf_get_height(pixbuf));718 g_debug("Happy with icon sized %dx%d", gdk_pixbuf_get_width(pixbuf), gdk_pixbuf_get_height(pixbuf));
720 resized_pixbuf = pixbuf;719 resized_pixbuf = pixbuf;
@@ -722,10 +721,7 @@
722 721
723 gtk_image_set_from_pixbuf(GTK_IMAGE(mi_data->icon), resized_pixbuf);722 gtk_image_set_from_pixbuf(GTK_IMAGE(mi_data->icon), resized_pixbuf);
724723
725 /* The other pixbuf should be free'd by the dbusmenu. */724 g_object_unref(resized_pixbuf);
726 if (resized_pixbuf != pixbuf) {
727 g_object_unref(resized_pixbuf);
728 }
729 }725 }
730 gtk_misc_set_alignment(GTK_MISC(mi_data->icon), 0.0, 0.5);726 gtk_misc_set_alignment(GTK_MISC(mi_data->icon), 0.0, 0.5);
731 gtk_box_pack_start(GTK_BOX(hbox), mi_data->icon, FALSE, FALSE, 0);727 gtk_box_pack_start(GTK_BOX(hbox), mi_data->icon, FALSE, FALSE, 0);

Subscribers

People subscribed via source and target branches

to all changes: