Merge ~ilasc/launchpad:bug-1852482 into launchpad:master
Proposed by
Ioana Lasc
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | a290acdfa1019d1cc2e28865c7310a631f245599 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~ilasc/launchpad:bug-1852482 |
Merge into: | launchpad:master |
Diff against target: |
107 lines (+42/-5) 3 files modified
lib/lp/code/errors.py (+21/-0) lib/lp/code/model/gitnamespace.py (+2/-5) lib/lp/code/model/tests/test_gitrepository.py (+19/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Approve | ||
Review via email: mp+375614@code.launchpad.net |
Commit message
GitRepositoryCr
To post a comment you must log in.
This doesn't really show the problem. You need the test to be under TestGitReposito ryWebservice, not TestGitReposito rySet; and you need to use the endpoint via a webservice caller and inspect the HTTP response. I'd expect the call to look something like:
response = webservice. named_post( "/+git" , "new", ...)
... with owner and target keyword arguments both set to the api_url of a user that isn't the one the webservice caller is acting as. Compare with other tests in TestGitReposito ryWebservice.