Merge lp:~iahmad/kubuntu-packaging/qtscript-enable-unit-tests into lp:~kubuntu-packagers/kubuntu-packaging/qtscript-opensource-src

Proposed by I Ahmad
Status: Merged
Merged at revision: 58
Proposed branch: lp:~iahmad/kubuntu-packaging/qtscript-enable-unit-tests
Merge into: lp:~kubuntu-packagers/kubuntu-packaging/qtscript-opensource-src
Diff against target: 76 lines (+23/-2)
5 files modified
debian/changelog (+5/-1)
debian/control (+2/-1)
debian/patches/enable-make-check.patch (+11/-0)
debian/patches/series (+1/-0)
debian/rules (+4/-0)
To merge this branch: bzr merge lp:~iahmad/kubuntu-packaging/qtscript-enable-unit-tests
Reviewer Review Type Date Requested Status
Timo Jyrinki Approve
Review via email: mp+199421@code.launchpad.net

Description of the change

Enabled the make check and fixed the failing tests.

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-12-16 10:44:35 +0000
+++ debian/changelog 2013-12-18 09:37:51 +0000
@@ -1,10 +1,14 @@
1qtscript-opensource-src (5.2.0+dfsg-0ubuntu1) UNRELEASED; urgency=low1qtscript-opensource-src (5.2.0+dfsg-0ubuntu1) UNRELEASED; urgency=low
22
3 [ Timo Jyrinki ]
3 * Sync with Debian, no remaining differences.4 * Sync with Debian, no remaining differences.
4 * New upstream release. 5 * New upstream release.
5 * Bump dependencies to 5.2.06 * Bump dependencies to 5.2.0
67
7 -- Timo Jyrinki <timo-jyrinki@ubuntu.com> Mon, 02 Sep 2013 12:40:58 +00008 [ Iftikhar Ahmad (QA Engineer) ]
9 * Enable make check and fix the failing tests.
10
11 -- Iftikhar Ahmad (QA Engineer) <iftikhar.ahmad@canonical.com> Wed, 18 Dec 2013 13:51:29 +0500
812
9qtscript-opensource-src (5.1.0+dfsg-3) unstable; urgency=low13qtscript-opensource-src (5.1.0+dfsg-3) unstable; urgency=low
1014
1115
=== modified file 'debian/control'
--- debian/control 2013-11-13 14:31:16 +0000
+++ debian/control 2013-12-18 09:37:51 +0000
@@ -12,7 +12,8 @@
12Build-Depends: debhelper (>= 9),12Build-Depends: debhelper (>= 9),
13 dpkg-dev (>= 1.16.1),13 dpkg-dev (>= 1.16.1),
14 pkg-kde-tools (>= 0.15.8~),14 pkg-kde-tools (>= 0.15.8~),
15 qtbase5-private-dev (>= 5.2.0~)15 qtbase5-private-dev (>= 5.2.0~),
16 xvfb
16Build-Depends-Indep: libqt5sql5-sqlite,17Build-Depends-Indep: libqt5sql5-sqlite,
17 qttools5-dev-tools (>= 5.2.0~)18 qttools5-dev-tools (>= 5.2.0~)
18Standards-Version: 3.9.419Standards-Version: 3.9.4
1920
=== added file 'debian/patches/enable-make-check.patch'
--- debian/patches/enable-make-check.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/enable-make-check.patch 2013-12-18 09:37:51 +0000
@@ -0,0 +1,11 @@
1--- a/tests/auto/qscriptextensionplugin/test/test.pro
2+++ b/tests/auto/qscriptextensionplugin/test/test.pro
3@@ -14,7 +14,7 @@ CONFIG(debug_and_release) {
4 DESTDIR = ../release
5 }
6 } else {
7- DESTDIR = ..
8+ DESTDIR = .
9 }
10
11 DEFINES += QT_DISABLE_DEPRECATED_BEFORE=0
012
=== modified file 'debian/patches/series'
--- debian/patches/series 2013-08-30 06:48:51 +0000
+++ debian/patches/series 2013-12-18 09:37:51 +0000
@@ -1,2 +1,3 @@
1enable-make-check.patch
1disable_v8_sunspider_tests.patch2disable_v8_sunspider_tests.patch
2s390x_jscore.diff3s390x_jscore.diff
34
=== modified file 'debian/rules'
--- debian/rules 2013-12-16 10:42:06 +0000
+++ debian/rules 2013-12-18 09:37:51 +0000
@@ -7,6 +7,7 @@
7export CXXFLAGS := $(shell dpkg-buildflags --get CXXFLAGS) $(shell dpkg-buildflags --get CPPFLAGS)7export CXXFLAGS := $(shell dpkg-buildflags --get CXXFLAGS) $(shell dpkg-buildflags --get CPPFLAGS)
8export LDFLAGS := $(shell dpkg-buildflags --get LDFLAGS) -Wl,--as-needed8export LDFLAGS := $(shell dpkg-buildflags --get LDFLAGS) -Wl,--as-needed
9export QT_SELECT := qt59export QT_SELECT := qt5
10export QT_QPA_PLATFORM := minimal
1011
11%:12%:
12 dh $@ --parallel --with pkgkde_symbolshelper --dbg-package=qtscript5-dbg13 dh $@ --parallel --with pkgkde_symbolshelper --dbg-package=qtscript5-dbg
@@ -35,3 +36,6 @@
35prune-nonfree:36prune-nonfree:
36 rm -rf tests/benchmarks/script/sunspider/*37 rm -rf tests/benchmarks/script/sunspider/*
37 rm -rf tests/benchmarks/script/v8/*38 rm -rf tests/benchmarks/script/v8/*
39
40override_dh_auto_test:
41 cd tests/auto/ && ( test -e Makefile || qmake auto.pro -o Makefile ) && xvfb-run make -f Makefile check

Subscribers

People subscribed via source and target branches

to all changes: