Merge lp:~hyuchia/appcenter/release-info into lp:~elementary-apps/appcenter/appcenter

Proposed by Diego Islas Ocampo
Status: Merged
Approved by: Jeremy Wootten
Approved revision: 413
Merged at revision: 410
Proposed branch: lp:~hyuchia/appcenter/release-info
Merge into: lp:~elementary-apps/appcenter/appcenter
Diff against target: 103 lines (+58/-29)
2 files modified
data/CMakeLists.txt (+1/-1)
data/appcenter.appdata.xml.in (+57/-28)
To merge this branch: bzr merge lp:~hyuchia/appcenter/release-info
Reviewer Review Type Date Requested Status
Jeremy Wootten code Approve
Review via email: mp+318870@code.launchpad.net

Commit message

* Add release information to the AppData.xml

Description of the change

Add release information to the AppData.xml file for appcenter support.

To post a comment you must log in.
Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Misspelling noted inline

lp:~hyuchia/appcenter/release-info updated
411. By Diego Islas Ocampo

Fix typo

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

appstream-utils validate gave the following errors:

• tag-missing : <translation> not specified
• tag-invalid : <project_group> is not valid
• style-invalid : Not enough <screenshot> tags
• style-invalid : <ul> cannot start a description [(null)]
• style-invalid : <li> is too short [Minor Bug Fixes]
• style-invalid : Not enough <p> tags for a good description

The last three do not occur in trunk, however validate-relax does not give these last three errors (only gives tag missing error) so they may not be important.

lp:~hyuchia/appcenter/release-info updated
412. By Diego Islas Ocampo

Add release description paragraphs

413. By Diego Islas Ocampo

Update AppData installation path

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Passes appstreamcli validate (with minor warning regarding one of the translations).
I am not sure whether leaving the old version in /usr/share/appdata matters - maybe the package can deal with that?

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/CMakeLists.txt'
--- data/CMakeLists.txt 2016-06-19 21:09:16 +0000
+++ data/CMakeLists.txt 2017-03-07 03:35:01 +0000
@@ -6,5 +6,5 @@
66
7install (FILES ${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.appcenter.desktop DESTINATION share/applications)7install (FILES ${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.appcenter.desktop DESTINATION share/applications)
8install (FILES ${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.appcenter-daemon.desktop DESTINATION share/applications)8install (FILES ${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.appcenter-daemon.desktop DESTINATION share/applications)
9install (FILES ${CMAKE_CURRENT_BINARY_DIR}/appcenter.appdata.xml DESTINATION share/appdata)9install (FILES ${CMAKE_CURRENT_BINARY_DIR}/appcenter.appdata.xml DESTINATION share/metainfo)
1010
1111
=== modified file 'data/appcenter.appdata.xml.in'
--- data/appcenter.appdata.xml.in 2016-06-18 14:56:43 +0000
+++ data/appcenter.appdata.xml.in 2017-03-07 03:35:01 +0000
@@ -1,31 +1,60 @@
1<?xml version="1.0" encoding="UTF-8"?>1<?xml version="1.0" encoding="UTF-8"?>
2<!-- Copyright 2015 elementary, LLC <contact@elementary.io> -->2<!-- Copyright 2015 elementary, LLC <contact@elementary.io> -->
3<component type="desktop">3<component type="desktop-application">
4 <id>org.pantheon.appcenter.desktop</id>4 <id>org.pantheon.appcenter.desktop</id>
5 <metadata_license>CC0-1.0</metadata_license>5 <metadata_license>CC0-1.0</metadata_license>
6 <project_group>elementary</project_group>6 <project_group>elementary</project_group>
7 <project_license>GPL-3.0+</project_license>7 <project_license>GPL-3.0+</project_license>
8 <_name>AppCenter</_name>8 <_name>AppCenter</_name>
9 <_summary>Browse and manage apps</_summary>9 <_summary>Browse and manage apps</_summary>
10 <description>10 <description>
11 <_p>11 <_p>
12 An app store for indie and open source developers. Browse by categories or12 An app store for indie and open source developers. Browse by categories or
13 search and discover new apps. AppCenter is also used for updating your13 search and discover new apps. AppCenter is also used for updating your
14 system to the latest and greatest version for new features and fixes.14 system to the latest and greatest version for new features and fixes.
15 </_p>15 </_p>
16 </description>16 </description>
17 <releases>17 <releases>
18 <release timestamp="1318750600" version="0.1"/>18 <release version="0.1.3" date="2016-12-05" urgency="medium">
19 </releases>19 <description>
20 <provides>20 <_p>Bug fixes and improve perfomance.</_p>
21 <binary>appcenter</binary>21 <ul>
22 <binary>appcenter-daemon</binary>22 <_li>Fix crash caused by entries with missing packages</_li>
23 <dbus type="user">org.pantheon.AppCenter</dbus>23 <_li>Translations Updates</_li>
24 </provides>24 </ul>
25 <developer_name>elementary LLC.</developer_name>25 </description>
26 <url type="homepage">http://elementary.io/</url>26 </release>
27 <url type="bugtracker">https://bugs.launchpad.net/appcenter</url>27 <release version="0.1.2" date="2016-10-29" urgency="medium">
28 <url type="donation">https://elementary.io/get-involved#funding</url>28 <description>
29 <url type="help">https://elementaryos.stackexchange.com/questions/tagged/appcenter</url>29 <_p>Add capability to search by category and apply minor bug fixes.</_p>
30 <update_contact>contact_at_elementary.io</update_contact>30 <ul>
31 <_li>It is now possible to search apps inside a category</_li>
32 <_li>Prevent multiple authentication dialogs when resuming from suspend</_li>
33 <_li>Translations Updates</_li>
34 </ul>
35 </description>
36 </release>
37 <release version="0.1.1" date="2016-09-26" urgency="medium">
38 <description>
39 <_p>Search perfomance has beeen improved, the category name is now shown on the headbar and minor bugs have been fixed.</_p>
40 <ul>
41 <_li>Fix Steam installation</_li>
42 <_li>Make search asynchronous</_li>
43 <_li>Translations Updates</_li>
44 </ul>
45 </description>
46 </release>
47 <release version="0.1.0" date="2016-08-15"/>
48 </releases>
49 <provides>
50 <binary>appcenter</binary>
51 <binary>appcenter-daemon</binary>
52 <dbus type="user">org.pantheon.AppCenter</dbus>
53 </provides>
54 <developer_name>elementary LLC.</developer_name>
55 <url type="homepage">http://elementary.io/</url>
56 <url type="bugtracker">https://bugs.launchpad.net/appcenter</url>
57 <url type="donation">https://elementary.io/get-involved#funding</url>
58 <url type="help">https://elementaryos.stackexchange.com/questions/tagged/appcenter</url>
59 <update_contact>contact_at_elementary.io</update_contact>
31</component>60</component>

Subscribers

People subscribed via source and target branches