Merge lp:~humpolec-team/humpolec/cleanup-ant-setup into lp:~humpolec-team/humpolec/UbuntuInstaller-refactor

Proposed by Michał Karnicki
Status: Merged
Approved by: Ondrej Kubik
Approved revision: 67
Merged at revision: 66
Proposed branch: lp:~humpolec-team/humpolec/cleanup-ant-setup
Merge into: lp:~humpolec-team/humpolec/UbuntuInstaller-refactor
Diff against target: 157 lines (+67/-39)
5 files modified
.bzrignore (+0/-1)
ant.properties (+21/-0)
build.xml (+35/-37)
check-sdk.sh (+10/-0)
project.properties (+1/-1)
To merge this branch: bzr merge lp:~humpolec-team/humpolec/cleanup-ant-setup
Reviewer Review Type Date Requested Status
Ondrej Kubik Approve
Review via email: mp+213694@code.launchpad.net

Description of the change

Clean-up ant setup. Note ant.properties pointing to key store. I have a feeling make_release script does some shenanigans. We should use `ant release` instead.

To post a comment you must log in.
67. By Michał Karnicki

Remove incorrect bzr ignore.

Revision history for this message
Ondrej Kubik (ondrak) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file '.bzrignore'
--- .bzrignore 2014-03-25 00:47:52 +0000
+++ .bzrignore 2014-04-01 17:33:26 +0000
@@ -3,5 +3,4 @@
3local.properties3local.properties
4bin4bin
5gen5gen
6android-ubuntu-launcher.apk
76
87
=== added file 'ant.properties'
--- ant.properties 1970-01-01 00:00:00 +0000
+++ ant.properties 2014-04-01 17:33:26 +0000
@@ -0,0 +1,21 @@
1# This file is used to override default values used by the Ant build system.
2#
3# This file must be checked in Version Control Systems, as it is
4# integral to the build system of your project.
5
6# This file is only used by the Ant script.
7
8# You can use this to override default values such as
9# 'source.dir' for the location of your java source folder and
10# 'out.dir' for the location of your output folder.
11
12# You can also use it define how the release builds are signed by declaring
13# the following properties:
14# 'key.store' for the location of your keystore and
15# 'key.alias' for the name of the key to use.
16# The password will be asked during the build when you use the 'release' target.
17
18java.encoding=UTF-8
19
20key.store=../humpolec.keystore
21key.alias=humpolec
022
=== modified file 'build.xml'
--- build.xml 2013-12-08 16:01:23 +0000
+++ build.xml 2014-04-01 17:33:26 +0000
@@ -1,31 +1,40 @@
1<?xml version="1.0" encoding="UTF-8"?>1<?xml version="1.0" encoding="UTF-8"?>
2<project name="MainActivity" default="help">2<project name="ubuntu-dual-boot" default="help">
33
4 <!-- The local.properties file is created and updated by the 'android' tool.4 <description>
5 It contains the path to the SDK. It should *NOT* be checked into5 *** Humpolec - Ubuntu Dual Boot for Android ***
6 Version Control Systems. -->6
7 http://launchpad.net/humpolec
8
9 Ubuntu Dual Boot is provided to developers who want to contribute to development
10 of Ubuntu for Phones and give them an ability to run Ubuntu and Android on
11 a single device. It is not intended to be used by regular users.
12
13 Make sure you have Android SDK installed!
14
15 Contact:
16 Ondrej Kubik ondrej.kubik@canonical.com
17 Michal Karnicki michal.karnicki@canonical.com
18 </description>
19
20 <!-- Check if android is present. -->
21 <exec executable="./check-sdk.sh" failonerror="true">
22 </exec>
23
24 <property file="project.properties" />
25
26 <exec executable="android">
27 <arg value="update" />
28 <arg value="project" />
29 <arg value="-p" />
30 <arg value="." />
31 <arg value="-t" />
32 <arg value="${target}" />
33 <!-- Watch out: using name argument will ignore the custom build.xml version-tag! -->
34 </exec>
35
7 <property file="local.properties" />36 <property file="local.properties" />
837
9 <!-- The ant.properties file can be created by you. It is only edited by the
10 'android' tool to add properties to it.
11 This is the place to change some Ant specific build properties.
12 Here are some properties you may want to change/update:
13
14 source.dir
15 The name of the source directory. Default is 'src'.
16 out.dir
17 The name of the output directory. Default is 'bin'.
18
19 For other overridable properties, look at the beginning of the rules
20 files in the SDK, at tools/ant/build.xml
21
22 Properties related to the SDK location or the project target should
23 be updated using the 'android' tool with the 'update' action.
24
25 This file is an integral part of the build system for your
26 application and should be checked into Version Control Systems.
27
28 -->
29 <property file="ant.properties" />38 <property file="ant.properties" />
3039
31 <!-- if sdk.dir was not set from one of the property file, then40 <!-- if sdk.dir was not set from one of the property file, then
@@ -37,17 +46,6 @@
37 <isset property="env.ANDROID_HOME" />46 <isset property="env.ANDROID_HOME" />
38 </condition>47 </condition>
3948
40 <!-- The project.properties file is created and updated by the 'android'
41 tool, as well as ADT.
42
43 This contains project specific properties such as project target, and library
44 dependencies. Lower level build properties are stored in ant.properties
45 (or in .classpath for Eclipse projects).
46
47 This file is an integral part of the build system for your
48 application and should be checked into Version Control Systems. -->
49 <loadproperties srcFile="project.properties" />
50
51 <!-- quick check on sdk.dir -->49 <!-- quick check on sdk.dir -->
52 <fail50 <fail
53 message="sdk.dir is missing. Make sure to generate local.properties using 'android update project' or to inject it through the ANDROID_HOME environment variable."51 message="sdk.dir is missing. Make sure to generate local.properties using 'android update project' or to inject it through the ANDROID_HOME environment variable."
@@ -86,7 +84,7 @@
86 In all cases you must update the value of version-tag below to read 'custom' instead of an integer,84 In all cases you must update the value of version-tag below to read 'custom' instead of an integer,
87 in order to avoid having your file be overridden by tools such as "android update project"85 in order to avoid having your file be overridden by tools such as "android update project"
88 -->86 -->
89 <!-- version-tag: 1 -->87 <!-- version-tag: custom -->
90 <import file="${sdk.dir}/tools/ant/build.xml" />88 <import file="${sdk.dir}/tools/ant/build.xml" />
9189
92</project>90</project>
9391
=== added file 'check-sdk.sh'
--- check-sdk.sh 1970-01-01 00:00:00 +0000
+++ check-sdk.sh 2014-04-01 17:33:26 +0000
@@ -0,0 +1,10 @@
1#!/bin/bash
2
3ANDROIDBIN=$(which android)
4if test -z "${ANDROIDBIN}"; then
5 echo "Android SDK tools not in PATH, fix with:" >&2
6 echo " PATH=\$PATH:/PathToSDK/tools" >&2
7 exit 1
8fi
9
10exit 0
011
=== modified file 'project.properties'
--- project.properties 2013-12-12 02:02:35 +0000
+++ project.properties 2014-04-01 17:33:26 +0000
@@ -11,4 +11,4 @@
11#proguard.config=${sdk.dir}/tools/proguard/proguard-android.txt:proguard-project.txt11#proguard.config=${sdk.dir}/tools/proguard/proguard-android.txt:proguard-project.txt
1212
13# Project target.13# Project target.
14target=Google Inc.:Google APIs:1914target=android-19

Subscribers

People subscribed via source and target branches