Merge lp:~hrvojem/percona-server/bug860922-5.1 into lp:percona-server/5.1

[Hrvoje Matijakovic]

[Alexey Kopytov (akopytov)]

Hrvoje,

Some minor comments:

- s/This variable allow/This variable allows/
- "Each the thread is called, its activity is altered..." -- I'm not sure what that is supposed to mean. Perhaps "Each time the insert buffer merge is performed by the InnoDB master thread, its activity is affected..."?
- innodb_ibuf_active_contract -- I don't think it's adequately documented, but its purpose eludes me. Perhaps Vadim knows it. Feel free to report it as a separate bug and the consider this MP approved after addressing other comments.

I think we should also have the same fix in 5.5, so I have targeted the bug accordingly.

review: Needs Fixing

=== modified file 'doc/source/conf.py'
--- doc/source/conf.py	2012-02-08 07:31:56 +0000
+++ doc/source/conf.py	2012-03-09 08:07:21 +0000
@@ -266,5 +266,5 @@
 intersphinx_mapping = {
     'ps55' : ('http://www.percona.com/doc/percona-server/5.5/', None),
     'xtrabackup' : ('http://www.percona.com/doc/percona-xtrabackup', None),
-    'ptoolkit' : ('http://www.percona.com/doc/percona-toolkit', None)
+    'ptoolkit' : ('http://www.percona.com/doc/percona-toolkit/2.0/', None)
  }
 
=== modified file 'doc/source/glossary.rst'
--- doc/source/glossary.rst	2012-01-31 14:24:44 +0000
+++ doc/source/glossary.rst	2012-03-09 08:07:21 +0000
@@ -29,14 +29,13 @@
 
     Drizzle Charter:
 
-     * A database optimized for Cloud infrastructure and Web applications.
-     * Design for massive concurrency on modern multi-cpu architecture
-     * Optimize memory for increased performance and parallelism
-     * Open source, open community, open design Scope
-     * Re-designed modular architecture providing plugins with defined APIs
-     * Simple design for ease of use and administration
-     * Reliable, ACID transactional
-
+      * A database optimized for Cloud infrastructure and Web applications.
+      * Design for massive concurrency on modern multi-cpu architecture
+      * Optimize memory for increased performance and parallelism
+      * Open source, open community, open design Scope
+      * Re-designed modular architecture providing plugins with defined APIs
+      * Simple design for ease of use and administration
+      * Reliable, ACID transactional
 
   Durability
     Once a transaction is committed, it will remain so.
@@ -59,14 +58,13 @@
     on all platforms.
 
   Jenkins
-     `Jenkins <http://www.jenkins-ci.org>`_ is a continuous integration
+    `Jenkins <http://www.jenkins-ci.org>`_ is a continuous integration
     system that we use to help ensure the continued quality of the
     software we produce. It helps us achieve the aims of:
 
-     * no failed tests in trunk on any platform,
-     * aid developers in ensuring merge requests build and test on all platforms,
-     * no known performance regressions (without a damn good explanation).
-
+      * no failed tests in trunk on any platform,
+      * aid developers in ensuring merge requests build and test on all platforms,
+      * no known performance regressions (without a damn good explanation).
 
   LSN
     Log Serial Number. A term used in relation to the :term:`InnoDB` or
@@ -92,7 +90,6 @@
     the Oracle distribution of MySQL as distinct from the drop-in
     replacements such as :term:`MariaDB` and :term:`Percona Server`.
 
-
   Percona Server
     Percona's branch of :term:`MySQL` with performance and management improvements.
 
 
=== modified file 'doc/source/index.rst'
--- doc/source/index.rst	2012-01-31 10:35:01 +0000
+++ doc/source/index.rst	2012-03-09 08:07:21 +0000
@@ -57,6 +57,7 @@
    :glob:
 
    scalability/innodb_split_buf_pool_mutex
+   scalability/innodb_insert_buffer
    scalability/innodb_io
    scalability/innodb_extra_rseg
    scalability/innodb_expand_undo_slots
 
=== added file 'doc/source/scalability/innodb_insert_buffer.rst'
--- doc/source/scalability/innodb_insert_buffer.rst	1970-01-01 00:00:00 +0000
+++ doc/source/scalability/innodb_insert_buffer.rst	2012-03-09 08:07:21 +0000
@@ -0,0 +1,69 @@
+.. _innodb_insert_buffer: 
+
+==========================
+Configurable Insert Buffer
+==========================
+
+Percona has implemented several changes related to MySQL's InnoDB Insert Buffer. These features enable adjusting the insert buffer to the different workloads and hardware configurations.
+
+System variables:
+=================
+
+.. variable:: innodb_ibuf_accel_rate
+
+     :cli: Yes
+     :conf: Yes
+     :scope: Global
+     :dyn: Yes
+     :vartype: Numeric
+     :default: 100
+     :range: 100 - 999999999
+
+This variable allows a better control of the background thread processing the insert buffer. Each time the insert buffer merge is performed by the InnoDB master thread, its activity is affected by the value of both :variable:`innodb_io_capacity` and :variable:`innodb_ibuf_accel_rate` this way: ::
+
+  [real activity] = [default activity] * (innodb_io_capacity/100) * (innodb_ibuf_accel_rate/100)
+
+
+By increasing the value of :variable:`innodb_ibuf_accel_rate`, you will increase the insert buffer activity
+
+.. variable:: innodb_ibuf_active_contract
+
+     :cli: Yes
+     :conf: Yes
+     :scope: Global
+     :dyn: Yes
+     :vartype: Numeric
+     :default: 0(1.0.5), 1(1.0.6)
+     :range: 0 - 1
+
+This variable specifies whether the insert buffer can be processed before it reaches its maximum size. The following values are allowed:
+
+  * 0:
+    The insert buffer is not processed until it is full. This is the standard |InnoDB| behavior.
+
+  * 1:
+    The insert buffer can be processed even it is not full.
+
+
+.. variable:: innodb_ibuf_max_size
+
+     :cli: Yes
+     :conf: Yes
+     :scope: Global
+     :dyn: No
+     :vartype: Numeric
+     :default: Half the size of the |InnoDB| buffer pool
+     :range: 0 - Half the size of the |InnoDB| buffer pool
+     :unit: Bytes
+
+This variable specifies the maximum size of the insert buffer. By default the insert buffer is half the size of the buffer pool so if you have a very large buffer pool, the insert buffer will be very large too and you may want to restrict its size with this variable.
+
+Setting this variable to 0 is equivalent to disabling the insert buffer. But then all changes to secondary indexes will be performed synchronously which will probably cause performance degradation. Likewise a too small value can hurt performance.
+
+If you have very fast storage (ie storage with RAM-level speed, not just a RAID with fast disks), a value of a few MB may be the best choice for maximum performance.
+
+Other Reading
+=============
+
+* `Some little known facts about InnoDB Insert Buffer <http://www.mysqlperformanceblog.com/2009/01/13/some-little-known-facts-about-innodb-insert-buffer/>`_
+* `5.0.75-build12 Percona binaries <http://www.mysqlperformanceblog.com/2009/01/23/5075-build12-percona-binaries/>`_
 
=== modified file 'doc/source/scalability/innodb_io.rst'
--- doc/source/scalability/innodb_io.rst	2012-02-07 13:43:02 +0000
+++ doc/source/scalability/innodb_io.rst	2012-03-09 08:07:21 +0000
@@ -36,7 +36,7 @@
 
 .. variable:: innodb_adaptive_checkpoint
 
-   :version 5.1.54-12.5 Added 
+   :version: 5.1.54-12.5 Added 
    :cli: Yes
    :conf: Yes
    :scope: Global
@@ -109,7 +109,7 @@
 
 .. variable:: innodb_flush_log_at_trx_commit_session
 
-     :version 5.1.49-13 Added
+     :version: 5.1.49-13 Added
      :cli: Yes
      :conf: Yes
      :scope: Global
@@ -176,60 +176,6 @@
 
 If you use a storage which has no “head seek delay” (e.g. SSD or enough memory for write buffering), 0 may show better performance.
 
-.. variable:: innodb_ibuf_accel_rate
-
-     :cli: Yes
-     :conf: Yes
-     :scope: Global
-     :dyn: Yes
-     :vartype: Numeric
-     :default: 100
-     :range: 100 - 999999999
-
-This variable allow a better control of the background thread processing the insert buffer. Each the thread is called, its activity is altered by the value of both :variable:`innodb_io_capacity` and :variable:`innodb_ibuf_accel_rate` this way: ::
-
-  [real activity] = [default activity] * (innodb_io_capacity/100) * (innodb_ibuf_accel_rate/100)
-
-
-By increasing the value of :variable:`innodb_ibuf_accel_rate`, you will increase the insert buffer activity
-
-.. variable:: innodb_ibuf_active_contract
-
-     :cli: Yes
-     :conf: Yes
-     :scope: Global
-     :dyn: Yes
-     :vartype: Numeric
-     :default: 0(1.0.5), 1(1.0.6)
-     :range: 0 - 1
-
-This variable specifies whether the insert buffer can be processed before it reaches its maximum size. The following values are allowed:
-
-  * 0: 
-    The insert buffer is not processed until it is full. This is the standard |InnoDB| behavior.
-
-  * 1: 
-    The insert buffer can be processed even it is not full.
-
-
-.. variable:: innodb_ibuf_max_size
-
-     :cli: Yes
-     :conf: Yes
-     :scope: Global
-     :dyn: No
-     :vartype: Numeric
-     :default: Half the size of the |InnoDB| buffer pool
-     :range: 0 - Half the size of the |InnoDB| buffer pool
-     :unit: Bytes
-
-This variable specifies the maximum size of the insert buffer. By default the insert buffer is half the size of the buffer pool so if you have a very large buffer pool, the insert buffer will be very large too and you may want to restrict its size with this variable.
-
-Setting this variable to 0 is equivalent to disabling the insert buffer. But then all changes to secondary indexes will be performed synchronously which will probably cause performance degradation. Likewise a too small value can hurt performance.
-
-If you have very fast storage (ie storage with RAM-level speed, not just a RAID with fast disks), a value of a few MB may be the best choice for maximum performance.
-
-
 .. variable:: innodb_log_block_size
 
      :cli: Yes