Merge lp:~hingo/libdrizzle/libdrizzle-versioning into lp:libdrizzle/1.0

Proposed by Henrik Ingo
Status: Rejected
Rejected by: Andrew Hutchings
Proposed branch: lp:~hingo/libdrizzle/libdrizzle-versioning
Merge into: lp:libdrizzle/1.0
Diff against target: 83 lines (+21/-4)
4 files modified
.bzrignore (+1/-2)
ChangeLog (+7/-0)
config/drizzle.ver (+1/-0)
configure.ac (+12/-2)
To merge this branch: bzr merge lp:~hingo/libdrizzle/libdrizzle-versioning
Reviewer Review Type Date Requested Status
Andrew Hutchings Disapprove
Review via email: mp+92814@code.launchpad.net

Description of the change

This is based on my ramblings in the libdrizzle thread on drizzle-discuss
https://lists.launchpad.net/drizzle-discuss/msg08698.html

There are various fixes, but most importantly I felt that the only sane thing to do is to bump the so version to 4.0.0 since 2.0 is ambiguous (the so version 2.0.1 is based on the code in libdrizzle-1.0 and so version 3.0.0 is libdrizzle-2.0...)

If this is cool and you merge it, you should also merge the corresponding change to 4.0.0 on lp:drizzle side:
lp:~hingo/drizzle/drizzle-libdrizzle-version-sync

To post a comment you must log in.
2504. By Henrik Ingo

Move OLDLIBDRIZZLE_LIBRARY_VERSION down to 2.0.1 since a drizzle rc
has been released with this number. (Discussion about 4.0.0 still
ongoing, but this is the correct value for now.)

2505. By Henrik Ingo

Match changes that Brian did at lp:~brianaker/drizzle/fix-libdrizzle-version

The variable name is now LIBDRIZZLE_LIBRARY_VERSION
The version is 4:0:0
(This builds the libdrizzle-1.0/ sources. libdrizzle-2.0/ is vanished
from configure.)

Revision history for this message
Andrew Hutchings (linuxjedi) wrote :

1.0 branch now obsolete.

review: Disapprove

Unmerged revisions

2505. By Henrik Ingo

Match changes that Brian did at lp:~brianaker/drizzle/fix-libdrizzle-version

The variable name is now LIBDRIZZLE_LIBRARY_VERSION
The version is 4:0:0
(This builds the libdrizzle-1.0/ sources. libdrizzle-2.0/ is vanished
from configure.)

2504. By Henrik Ingo

Move OLDLIBDRIZZLE_LIBRARY_VERSION down to 2.0.1 since a drizzle rc
has been released with this number. (Discussion about 4.0.0 still
ongoing, but this is the correct value for now.)

2503. By Henrik Ingo

Changed LIBDRIZZLE_LIBRARY_VERSION back to OLDLIBDRIZZLE_LIBRARY_VERSION
so that is is the same variable in lp:libdrizzle and in lp:drizzle.
(Also, keeping the same name as was used until now helps people follow
which is which.)

Bumped library version to 4:0:0 to avoid ambiguity of 2.0, 1.0 and 3.0.
Also the AC_INIT version is 4.0.0.

Changed package name to libdrizzle4.

Copied back LD_VERSION_SCRIPT.

make dist expects a ChangeLog. Created one that says to read the
drizzle ChangeLog.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file '.bzrignore'
--- .bzrignore 2012-02-12 10:27:08 +0000
+++ .bzrignore 2012-02-19 21:04:17 +0000
@@ -15,13 +15,11 @@
15*.rpm15*.rpm
16*replication.pb.*16*replication.pb.*
17*stamp-h17*stamp-h
18./ChangeLog
19.DS_Store18.DS_Store
20.deps19.deps
21.libs20.libs
22.plugin.ini.stamp21.plugin.ini.stamp
23.plugin.scan22.plugin.scan
24ChangeLog
25DEPENDENCIES23DEPENDENCIES
26INSTALL24INSTALL
27Makefile25Makefile
@@ -44,6 +42,7 @@
44client/drizzletest42client/drizzletest
45client/mysqlslap43client/mysqlslap
46client/drizzle_password_hash44client/drizzle_password_hash
45config.in
47comp_creator.gcno46comp_creator.gcno
48compile47compile
49config.guess48config.guess
5049
=== added file 'ChangeLog'
--- ChangeLog 1970-01-01 00:00:00 +0000
+++ ChangeLog 2012-02-19 21:04:17 +0000
@@ -0,0 +1,7 @@
1This is a standalone distribution of libdrizzle. The development of libdrizzle
2takes place in the main drizzle repository lp:drizzle. Please see the ChangeLog
3from a full drizzle distribution, it covers also changes to libdrizzle.
4
5Alternatively you can look at the commit history of the drizzle trunk, from
6which the drizzle ChangeLog is generated:
7bazaar.launchpad.net/~drizzle-developers/drizzle/development/files/head:/
0\ No newline at end of file8\ No newline at end of file
19
=== added file 'config/drizzle.ver'
--- config/drizzle.ver 1970-01-01 00:00:00 +0000
+++ config/drizzle.ver 2012-02-19 21:04:17 +0000
@@ -0,0 +1,1 @@
1DRIZZLE7 { global: *; };
02
=== modified file 'configure.ac'
--- configure.ac 2012-02-12 10:12:32 +0000
+++ configure.ac 2012-02-19 21:04:17 +0000
@@ -8,7 +8,9 @@
8# Use and distribution licensed under the BSD license. See8# Use and distribution licensed under the BSD license. See
9# the COPYING file in this directory for full text.9# the COPYING file in this directory for full text.
1010
11AC_INIT([libdrizzle],[1.0.1],[http://launchpad.net/libdrizzle])11# The full version number (4.0.0) must be updated in 2 places and the major
12# version (4) in one additional place. If you find all 3 you get a price!
13AC_INIT([libdrizzle4],[4.0.0],[http://launchpad.net/libdrizzle])
1214
13AC_CONFIG_AUX_DIR(config)15AC_CONFIG_AUX_DIR(config)
1416
@@ -29,7 +31,7 @@
2931
30PANDORA_CANONICAL_TARGET(ignore-shared-ptr)32PANDORA_CANONICAL_TARGET(ignore-shared-ptr)
3133
32LIBDRIZZLE_LIBRARY_VERSION=3:0:034LIBDRIZZLE_LIBRARY_VERSION=4:0:0
33# | | |35# | | |
34# +------+ | +---+36# +------+ | +---+
35# | | |37# | | |
@@ -44,6 +46,14 @@
44# changed46# changed
45AC_SUBST(LIBDRIZZLE_LIBRARY_VERSION)47AC_SUBST(LIBDRIZZLE_LIBRARY_VERSION)
4648
49# libdrizzle versioning when linked with GNU ld.
50AS_IF([test "$lt_cv_prog_gnu_ld" = "yes"],[
51 LD_VERSION_SCRIPT="-Wl,--version-script=\$(top_srcdir)/config/drizzle.ver"
52 ])
53AC_SUBST(LD_VERSION_SCRIPT)
54
55
56
47LT_PREREQ([2.2])57LT_PREREQ([2.2])
48LT_INIT()58LT_INIT()
49LT_LANG([C++])59LT_LANG([C++])

Subscribers

People subscribed via source and target branches