Merge lp:~gz/charms/precise/juju-reports/cidata-url into lp:~juju-qa/charms/precise/juju-reports/trunk

Proposed by Martin Packman
Status: Merged
Approved by: Martin Packman
Approved revision: 49
Merged at revision: 49
Proposed branch: lp:~gz/charms/precise/juju-reports/cidata-url
Merge into: lp:~juju-qa/charms/precise/juju-reports/trunk
Diff against target: 47 lines (+9/-3)
2 files modified
config.yaml (+4/-0)
hooks/common.py (+5/-3)
To merge this branch: bzr merge lp:~gz/charms/precise/juju-reports/cidata-url
Reviewer Review Type Date Requested Status
Aaron Bentley (community) Approve
Review via email: mp+246213@code.launchpad.net

Description of the change

Adds new config value for the location of the S3 mirror.

Maybe quibble over whether we want all the path like this, or just the scheme and domain?

To post a comment you must log in.
49. By Martin Packman

Add cidata-url config setting for referencing build artifacts

Revision history for this message
Aaron Bentley (abentley) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'config.yaml'
--- config.yaml 2014-11-10 14:31:29 +0000
+++ config.yaml 2015-01-12 19:12:10 +0000
@@ -44,6 +44,10 @@
44 type: string44 type: string
45 default: http://juju-ci.vapour.ws:808045 default: http://juju-ci.vapour.ws:8080
46 description: "The Jenkins URL to use for retrieving Juju CI data."46 description: "The Jenkins URL to use for retrieving Juju CI data."
47 cidata-url:
48 type: string
49 default: http://data.vapour.ws/juju-ci/products
50 description: "The S3 mirror URL to use for linking build artifacts."
47 aws-access-key:51 aws-access-key:
48 type: string52 type: string
49 default: ""53 default: ""
5054
=== modified file 'hooks/common.py'
--- hooks/common.py 2014-11-21 16:47:22 +0000
+++ hooks/common.py 2015-01-12 19:12:10 +0000
@@ -35,8 +35,9 @@
35 return os.path.join(source_path, 'resources/{}.template'.format(name))35 return os.path.join(source_path, 'resources/{}.template'.format(name))
3636
3737
38def install_ini(mongo_url, gh_token, jujuci_url, token, error_email,38def install_ini(mongo_url, gh_token, jujuci_url, cidata_url, token,
39 error_email_from, cloud_health_failure_threshold, source_path):39 error_email, error_email_from, cloud_health_failure_threshold,
40 source_path):
40 config = ConfigParser()41 config = ConfigParser()
41 path = get_template_path(INI, source_path)42 path = get_template_path(INI, source_path)
42 if not os.path.exists(path):43 if not os.path.exists(path):
@@ -45,6 +46,7 @@
45 config.set('app:main', 'mongo.url', mongo_url)46 config.set('app:main', 'mongo.url', mongo_url)
46 config.set('app:main', 'gh_token', gh_token)47 config.set('app:main', 'gh_token', gh_token)
47 config.set('app:main', 'jujuci.url', jujuci_url)48 config.set('app:main', 'jujuci.url', jujuci_url)
49 config.set('app:main', 'cidata.url', cidata_url)
48 config.set('app:main', 'charm_bundle_test_token', token)50 config.set('app:main', 'charm_bundle_test_token', token)
49 config.set('app:main', 'home', HOME)51 config.set('app:main', 'home', HOME)
50 config.set('app:main', 'error_email', error_email)52 config.set('app:main', 'error_email', error_email)
@@ -337,7 +339,7 @@
337 make_project_link(source_path, config['source'], config['revno'])339 make_project_link(source_path, config['source'], config['revno'])
338 return340 return
339 ini = install_ini(mongo_url, config['gh-token'], config['jujuci-url'],341 ini = install_ini(mongo_url, config['gh-token'], config['jujuci-url'],
340 config['charm-bundle-test-token'],342 config['cidata-url'], config['charm-bundle-test-token'],
341 config['error-email'], config['error-email-from'],343 config['error-email'], config['error-email-from'],
342 config['cloud-health-failure-threshold'], source_path)344 config['cloud-health-failure-threshold'], source_path)
343 configure_s3(config, source_path)345 configure_s3(config, source_path)

Subscribers

People subscribed via source and target branches

to all changes: