Merge lp:~gnuoy/charms/trusty/glance/1537769 into lp:~openstack-charmers-archive/charms/trusty/glance/next

Proposed by Liam Young
Status: Merged
Merged at revision: 165
Proposed branch: lp:~gnuoy/charms/trusty/glance/1537769
Merge into: lp:~openstack-charmers-archive/charms/trusty/glance/next
Diff against target: 21 lines (+3/-1)
1 file modified
hooks/glance_utils.py (+3/-1)
To merge this branch: bzr merge lp:~gnuoy/charms/trusty/glance/1537769
Reviewer Review Type Date Requested Status
James Page Approve
Review via email: mp+284007@code.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #18192 glance-next for gnuoy mp284007
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/18192/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #16952 glance-next for gnuoy mp284007
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/16952/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #9058 glance-next for gnuoy mp284007
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/14673165/
Build: http://10.245.162.77:8080/job/charm_amulet_test/9058/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #9067 glance-next for gnuoy mp284007
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/14675133/
Build: http://10.245.162.77:8080/job/charm_amulet_test/9067/

166. By Liam Young

Late import requests

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #18197 glance-next for gnuoy mp284007
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/18197/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #16955 glance-next for gnuoy mp284007
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/16955/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #9070 glance-next for gnuoy mp284007
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/14679680/
Build: http://10.245.162.77:8080/job/charm_amulet_test/9070/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #9072 glance-next for gnuoy mp284007
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/9072/

Revision history for this message
James Page (james-page) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'hooks/glance_utils.py'
--- hooks/glance_utils.py 2016-01-21 18:53:31 +0000
+++ hooks/glance_utils.py 2016-01-27 12:41:36 +0000
@@ -473,6 +473,7 @@
473 """Generate a temp URL key, post it to Swift and return its value.473 """Generate a temp URL key, post it to Swift and return its value.
474 If it is already posted, the current value of the key will be returned.474 If it is already posted, the current value of the key will be returned.
475 """475 """
476 import requests
476 keystone_ctxt = context.IdentityServiceContext(service='glance',477 keystone_ctxt = context.IdentityServiceContext(service='glance',
477 service_user='glance')()478 service_user='glance')()
478 if not keystone_ctxt:479 if not keystone_ctxt:
@@ -487,7 +488,8 @@
487 from swiftclient import exceptions488 from swiftclient import exceptions
488489
489 @retry_on_exception(15, base_delay=10,490 @retry_on_exception(15, base_delay=10,
490 exc_type=exceptions.ClientException)491 exc_type=(exceptions.ClientException,
492 requests.exceptions.ConnectionError))
491 def connect_and_post():493 def connect_and_post():
492 log('Connecting swift client...')494 log('Connecting swift client...')
493 swift_connection = client.Connection(495 swift_connection = client.Connection(

Subscribers

People subscribed via source and target branches