Merge lp:~gmb/launchpad/prompt-user-to-subscribe-to-master-bug-485627 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Edwin Grubbs |
Approved revision: | no longer in the source branch. |
Merged at revision: | 11488 |
Proposed branch: | lp:~gmb/launchpad/prompt-user-to-subscribe-to-master-bug-485627 |
Merge into: | lp:launchpad |
Diff against target: |
370 lines (+116/-51) 4 files modified
lib/lp/bugs/adapters/bugchange.py (+25/-9) lib/lp/bugs/doc/bug-change.txt (+1/-0) lib/lp/bugs/doc/bugnotification-sending.txt (+50/-31) lib/lp/bugs/tests/test_bugchanges.py (+40/-11) |
To merge this branch: | bzr merge lp:~gmb/launchpad/prompt-user-to-subscribe-to-master-bug-485627 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Edwin Grubbs (community) | code | Approve | |
Review via email: mp+34302@code.launchpad.net |
Commit message
Users will now be prompted to subscribe to the master bug when they are notified that one bug has been marked as a duplicate of another.
Description of the change
This branch adds a link to notifications about bugs being marked as a
duplicate, prompting the user to subscribe to the master bug.
Changes made:
== lib/lp/
- I've updated the BugDuplicateChange class to add the 'you can
subscribe by following this link' footer to duplication
notifications.
- I've cleaned up some lint.
== lib/lp/
- Weirdly, this test failed after I'd made my change, but in a code
path not related to my changes. Adding the switch_db_user calls to
the point of failure fixed it; AFAICT this test should never have
passed in the first place.
- I've taken the opportunity to move this test to ReST format and to
clean up some lint.
== lib/lp/
- I've updated the tests for bug duplicate notifications to reflect the
changes made to bugchange.py above.
Hi Graham,
This branch looks good.
-Edwin