Merge lp:~gmb/launchpad/bug-1009712 into lp:launchpad
Proposed by
Graham Binns
Status: | Merged |
---|---|
Approved by: | Graham Binns |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15384 |
Proposed branch: | lp:~gmb/launchpad/bug-1009712 |
Merge into: | lp:launchpad |
Diff against target: |
52 lines (+19/-3) 2 files modified
lib/lp/services/features/__init__.py (+8/-1) lib/lp/testing/tests/test_testing.py (+11/-2) |
To merge this branch: | bzr merge lp:~gmb/launchpad/bug-1009712 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Abel Deuring (community) | code | Approve | |
Review via email: mp+109315@code.launchpad.net |
Commit message
test_set_
Description of the change
This branch fixes bug 1009712, which was caused by test_set_
The fix was simple: I added a function that allows us to uninstall an existing feature controller from the thread and then called that from within the test. I also updated the test's docstring, which was pretty uninformative.
To post a comment you must log in.
Aside from the "test_noise" noise, this looks good.