Merge lp:~gezakovacs/ubuntu/maverick/unetbootin/fix-10.10-desktop-iso-loading into lp:ubuntu/maverick/unetbootin

Proposed by Geza Kovacs
Status: Merged
Merge reported by: Luke Faraone
Merged at revision: not available
Proposed branch: lp:~gezakovacs/ubuntu/maverick/unetbootin/fix-10.10-desktop-iso-loading
Merge into: lp:ubuntu/maverick/unetbootin
Diff against target: 163 lines (+108/-5)
3 files modified
debian/changelog (+6/-0)
debian/control (+2/-1)
unetbootin.cpp (+100/-4)
To merge this branch: bzr merge lp:~gezakovacs/ubuntu/maverick/unetbootin/fix-10.10-desktop-iso-loading
Reviewer Review Type Date Requested Status
Luke Faraone Approve
Review via email: mp+36953@code.launchpad.net

Description of the change

Fixes issues when loading Ubuntu 10.10 desktop iso. Has been tested against ubuntu-10.10-beta-desktop-amd64.iso. Corresponds to upstream commit http://github.com/gkovacs/unetbootin/commit/feab255c7c67b9663092be2420fb69a1fc32d446#diff-1 (LP: #615285)

To post a comment you must log in.
Revision history for this message
Luke Faraone (lfaraone) :
review: Approve
Revision history for this message
Luke Faraone (lfaraone) wrote :

 * You don't need to use "ubuntu0.10.10.1", this isn't a SRU. "ubuntu1" will suffice.
 * Please run update-maintainer to comply with <https://wiki.ubuntu.com/DebianMaintainerField>

review: Needs Fixing
20. By Geza Kovacs

switch to ubuntu1 version suffix (not an SRU), and ran update-maintainer

Revision history for this message
Luke Faraone (lfaraone) wrote :

Merged, thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2010-06-13 21:30:22 +0000
+++ debian/changelog 2010-09-29 19:02:40 +0000
@@ -1,3 +1,9 @@
1unetbootin (471-1ubuntu1) maverick; urgency=low
2
3 * Fixes issues when loading Ubuntu 10.10 desktop iso. (LP: #615285)
4
5 -- Geza Kovacs <gkovacs@mit.edu> Wed, 29 Sep 2010 14:54:28 -0400
6
1unetbootin (471-1) unstable; urgency=low7unetbootin (471-1) unstable; urgency=low
28
3 * New upstream release.9 * New upstream release.
410
=== modified file 'debian/control'
--- debian/control 2010-04-15 20:13:52 +0000
+++ debian/control 2010-09-29 19:02:40 +0000
@@ -1,7 +1,8 @@
1Source: unetbootin1Source: unetbootin
2Section: utils2Section: utils
3Priority: optional3Priority: optional
4Maintainer: Eugene V. Lyubimkin <jackyf@debian.org>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: Eugene V. Lyubimkin <jackyf@debian.org>
5Build-Depends: syslinux, debhelper (>= 7), libqt4-dev (>= 4.2)6Build-Depends: syslinux, debhelper (>= 7), libqt4-dev (>= 4.2)
6Standards-Version: 3.8.47Standards-Version: 3.8.4
7Vcs-Git: git://git.debian.org/git/collab-maint/unetbootin.git8Vcs-Git: git://git.debian.org/git/collab-maint/unetbootin.git
89
=== modified file 'unetbootin.cpp'
--- unetbootin.cpp 2010-06-13 21:30:22 +0000
+++ unetbootin.cpp 2010-09-29 19:02:40 +0000
@@ -2151,7 +2151,31 @@
2151 {2151 {
2152 includesfile = includesfile.right(includesfile.size() - 1).trimmed();2152 includesfile = includesfile.right(includesfile.size() - 1).trimmed();
2153 }2153 }
2154 QStringList includesfileL = archivefileconts.filter(includesfile, Qt::CaseInsensitive);2154 QStringList includesfileL;
2155 for (int i = 0; i < archivefileconts.size(); ++i)
2156 {
2157 QString curentry = archivefileconts.at(i);
2158 if (curentry.endsWith("/") || curentry.endsWith(QDir::toNativeSeparators("/")))
2159 {
2160 curentry = curentry.left(curentry.size() - 1).trimmed();
2161 }
2162 if (curentry.contains("/"))
2163 {
2164 curentry = curentry.right(curentry.size() - 1 - curentry.indexOf("/"));
2165 }
2166 else if (curentry.contains(QDir::toNativeSeparators("/")))
2167 {
2168 curentry = curentry.right(curentry.size() - 1 - curentry.indexOf(QDir::toNativeSeparators("/")));
2169 }
2170 if (includesfile.compare(curentry, Qt::CaseInsensitive) == 0)
2171 {
2172 includesfileL.append(archivefileconts.at(i));
2173 }
2174 }
2175 if (includesfileL.isEmpty())
2176 {
2177 includesfileL = archivefileconts.filter(includesfile, Qt::CaseInsensitive);
2178 }
2155 if (!includesfileL.isEmpty())2179 if (!includesfileL.isEmpty())
2156 {2180 {
2157 for (int i = 0; i < includesfileL.size(); ++i)2181 for (int i = 0; i < includesfileL.size(); ++i)
@@ -2179,7 +2203,31 @@
2179 {2203 {
2180 includesfile = includesfile.right(includesfile.size() - 1).trimmed();2204 includesfile = includesfile.right(includesfile.size() - 1).trimmed();
2181 }2205 }
2182 QStringList includesfileL = archivefileconts.filter(includesfile, Qt::CaseInsensitive);2206 QStringList includesfileL;
2207 for (int i = 0; i < archivefileconts.size(); ++i)
2208 {
2209 QString curentry = archivefileconts.at(i);
2210 if (curentry.endsWith("/") || curentry.endsWith(QDir::toNativeSeparators("/")))
2211 {
2212 curentry = curentry.left(curentry.size() - 1).trimmed();
2213 }
2214 if (curentry.contains("/"))
2215 {
2216 curentry = curentry.right(curentry.size() - 1 - curentry.indexOf("/"));
2217 }
2218 else if (curentry.contains(QDir::toNativeSeparators("/")))
2219 {
2220 curentry = curentry.right(curentry.size() - 1 - curentry.indexOf(QDir::toNativeSeparators("/")));
2221 }
2222 if (includesfile.compare(curentry, Qt::CaseInsensitive) == 0)
2223 {
2224 includesfileL.append(archivefileconts.at(i));
2225 }
2226 }
2227 if (includesfileL.isEmpty())
2228 {
2229 includesfileL = archivefileconts.filter(includesfile, Qt::CaseInsensitive);
2230 }
2183 if (!includesfileL.isEmpty())2231 if (!includesfileL.isEmpty())
2184 {2232 {
2185 for (int i = 0; i < includesfileL.size(); ++i)2233 for (int i = 0; i < includesfileL.size(); ++i)
@@ -2207,7 +2255,31 @@
2207 {2255 {
2208 includesfile = includesfile.right(includesfile.size() - 1).trimmed();2256 includesfile = includesfile.right(includesfile.size() - 1).trimmed();
2209 }2257 }
2210 QStringList includesfileL = archivefileconts.filter(includesfile, Qt::CaseInsensitive);2258 QStringList includesfileL;
2259 for (int i = 0; i < archivefileconts.size(); ++i)
2260 {
2261 QString curentry = archivefileconts.at(i);
2262 if (curentry.endsWith("/") || curentry.endsWith(QDir::toNativeSeparators("/")))
2263 {
2264 curentry = curentry.left(curentry.size() - 1).trimmed();
2265 }
2266 if (curentry.contains("/"))
2267 {
2268 curentry = curentry.right(curentry.size() - 1 - curentry.indexOf("/"));
2269 }
2270 else if (curentry.contains(QDir::toNativeSeparators("/")))
2271 {
2272 curentry = curentry.right(curentry.size() - 1 - curentry.indexOf(QDir::toNativeSeparators("/")));
2273 }
2274 if (includesfile.compare(curentry, Qt::CaseInsensitive) == 0)
2275 {
2276 includesfileL.append(archivefileconts.at(i));
2277 }
2278 }
2279 if (includesfileL.isEmpty())
2280 {
2281 includesfileL = archivefileconts.filter(includesfile, Qt::CaseInsensitive);
2282 }
2211 if (!includesfileL.isEmpty())2283 if (!includesfileL.isEmpty())
2212 {2284 {
2213 for (int i = 0; i < includesfileL.size(); ++i)2285 for (int i = 0; i < includesfileL.size(); ++i)
@@ -2235,7 +2307,31 @@
2235 {2307 {
2236 includesfile = includesfile.right(includesfile.size() - 1).trimmed();2308 includesfile = includesfile.right(includesfile.size() - 1).trimmed();
2237 }2309 }
2238 QStringList includesfileL = archivefileconts.filter(includesfile, Qt::CaseInsensitive);2310 QStringList includesfileL;
2311 for (int i = 0; i < archivefileconts.size(); ++i)
2312 {
2313 QString curentry = archivefileconts.at(i);
2314 if (curentry.endsWith("/") || curentry.endsWith(QDir::toNativeSeparators("/")))
2315 {
2316 curentry = curentry.left(curentry.size() - 1).trimmed();
2317 }
2318 if (curentry.contains("/"))
2319 {
2320 curentry = curentry.right(curentry.size() - 1 - curentry.indexOf("/"));
2321 }
2322 else if (curentry.contains(QDir::toNativeSeparators("/")))
2323 {
2324 curentry = curentry.right(curentry.size() - 1 - curentry.indexOf(QDir::toNativeSeparators("/")));
2325 }
2326 if (includesfile.compare(curentry, Qt::CaseInsensitive) == 0)
2327 {
2328 includesfileL.append(archivefileconts.at(i));
2329 }
2330 }
2331 if (includesfileL.isEmpty())
2332 {
2333 includesfileL = archivefileconts.filter(includesfile, Qt::CaseInsensitive);
2334 }
2239 if (!includesfileL.isEmpty())2335 if (!includesfileL.isEmpty())
2240 {2336 {
2241 for (int i = 0; i < includesfileL.size(); ++i)2337 for (int i = 0; i < includesfileL.size(); ++i)

Subscribers

People subscribed via source and target branches

to all changes: