Merge lp:~gary-lasker/software-center/recommender-panel-visual-tweaks into lp:software-center
Proposed by
Gary Lasker
Status: | Merged |
---|---|
Merged at revision: | 3129 |
Proposed branch: | lp:~gary-lasker/software-center/recommender-panel-visual-tweaks |
Merge into: | lp:software-center |
Diff against target: |
99 lines (+38/-8) 3 files modified
softwarecenter/ui/gtk3/widgets/containers.py (+4/-2) softwarecenter/ui/gtk3/widgets/spinner.py (+16/-6) tests/gtk3/test_spinner.py (+18/-0) |
To merge this branch: | bzr merge lp:~gary-lasker/software-center/recommender-panel-visual-tweaks |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
software-store-developers | Pending | ||
Review via email: mp+121534@code.launchpad.net |
Commit message
* lp:~gary-lasker/software-center/recommender-panel-visual-tweaks:
- add support for two sizes of spinner to the spinner widget and use
the smaller one for the lobby/category screen panels
Description of the change
Just a small tweak in the recommender panel UI before UI freeze. Adds support in the spinner widget for choosing between two sizes of spinner, and switch to use the smaller version in the lobby/category screen recommender panels as it looks much better there. The large spinner is still used for the full views as before.
Thanks!
To post a comment you must log in.
Thanks for this branch. I like the size change, it does look nicer IMO with the smaller size.
The code is nice, I would have two suggestions: notebook_ size(self) : SpinnerNotebook (self.content, "msg", spinner. SpinnerView. LARGE)
self.assertEqu al(notebook. spinner_ view.spinner. get_size_ request( ), (48, 48))
- raise a ValueError is spinner_size is not in (Spinner.LARGE, SpinnerView.SMALL) as a user of the widget may pass "24" or "48" to it assuming size is in pixel
- add a small test as test_spinner.py has really good coverage already, should be as simple as:
def test_spinner_
notebook = spinner.
plus a test that the exception is raised.
If you want to go wild, you can do it in enums.py as:
class SpinnerSize:
LARGE = 48
SMALL = 24
this way if the size ever changes or we need MEDIUM its trivial to add in enums.py. But thats not really
needed, just a thought I had while looking at the diff.