Merge lp:~franku/widelands-website/css_changes into lp:widelands-website
Status: | Merged |
---|---|
Merged at revision: | 398 |
Proposed branch: | lp:~franku/widelands-website/css_changes |
Merge into: | lp:widelands-website |
Diff against target: |
350 lines (+46/-93) 9 files modified
README.txt (+12/-0) media/css/base.css (+17/-10) media/css/forum.css (+6/-6) media/css/help.css (+1/-1) media/css/navigation.css (+5/-6) media/css/poll.css (+0/-58) media/css/wiki.css (+5/-9) templates/wiki/view.html (+0/-2) templates/wlpoll/base.html (+0/-1) |
To merge this branch: | bzr merge lp:~franku/widelands-website/css_changes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
SirVer | Approve | ||
Review via email: mp+271388@code.launchpad.net |
Description of the change
This branch contains changes to font-size and line height and changes them from fixed to relative. This will pay attention to font related settings of a browser. See https:/
* changed fixed font-size to relative font sizes.
* changed fixed line-height to relative line-height
* add more space between two paragraphs
* Border of tables in forum gets better visibility (dark gray instead of black)
* top and bottom margins of headers are now the same in forum and wiki
* removed small code in template "/wiki/view.html" because a link to "Create this article?" is already shown
* removed poll.css because it's unused (the css-styles for displaying polls are all done in the javascript code)
* removed general shadowing of fonts, instead adding a new class "shaded" which could be used where it is needed
* small corrections of colors, where i feel it would look better (f.e.text shadow)
I tried to get as close to the current state while changing the values.
The stylesheets for the developers documentation is untouched, because i couldn't verify the results yet.
Some disadvantages of the font-size changes:
1.Text in codeblocks are mostly displayed smaller than with fixed font-size, depending on the browser a user uses. Thats because each browser has his own font-settings for codeblocks. In firefox they are much smaller than in chrome. If needed we could set a fixed font-size for codeblocks.
2.Bold formatted texts looks a little bit blurry. I noticed it f.e. on the "Latest Post" block on the right. That's because the translation of relative values into pixels results mostly in something like "14.234 pixel" which most displays couldn't display. See http://
Please ask for screenshots if you are unsure about some things.
I haven't found the time to try to resolve my local website deployment problems. Code LGTM though.
Maybe you could create a screenshot to post on the forums for people to give feedback?