Merge lp:~fo0bar/turku/turku-api-related-links into lp:turku/turku-api

[Ryan Finnie]

Fix admin child object related links

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[Joel Sing (jsing)]

LGTM, thanks.

review: Approve (+1)

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

Change successfully merged at revision 64

=== modified file 'turku_api/admin.py'
--- turku_api/admin.py	2020-03-24 23:07:22 +0000
+++ turku_api/admin.py	2020-04-11 22:36:45 +0000
@@ -58,12 +58,19 @@
     change_form_template = 'admin/custom_change_form.html'
 
     def render_change_form(self, request, context, *args, **kwargs):
+        # Build a list of related children objects and their counts
+        # so they may be linked to in the admin interface
         related_links = []
-        # Broken in Django 1.8+; see if related_links can be re-implemented
-        #if 'object_id' in context:
-        #    for obj in self.model._meta.get_all_related_objects():
-        #        count = obj.model.objects.filter(**{obj.field.name: context['object_id']}).count()
-        #        related_links.append((obj, count))
+        if 'object_id' in context and hasattr(self.model._meta, 'get_fields'):
+            related_objs = [
+                f for f in self.model._meta.get_fields()
+                if (f.one_to_many or f.one_to_one)
+                and f.auto_created and not f.concrete
+            ]
+            for obj in related_objs:
+                count = obj.related_model.objects.filter(**{obj.field.name: context['object_id']}).count()
+                if count > 0:
+                    related_links.append((obj, obj.related_model._meta, count))
         context.update({'related_links': related_links})
 
         return super(CustomModelAdmin, self).render_change_form(request, context, *args, **kwargs)
 
=== modified file 'turku_api/templates/admin/custom_change_form.html'
--- turku_api/templates/admin/custom_change_form.html	2015-03-16 02:34:28 +0000
+++ turku_api/templates/admin/custom_change_form.html	2020-04-11 22:36:45 +0000
@@ -3,9 +3,9 @@
 {% if related_links %}
 <h2>Related</h2>
 <ul>
-{% for link_obj, link_count in related_links %}
-  {% url 'admin:'|add:app_label|add:'_'|add:link_obj.opts.model_name|add:'_changelist' as link_url %}
-  <li><a href="{{ link_url }}?{{ link_obj.field.name }}={{ object_id }}">{{ link_obj.opts.verbose_name_plural|capfirst|escape }} ({{ link_count }})</a></li>
+{% for link_obj, link_opts, link_count in related_links %}
+  {% url 'admin:'|add:app_label|add:'_'|add:link_opts.model_name|add:'_changelist' as link_url %}
+  <li><a href="{{ link_url }}?{{ link_obj.field.name }}={{ object_id }}">{{ link_opts.verbose_name_plural|capfirst|escape }} ({{ link_count }})</a></li>
 {% endfor %}
 </ul>
 {% endif %}