Merge lp:~fginther/core-image-tester/edge-support into lp:core-image-tester

Proposed by Francis Ginther
Status: Rejected
Rejected by: Francis Ginther
Proposed branch: lp:~fginther/core-image-tester/edge-support
Merge into: lp:core-image-tester
Diff against target: 29 lines (+4/-1)
1 file modified
core_image_tester/worker.py (+4/-1)
To merge this branch: bzr merge lp:~fginther/core-image-tester/edge-support
Reviewer Review Type Date Requested Status
Celso Providelo (community) Needs Information
Review via email: mp+257166@code.launchpad.net

Commit message

Add support for 'release'.

Description of the change

Add support for 'release'.

To post a comment you must log in.
Revision history for this message
Celso Providelo (cprov) wrote :

Francis,

As discussed on IRC, if we hardcode configuration channel as "ubuntu-core/rolling/edge" in the deployer, this change wouldn't be necessary.

review: Needs Information
Revision history for this message
Francis Ginther (fginther) wrote :

Rejecting as a different solution was implemented that only required modifications to the publisher.

Unmerged revisions

32. By Francis Ginther

Add support for 'release'.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'core_image_tester/worker.py'
--- core_image_tester/worker.py 2015-04-17 16:02:30 +0000
+++ core_image_tester/worker.py 2015-04-22 19:42:01 +0000
@@ -56,6 +56,7 @@
56 nova_image_id = body['nova_image_id']56 nova_image_id = body['nova_image_id']
57 image_name = body['image_name']57 image_name = body['image_name']
58 device = body['device']58 device = body['device']
59 release = body['release']
59 channel = body['channel']60 channel = body['channel']
60 except KeyError as e:61 except KeyError as e:
61 logger.error("Message does not contain required ", extra=extra)62 logger.error("Message does not contain required ", extra=extra)
@@ -97,7 +98,8 @@
97 extra=extra98 extra=extra
98 )99 )
99100
100 container_name = "core-{}-{}-{}".format(101 container_name = "core-{}-{}-{}-{}".format(
102 release,
101 channel,103 channel,
102 device,104 device,
103 image_name,105 image_name,
@@ -146,6 +148,7 @@
146148
147 """149 """
148 key_whitelist = [150 key_whitelist = [
151 'release',
149 'channel',152 'channel',
150 'device',153 'device',
151 'test_branch',154 'test_branch',

Subscribers

People subscribed via source and target branches