Merge lp:~fboudra/linaro-image-tools/bug-1065826 into lp:linaro-image-tools/11.11

Proposed by Fathi Boudra
Status: Merged
Merged at revision: 575
Proposed branch: lp:~fboudra/linaro-image-tools/bug-1065826
Merge into: lp:linaro-image-tools/11.11
Diff against target: 36 lines (+14/-3)
1 file modified
linaro_image_tools/hwpack/builder.py (+14/-3)
To merge this branch: bzr merge lp:~fboudra/linaro-image-tools/bug-1065826
Reviewer Review Type Date Requested Status
linaro-image-tools maintainers Pending
Review via email: mp+129410@code.launchpad.net

Description of the change

Skip symlink-ed or invalid debian package file. (LP: #1065826)

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'linaro_image_tools/hwpack/builder.py'
--- linaro_image_tools/hwpack/builder.py 2012-10-11 09:24:36 +0000
+++ linaro_image_tools/hwpack/builder.py 2012-10-12 12:46:18 +0000
@@ -28,6 +28,7 @@
28from glob import iglob28from glob import iglob
2929
30from debian.debfile import DebFile30from debian.debfile import DebFile
31from debian.arfile import ArError
3132
32from linaro_image_tools import cmd_runner33from linaro_image_tools import cmd_runner
3334
@@ -337,11 +338,21 @@
337 'build-info')338 'build-info')
338 build_info_available = 0339 build_info_available = 0
339 for deb_pkg in self.packages:340 for deb_pkg in self.packages:
340 # Extract Build-Info attribute from debian control
341 deb_pkg_file_path = deb_pkg.filepath341 deb_pkg_file_path = deb_pkg.filepath
342 deb_control = \342 if os.path.islink(deb_pkg_file_path):
343 # Skip symlink-ed debian package file
344 # e.g. fetched package with dummy information
345 continue
346 try:
347 # Extract Build-Info attribute from debian
348 # control
349 deb_control = \
343 DebFile(deb_pkg_file_path).control.debcontrol()350 DebFile(deb_pkg_file_path).control.debcontrol()
344 build_info = deb_control.get('Build-Info')351 build_info = deb_control.get('Build-Info')
352 except ArError:
353 # Skip invalid debian package file
354 # e.g. fetched package with dummy information
355 continue
345 if build_info is not None:356 if build_info is not None:
346 build_info_available += 1357 build_info_available += 1
347 # Extract debian packages with build358 # Extract debian packages with build

Subscribers

People subscribed via source and target branches