Merge lp:~evgeni/libdbusmenu/optional-valgrind into lp:libdbusmenu/12.10

Proposed by Evgeni Golov
Status: Merged
Approved by: Charles Kerr
Approved revision: 420
Merged at revision: 420
Proposed branch: lp:~evgeni/libdbusmenu/optional-valgrind
Merge into: lp:libdbusmenu/12.10
Diff against target: 43 lines (+6/-1)
2 files modified
configure.ac (+2/-1)
tests/Makefile.am (+4/-0)
To merge this branch: bzr merge lp:~evgeni/libdbusmenu/optional-valgrind
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
Review via email: mp+109781@code.launchpad.net

Description of the change

make pkg-config check not fail if valgrind was not found

this allows to build and run non-valgrind checks on arches where valgrind
is not available

To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) wrote :

Evgeni, thanks for reporting this issue and suggesting this patch!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'configure.ac'
--- configure.ac 2012-04-11 16:42:40 +0000
+++ configure.ac 2012-06-12 06:58:20 +0000
@@ -121,7 +121,8 @@
121 gio-unix-2.0 >= $GIO_UNIX_REQUIRED_VERSION,121 gio-unix-2.0 >= $GIO_UNIX_REQUIRED_VERSION,
122 [have_tests=yes]122 [have_tests=yes]
123)123)
124PKG_CHECK_MODULES(DBUSMENUTESTSVALGRIND, valgrind)124PKG_CHECK_MODULES(DBUSMENUTESTSVALGRIND, valgrind, have_valgrind=yes, have_valgrind=no)
125AM_CONDITIONAL([HAVE_VALGRIND], [test "x$have_valgrind" = "xyes"])
125])126])
126127
127AC_SUBST(DBUSMENUTESTS_CFLAGS)128AC_SUBST(DBUSMENUTESTS_CFLAGS)
128129
=== modified file 'tests/Makefile.am'
--- tests/Makefile.am 2012-04-04 19:16:32 +0000
+++ tests/Makefile.am 2012-06-12 06:58:20 +0000
@@ -16,10 +16,12 @@
16 test-glib-submenu16 test-glib-submenu
1717
18if WANT_DBUSMENUDUMPER18if WANT_DBUSMENUDUMPER
19if HAVE_VALGRIND
19TESTS += \20TESTS += \
20 test-json \21 test-json \
21 test-json-instruction22 test-json-instruction
22endif23endif
24endif
2325
24if WANT_LIBDBUSMENUGTK26if WANT_LIBDBUSMENUGTK
25TESTS += \27TESTS += \
@@ -59,10 +61,12 @@
59 test-glib-simple-items61 test-glib-simple-items
6062
61if WANT_DBUSMENUDUMPER63if WANT_DBUSMENUDUMPER
64if HAVE_VALGRIND
62check_PROGRAMS += \65check_PROGRAMS += \
63 test-json-client \66 test-json-client \
64 test-json-server67 test-json-server
65endif68endif
69endif
6670
67if WANT_LIBDBUSMENUGTK71if WANT_LIBDBUSMENUGTK
68check_PROGRAMS += \72check_PROGRAMS += \

Subscribers

People subscribed via source and target branches

to all changes: