Merge lp:~ev/apport/1205608 into lp:~apport-hackers/apport/trunk
Proposed by
Evan
Status: | Rejected |
---|---|
Rejected by: | Martin Pitt |
Proposed branch: | lp:~ev/apport/1205608 |
Merge into: | lp:~apport-hackers/apport/trunk |
Diff against target: |
26 lines (+3/-2) 2 files modified
NEWS (+1/-0) bin/apport-retrace (+2/-2) |
To merge this branch: | bzr merge lp:~ev/apport/1205608 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Pitt (community) | Disapprove | ||
Review via email: mp+177419@code.launchpad.net |
Description of the change
Fixes a crash when you specify a sandbox but not a cache.
To post a comment you must log in.
Just a quick review, I'm on my way out.
We create a temporary cache if the user doesn't specify one, so we should rather fix the logic to use that then. It shouldn't be mandatory to use a permanent cache; in fact it's quite redundant with doing stuff on /tmp/ on a tmpfs and having apt-cacher-ng (I have that).