Merge lp:~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937 into lp:~openerp-community/server-env-tools/6.1-mass_editing

Proposed by Mariano Ruiz
Status: Merged
Merged at revision: 42
Proposed branch: lp:~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937
Merge into: lp:~openerp-community/server-env-tools/6.1-mass_editing
Diff against target: 12 lines (+1/-1)
1 file modified
mass_editing/mass_editing.py (+1/-1)
To merge this branch: bzr merge lp:~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) Needs Information
Guewen Baconnier @ Camptocamp Needs Information
Stefan Rijnhart (Opener) Approve
Review via email: mp+167643@code.launchpad.net

Description of the change

This branch fix the error #1187937.

To post a comment you must log in.
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Thanks for the fix! You might want to use model_ids.append(found_model_ids[0]) though.

review: Needs Fixing
42. By Mariano Ruiz

[FIX] Better operation syntax

Revision history for this message
Mariano Ruiz (marianoruiz) wrote :

Done! Rev 42.

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

You're quick! Thanks for the change.

review: Approve
Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM

review: Approve (code review, no test)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :
review: Needs Information
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

I ask myself the same thing

review: Needs Information
Revision history for this message
debaetsr (rubendebaets) wrote :

Hi friend!

Look at that! Wooow! It's so amazing and interesting, and even sometimes shocking! Just take a look here <http://suit.kitefamily.us/e4ccrzv>

Thanks for your consideration, ruben

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'mass_editing/mass_editing.py'
--- mass_editing/mass_editing.py 2013-05-07 18:28:03 +0000
+++ mass_editing/mass_editing.py 2013-06-05 21:51:27 +0000
@@ -50,7 +50,7 @@
50 for key, val in active_model_obj._inherits.items():50 for key, val in active_model_obj._inherits.items():
51 found_model_ids = model_obj.search(cr, uid, [('model', '=', key)])51 found_model_ids = model_obj.search(cr, uid, [('model', '=', key)])
52 if found_model_ids:52 if found_model_ids:
53 model_ids += found_model_ids[0]53 model_ids.append(found_model_ids[0])
54 return {'value': {'model_ids': [(6, 0, model_ids)]}}54 return {'value': {'model_ids': [(6, 0, model_ids)]}}
5555
56 def create_action(self, cr, uid, ids, context=None):56 def create_action(self, cr, uid, ids, context=None):

Subscribers

People subscribed via source and target branches