Merge lp:~dreis-pt/project-service/7.0-fixcounters into lp:~project-core-editors/project-service/trunk

[Daniel Reis]

In v7, Project kanban can take forever to load, due to inefficient implementation of the counters (Issues, Tasks and Documents).
AFAIK it has been fixed in v8, so this is mostly a backport for that work.

[lp:~dreis-pt/project-service/7.0-fixcounters]

41. By Daniel Reis on 2014-05-14

New project_issue_fixcounter module

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Daniel, don't you think this fits best on OCB?

Regards.

review: Needs Information

[Daniel Reis (dreis-pt)]

I did hesitate on that. Let's ask for Stephan's opinion on it.

[Pedro Manuel Baeza (pedro.baeza)]

I suppose that he said that changes are too deep for OCB, and maybe he's right, but I don't think v7 is going to receive too much changes on this part to produce conflicts.

Let's see what he says.

Regards.

[Daniel Reis (dreis-pt)]

This project is now hosted on https://github.com/OCA/project-service. Please move your proposal there.
This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

Unmerged revisions

41. By Daniel Reis on 2014-05-14

New project_issue_fixcounter module

=== modified file '.bzrignore'
--- .bzrignore	2012-06-27 14:33:04 +0000
+++ .bzrignore	2014-05-14 16:19:44 +0000
@@ -1,1 +1,2 @@
 *.pyc
+project_issue_fixcount/.ropeproject
 
=== added directory 'project_issue_fixcount'
=== added file 'project_issue_fixcount/__init__.py'
--- project_issue_fixcount/__init__.py	1970-01-01 00:00:00 +0000
+++ project_issue_fixcount/__init__.py	2014-05-14 16:19:44 +0000
@@ -0,0 +1,2 @@
+# -*- coding: utf-8 -*-
+import project
 
=== added file 'project_issue_fixcount/__openerp__.py'
--- project_issue_fixcount/__openerp__.py	1970-01-01 00:00:00 +0000
+++ project_issue_fixcount/__openerp__.py	2014-05-14 16:19:44 +0000
@@ -0,0 +1,35 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Copyright (C) 2014 Daniel Reis
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+{
+    'name': 'Backport more efficient Project counters',
+    'version': '1.0',
+    "category": "Project Management",
+    'description': """\
+Fix performance issues with v7 Project counters.
+Will probably be unnecessary in v8.
+""",
+    'author': 'Daniel Reis',
+    'website': '',
+    'depends': [
+        'project_issue',
+    ],
+    'data': [],
+    'installable': True,
+}
 
=== added file 'project_issue_fixcount/project.py'
--- project_issue_fixcount/project.py	1970-01-01 00:00:00 +0000
+++ project_issue_fixcount/project.py	2014-05-14 16:19:44 +0000
@@ -0,0 +1,69 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Copyright (C) 2014 Daniel Reis
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.osv import fields, orm
+
+
+class Project(orm.Model):
+    _inherit = 'project.project'
+
+    def _task_count(self, cr, uid, ids, field_name, arg, context=None):
+        "Backport from v8"
+        res = {}
+        for tasks in self.browse(cr, uid, ids, context):
+            res[tasks.id] = len(tasks.task_ids)
+        return res
+
+    def _issue_count(self, cr, uid, ids, field_name, arg, context=None):
+        "Backport from v8"
+        Issue = self.pool['project.issue']
+        return {
+            project_id: Issue.search_count(
+                cr, uid,
+                [('project_id', '=', project_id),
+                 ('stage_id.fold', '=', False)],
+                context=context)
+            for project_id in ids
+        }
+
+    def _get_attached_docs(self, cr, uid, ids, field_name, arg, context):
+        "We don't count documents to improve performance"
+        res = {}
+        # attachment = self.pool.get('ir.attachment')
+        # task = self.pool.get('project.task')
+        for id in ids:
+            # project_attachments = attachment.search(cr, uid, [('res_model', '=', 'project.project'), ('res_id', '=', id)], context=context, count=True)
+            # task_ids = task.search(cr, uid, [('project_id', '=', id)], context=context)
+            # task_attachments = attachment.search(cr, uid, [('res_model', '=', 'project.task'), ('res_id', 'in', task_ids)], context=context, count=True)
+            res[id] = 0  # (project_attachments or 0) + (task_attachments or 0)
+        return res
+
+    _columns = {
+        'task_count': fields.function(
+            _task_count, type='integer', string="Tasks",),
+        'task_ids': fields.one2many(
+            'project.task', 'project_id',
+            domain=[('stage_id.fold', '=', False)]),
+        'issue_count': fields.function(
+            _issue_count, string='# Issues', type='integer'),
+        'doc_count': fields.function(
+            _get_attached_docs,
+            string="Number of documents attached", type='integer'),
+    }