Merge lp:~dominique-ramaekers/command-not-found/thinerBug into lp:~command-not-found-developers/command-not-found/trunk

[Dominique Ramaekers]

Fixes Bug #1643167: command-not-found crash on inreasonably long input

[Michael Vogt (mvo)]

Looks good, thank you!

review: Approve

[Michael Vogt (mvo)]

This is now part of http://bazaar.launchpad.net/~ubuntu-core-dev/command-not-found/ubuntu/revision/199 - this is the best branch to target for the command-not-found work, the lp:command-not-found is pointing to something that is not quite ready (trunk). I will upload it soon.

[Dominique Ramaekers (dominique-ramaekers)]

Thank you to. I won't bug you so much anymore. I'm glad I now can
contribute after years of using OSS. And on a tool that helped me a lot and
still is of good use for me.

Greetings,

Dominique.

Op dinsdag 13 december 2016 07:53:21 CET schreef Michael Vogt
<email address hidden>:
> Review: Approve
>
> Looks good, thank you!

--
Verzonden via Dekko vanaf mijn Ubuntu-apparaat

=== modified file 'CommandNotFound/CommandNotFound.py'
--- CommandNotFound/CommandNotFound.py	2016-10-09 19:49:45 +0000
+++ CommandNotFound/CommandNotFound.py	2016-11-29 18:56:23 +0000
@@ -135,16 +135,16 @@
         except KeyError:
             self.user_can_sudo = False
 
-    def print_spelling_suggestion(self, word, min_len=3, max_len=15):
+    def print_spelling_suggestion(self, word, min_len=3, max_len=256, max_alt=15):
         " try to correct the spelling "
-        if len(word) < min_len:
+        if not (min_len <= len(word) <= max_len):
             return
         possible_alternatives = []
         for w in similar_words(word):
             packages = self.getPackages(w)
             for (package, comp) in packages:
                 possible_alternatives.append((w, package, comp))
-        if len(possible_alternatives) > max_len:
+        if len(possible_alternatives) > max_alt:
             print(_("No command '%s' found, but there are %s similar ones") % (word, len(possible_alternatives)), file=sys.stderr)
         elif len(possible_alternatives) > 0:
             print(_("No command '%s' found, did you mean:") % word, file=sys.stderr)