Merge lp:~dobey/ubuntu/natty/libubuntuone/release-0-9-0 into lp:ubuntu/natty/libubuntuone

Proposed by dobey
Status: Merged
Merged at revision: 83
Proposed branch: lp:~dobey/ubuntu/natty/libubuntuone/release-0-9-0
Merge into: lp:ubuntu/natty/libubuntuone
Diff against target: 232 lines (+34/-33)
6 files modified
config.h.in (+0/-3)
configure (+10/-13)
configure.ac (+1/-2)
debian/changelog (+7/-0)
libubuntuone/u1-music-store.c (+14/-13)
ltmain.sh (+2/-2)
To merge this branch: bzr merge lp:~dobey/ubuntu/natty/libubuntuone/release-0-9-0
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Approve
Ubuntu branches Pending
Review via email: mp+52789@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

Good work.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'config.h.in'
--- config.h.in 2010-02-16 20:56:56 +0000
+++ config.h.in 2011-03-10 01:23:54 +0000
@@ -1,8 +1,5 @@
1/* config.h.in. Generated from configure.ac by autoheader. */1/* config.h.in. Generated from configure.ac by autoheader. */
22
3/* Define to enable OAuth debugging */
4#undef DEBUG_OAUTH
5
6/* always defined to indicate that i18n is enabled */3/* always defined to indicate that i18n is enabled */
7#undef ENABLE_NLS4#undef ENABLE_NLS
85
96
=== modified file 'configure'
--- configure 2011-02-16 17:25:49 +0000
+++ configure 2011-03-10 01:23:54 +0000
@@ -1,6 +1,6 @@
1#! /bin/sh1#! /bin/sh
2# Guess values for system-dependent variables and create Makefiles.2# Guess values for system-dependent variables and create Makefiles.
3# Generated by GNU Autoconf 2.67 for libubuntuone 0.3.11.3# Generated by GNU Autoconf 2.67 for libubuntuone 0.9.0.
4#4#
5#5#
6# Copyright (C) 1992, 1993, 1994, 1995, 1996, 1998, 1999, 2000, 2001,6# Copyright (C) 1992, 1993, 1994, 1995, 1996, 1998, 1999, 2000, 2001,
@@ -698,8 +698,8 @@
698# Identity of this package.698# Identity of this package.
699PACKAGE_NAME='libubuntuone'699PACKAGE_NAME='libubuntuone'
700PACKAGE_TARNAME='libubuntuone'700PACKAGE_TARNAME='libubuntuone'
701PACKAGE_VERSION='0.3.11'701PACKAGE_VERSION='0.9.0'
702PACKAGE_STRING='libubuntuone 0.3.11'702PACKAGE_STRING='libubuntuone 0.9.0'
703PACKAGE_BUGREPORT=''703PACKAGE_BUGREPORT=''
704PACKAGE_URL=''704PACKAGE_URL=''
705705
@@ -1535,7 +1535,7 @@
1535 # Omit some internal or obsolete options to make the list less imposing.1535 # Omit some internal or obsolete options to make the list less imposing.
1536 # This message is too long to be a string in the A/UX 3.1 sh.1536 # This message is too long to be a string in the A/UX 3.1 sh.
1537 cat <<_ACEOF1537 cat <<_ACEOF
1538\`configure' configures libubuntuone 0.3.11 to adapt to many kinds of systems.1538\`configure' configures libubuntuone 0.9.0 to adapt to many kinds of systems.
15391539
1540Usage: $0 [OPTION]... [VAR=VALUE]...1540Usage: $0 [OPTION]... [VAR=VALUE]...
15411541
@@ -1605,7 +1605,7 @@
16051605
1606if test -n "$ac_init_help"; then1606if test -n "$ac_init_help"; then
1607 case $ac_init_help in1607 case $ac_init_help in
1608 short | recursive ) echo "Configuration of libubuntuone 0.3.11:";;1608 short | recursive ) echo "Configuration of libubuntuone 0.9.0:";;
1609 esac1609 esac
1610 cat <<\_ACEOF1610 cat <<\_ACEOF
16111611
@@ -1730,7 +1730,7 @@
1730test -n "$ac_init_help" && exit $ac_status1730test -n "$ac_init_help" && exit $ac_status
1731if $ac_init_version; then1731if $ac_init_version; then
1732 cat <<\_ACEOF1732 cat <<\_ACEOF
1733libubuntuone configure 0.3.111733libubuntuone configure 0.9.0
1734generated by GNU Autoconf 2.671734generated by GNU Autoconf 2.67
17351735
1736Copyright (C) 2010 Free Software Foundation, Inc.1736Copyright (C) 2010 Free Software Foundation, Inc.
@@ -2095,7 +2095,7 @@
2095This file contains any messages produced by compilers while2095This file contains any messages produced by compilers while
2096running configure, to aid debugging if configure makes a mistake.2096running configure, to aid debugging if configure makes a mistake.
20972097
2098It was created by libubuntuone $as_me 0.3.11, which was2098It was created by libubuntuone $as_me 0.9.0, which was
2099generated by GNU Autoconf 2.67. Invocation command line was2099generated by GNU Autoconf 2.67. Invocation command line was
21002100
2101 $ $0 $@2101 $ $0 $@
@@ -2918,7 +2918,7 @@
29182918
2919# Define the identity of the package.2919# Define the identity of the package.
2920 PACKAGE='libubuntuone'2920 PACKAGE='libubuntuone'
2921 VERSION='0.3.11'2921 VERSION='0.9.0'
29222922
29232923
2924cat >>confdefs.h <<_ACEOF2924cat >>confdefs.h <<_ACEOF
@@ -12926,9 +12926,6 @@
1292612926
12927$as_echo "#define HAVE_OAUTH 1" >>confdefs.h12927$as_echo "#define HAVE_OAUTH 1" >>confdefs.h
1292812928
12929
12930$as_echo "#define DEBUG_OAUTH 1" >>confdefs.h
12931
12932 have_oauth="yes"12929 have_oauth="yes"
12933 OAUTH_LIBS="-lm -lcrypto"12930 OAUTH_LIBS="-lm -lcrypto"
1293412931
@@ -14641,7 +14638,7 @@
14641# report actual input values of CONFIG_FILES etc. instead of their14638# report actual input values of CONFIG_FILES etc. instead of their
14642# values after options handling.14639# values after options handling.
14643ac_log="14640ac_log="
14644This file was extended by libubuntuone $as_me 0.3.11, which was14641This file was extended by libubuntuone $as_me 0.9.0, which was
14645generated by GNU Autoconf 2.67. Invocation command line was14642generated by GNU Autoconf 2.67. Invocation command line was
1464614643
14647 CONFIG_FILES = $CONFIG_FILES14644 CONFIG_FILES = $CONFIG_FILES
@@ -14707,7 +14704,7 @@
14707cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=114704cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
14708ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"14705ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"
14709ac_cs_version="\\14706ac_cs_version="\\
14710libubuntuone config.status 0.3.1114707libubuntuone config.status 0.9.0
14711configured by $0, generated by GNU Autoconf 2.67,14708configured by $0, generated by GNU Autoconf 2.67,
14712 with options \\"\$ac_cs_config\\"14709 with options \\"\$ac_cs_config\\"
1471314710
1471414711
=== modified file 'configure.ac'
--- configure.ac 2011-02-16 17:24:08 +0000
+++ configure.ac 2011-03-10 01:23:54 +0000
@@ -1,4 +1,4 @@
1AC_INIT([libubuntuone], [0.3.11], [], [libubuntuone])1AC_INIT([libubuntuone], [0.9.0], [], [libubuntuone])
22
3AC_PREREQ([2.59])3AC_PREREQ([2.59])
44
@@ -68,7 +68,6 @@
68AC_CHECK_LIB(crypto, CRYPTO_free, have_oauth_libs="yes", have_oauth_libs="no")68AC_CHECK_LIB(crypto, CRYPTO_free, have_oauth_libs="yes", have_oauth_libs="no")
69if test "x$have_oauth_headers" = "xyes" -a "x$have_oauth_libs" = "xyes"; then69if test "x$have_oauth_headers" = "xyes" -a "x$have_oauth_libs" = "xyes"; then
70 AC_DEFINE(HAVE_OAUTH, 1, [Define to build OAUTH signing code])70 AC_DEFINE(HAVE_OAUTH, 1, [Define to build OAUTH signing code])
71 AC_DEFINE(DEBUG_OAUTH, 1, [Define to enable OAuth debugging])
72 have_oauth="yes"71 have_oauth="yes"
73 OAUTH_LIBS="-lm -lcrypto"72 OAUTH_LIBS="-lm -lcrypto"
74 AC_SUBST(OAUTH_LIBS)73 AC_SUBST(OAUTH_LIBS)
7574
=== modified file 'data/img/logo.png'
76Binary files data/img/logo.png 2010-04-01 17:42:58 +0000 and data/img/logo.png 2011-03-10 01:23:54 +0000 differ75Binary files data/img/logo.png 2010-04-01 17:42:58 +0000 and data/img/logo.png 2011-03-10 01:23:54 +0000 differ
=== modified file 'debian/changelog'
--- debian/changelog 2011-02-16 17:25:49 +0000
+++ debian/changelog 2011-03-10 01:23:54 +0000
@@ -1,3 +1,10 @@
1libubuntuone (0.9.0-0ubuntu1) natty; urgency=low
2
3 * New upstream release.
4 - Don't log oauth information to console (LP: #723297)
5
6 -- Rodney Dawes <rodney.dawes@ubuntu.com> Wed, 09 Mar 2011 20:13:12 -0500
7
1libubuntuone (0.3.11-0ubuntu1) natty; urgency=low8libubuntuone (0.3.11-0ubuntu1) natty; urgency=low
29
3 * New upstream release.10 * New upstream release.
411
=== modified file 'libubuntuone/u1-music-store.c'
--- libubuntuone/u1-music-store.c 2011-01-14 22:24:48 +0000
+++ libubuntuone/u1-music-store.c 2011-03-10 01:23:54 +0000
@@ -256,19 +256,9 @@
256get_url_to_use (U1MusicStore *music_store)256get_url_to_use (U1MusicStore *music_store)
257{257{
258 gchar *oauth_consumer_token, *oauth_consumer_secret, *oauth_token = NULL, *oauth_token_secret = NULL, *real_url;258 gchar *oauth_consumer_token, *oauth_consumer_secret, *oauth_token = NULL, *oauth_token_secret = NULL, *real_url;
259 const gchar *url_to_use;
260
261 /* If U1MUSICSTOREURL is defined, use that instead of the real URL */
262 if (! (url_to_use = g_getenv ("U1MUSICSTOREURL")))
263 url_to_use = "https://one.ubuntu.com";
264
265 if (music_store->priv->base_url != NULL)
266 g_free (music_store->priv->base_url);
267
268 music_store->priv->base_url = g_strdup (url_to_use);
269259
270 /* OAUth sign the URL */260 /* OAUth sign the URL */
271 if (g_str_has_prefix (url_to_use, "http://localhost") || g_str_has_prefix (url_to_use, "http://127.0.0.1")) {261 if (g_str_has_prefix (music_store->priv->base_url, "http://localhost") || g_str_has_prefix (music_store->priv->base_url, "http://127.0.0.1")) {
272 const gchar *oauthfile;262 const gchar *oauthfile;
273263
274 oauthfile = g_getenv ("OAUTHKEYFILE");264 oauthfile = g_getenv ("OAUTHKEYFILE");
@@ -519,8 +509,6 @@
519 SoupURI *parsed_uri;509 SoupURI *parsed_uri;
520 gchar *internal_uri;510 gchar *internal_uri;
521511
522 g_debug ("navigation requested to %s", webkit_network_request_get_uri (request));
523
524 /* Remove watching callback for the page */512 /* Remove watching callback for the page */
525 if (music_store->priv->watch_id != 0) {513 if (music_store->priv->watch_id != 0) {
526 g_source_remove (music_store->priv->watch_id);514 g_source_remove (music_store->priv->watch_id);
@@ -959,6 +947,7 @@
959u1_music_store_init (U1MusicStore *music_store)947u1_music_store_init (U1MusicStore *music_store)
960{948{
961 gchar *new_user_agent;949 gchar *new_user_agent;
950 const gchar *url_to_use;
962 GError *error = NULL;951 GError *error = NULL;
963952
964 if (!g_thread_get_initialized ())953 if (!g_thread_get_initialized ())
@@ -968,6 +957,12 @@
968 music_store->priv->watched_downloads = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, g_free);957 music_store->priv->watched_downloads = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, g_free);
969 music_store->priv->syncdaemon = syncdaemon_daemon_new ();958 music_store->priv->syncdaemon = syncdaemon_daemon_new ();
970959
960 /* If U1MUSICSTOREURL is defined, use that instead of the real URL */
961 if (! (url_to_use = g_getenv ("U1MUSICSTOREURL")))
962 url_to_use = "https://one.ubuntu.com";
963
964 music_store->priv->base_url = g_strdup (url_to_use);
965
971 /* Initialize DBus */966 /* Initialize DBus */
972 music_store->priv->bus = dbus_g_bus_get (DBUS_BUS_SESSION, &error);967 music_store->priv->bus = dbus_g_bus_get (DBUS_BUS_SESSION, &error);
973 if (error) {968 if (error) {
@@ -1098,6 +1093,12 @@
1098 g_return_if_fail (U1_IS_MUSIC_STORE (music_store));1093 g_return_if_fail (U1_IS_MUSIC_STORE (music_store));
1099 g_return_if_fail (url != NULL);1094 g_return_if_fail (url != NULL);
11001095
1096 /* If the load_real_store callback is set up, disable it first */
1097 if (music_store->priv->idle_cb > 0) {
1098 g_source_remove (music_store->priv->idle_cb);
1099 music_store->priv->idle_cb = 0;
1100 }
1101
1101 real_url = g_strdup_printf ("%s%s?forward_on_to_url=%s",1102 real_url = g_strdup_printf ("%s%s?forward_on_to_url=%s",
1102 music_store->priv->base_url,1103 music_store->priv->base_url,
1103 U1_STORE_URL,1104 U1_STORE_URL,
11041105
=== modified file 'ltmain.sh'
--- ltmain.sh 2010-03-08 16:07:58 +0000
+++ ltmain.sh 2011-03-10 01:23:54 +0000
@@ -65,7 +65,7 @@
65# compiler: $LTCC65# compiler: $LTCC
66# compiler flags: $LTCFLAGS66# compiler flags: $LTCFLAGS
67# linker: $LD (gnu? $with_gnu_ld)67# linker: $LD (gnu? $with_gnu_ld)
68# $progname: (GNU libtool) 2.2.6b Debian-2.2.6b-2ubuntu168# $progname: (GNU libtool) 2.2.6b Debian-2.2.6b-2ubuntu3
69# automake: $automake_version69# automake: $automake_version
70# autoconf: $autoconf_version70# autoconf: $autoconf_version
71#71#
@@ -73,7 +73,7 @@
7373
74PROGRAM=ltmain.sh74PROGRAM=ltmain.sh
75PACKAGE=libtool75PACKAGE=libtool
76VERSION="2.2.6b Debian-2.2.6b-2ubuntu1"76VERSION="2.2.6b Debian-2.2.6b-2ubuntu3"
77TIMESTAMP=""77TIMESTAMP=""
78package_revision=1.301778package_revision=1.3017
7979

Subscribers

People subscribed via source and target branches

to all changes: