Merge lp:~dobey/software-center/fix-typeerror into lp:software-center

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 3319
Merged at revision: 3319
Proposed branch: lp:~dobey/software-center/fix-typeerror
Merge into: lp:software-center
Diff against target: 13 lines (+2/-1)
1 file modified
softwarecenter/ui/gtk3/panes/availablepane.py (+2/-1)
To merge this branch: bzr merge lp:~dobey/software-center/fix-typeerror
Reviewer Review Type Date Requested Status
Mike McCracken (community) Approve
Review via email: mp+195611@code.launchpad.net

Commit message

Only add the launcher when the desktop file is not None.

To post a comment you must log in.
Revision history for this message
Mike McCracken (mikemc) wrote :

looks fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'softwarecenter/ui/gtk3/panes/availablepane.py'
--- softwarecenter/ui/gtk3/panes/availablepane.py 2013-09-10 16:26:42 +0000
+++ softwarecenter/ui/gtk3/panes/availablepane.py 2013-11-18 14:00:46 +0000
@@ -437,7 +437,8 @@
437 trans_id != PURCHASE_TRANSACTION_ID and437 trans_id != PURCHASE_TRANSACTION_ID and
438 config.add_to_unity_launcher and438 config.add_to_unity_launcher and
439 softwarecenter.utils.is_unity_running()):439 softwarecenter.utils.is_unity_running()):
440 self._add_application_to_unity_launcher(details)440 if details.desktop_file is not None:
441 self._add_application_to_unity_launcher(details)
441442
442 def on_transaction_cancelled(self, backend, result):443 def on_transaction_cancelled(self, backend, result):
443 """ handle a transaction that has been cancelled444 """ handle a transaction that has been cancelled

Subscribers

People subscribed via source and target branches