Merge lp:~developersw/ubuntu-terminal-app/CarloSpenguinFix into lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

Proposed by Carlo Giordano
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 70
Merged at revision: 75
Proposed branch: lp:~developersw/ubuntu-terminal-app/CarloSpenguinFix
Merge into: lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 72 lines (+13/-4)
3 files modified
po/com.ubuntu.terminal.pot (+2/-2)
src/app/main.cpp (+10/-1)
src/app/qml/TerminalComponent.qml (+1/-1)
To merge this branch: bzr merge lp:~developersw/ubuntu-terminal-app/CarloSpenguinFix
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Filippo Scognamiglio Approve
Review via email: mp+253864@code.launchpad.net

Commit message

Home-Dynamic-Folder

Description of the change

Folder-Dynamic-Home

To post a comment you must log in.
Revision history for this message
Filippo Scognamiglio (flscogna) wrote :

Thank you Carlo!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~developersw/ubuntu-terminal-app/CarloSpenguinFix/+merge/253864/+edit-commit-message

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'po/com.ubuntu.terminal.pot'
--- po/com.ubuntu.terminal.pot 2015-02-26 10:57:55 +0000
+++ po/com.ubuntu.terminal.pot 2015-03-23 17:48:21 +0000
@@ -8,7 +8,7 @@
8msgstr ""8msgstr ""
9"Project-Id-Version: \n"9"Project-Id-Version: \n"
10"Report-Msgid-Bugs-To: \n"10"Report-Msgid-Bugs-To: \n"
11"POT-Creation-Date: 2015-02-20 14:00+0100\n"11"POT-Creation-Date: 2015-03-21 13:11+0100\n"
12"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"12"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
13"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"13"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
14"Language-Team: LANGUAGE <LL@li.org>\n"14"Language-Team: LANGUAGE <LL@li.org>\n"
@@ -81,7 +81,7 @@
81msgid "New tab"81msgid "New tab"
82msgstr ""82msgstr ""
8383
84#: ../src/app/qml/TerminalPage.qml:11184#: ../src/app/qml/TerminalPage.qml:164
85msgid "Selection Mode"85msgid "Selection Mode"
86msgstr ""86msgstr ""
8787
8888
=== modified file 'src/app/main.cpp'
--- src/app/main.cpp 2015-02-14 10:33:32 +0000
+++ src/app/main.cpp 2015-03-23 17:48:21 +0000
@@ -31,6 +31,11 @@
3131
32#include <QDebug>32#include <QDebug>
3333
34QString getNamedArgument(QStringList args, QString name, QString defaultName)
35{
36 int index = args.indexOf(name);
37 return (index != -1) ? args[index + 1] : QString(defaultName);
38}
34QStringList getProfileFromDir(const QString &path) {39QStringList getProfileFromDir(const QString &path) {
35 QDir layoutDir(path);40 QDir layoutDir(path);
36 layoutDir.setNameFilters(QStringList("*.json"));41 layoutDir.setNameFilters(QStringList("*.json"));
@@ -78,16 +83,20 @@
7883
79 QStringList args = a.arguments();84 QStringList args = a.arguments();
80 if (args.contains("-h") || args.contains("--help")) {85 if (args.contains("-h") || args.contains("--help")) {
81 qDebug() << "usage: " + args.at(0) + " [-p|--phone] [-t|--tablet] [-h|--help] [-I <path>]";86 qDebug() << "usage: " + args.at(0) + " [-p|--phone] [--workdir <dir>] [-t|--tablet] [-h|--help] [-I <path>]";
82 qDebug() << " -p|--phone If running on Desktop, start in a phone sized window.";87 qDebug() << " -p|--phone If running on Desktop, start in a phone sized window.";
83 qDebug() << " -t|--tablet If running on Desktop, start in a tablet sized window.";88 qDebug() << " -t|--tablet If running on Desktop, start in a tablet sized window.";
84 qDebug() << " --forceAuth <true|false> Force authentication on or off.";89 qDebug() << " --forceAuth <true|false> Force authentication on or off.";
85 qDebug() << " -h|--help Print this help.";90 qDebug() << " -h|--help Print this help.";
86 qDebug() << " -I <path> Give a path for an additional QML import directory. May be used multiple times.";91 qDebug() << " -I <path> Give a path for an additional QML import directory. May be used multiple times.";
87 qDebug() << " -q <qmlfile> Give an alternative location for the main qml file.";92 qDebug() << " -q <qmlfile> Give an alternative location for the main qml file.";
93 qDebug() << " --workdir <dir> Change working directory to 'dir'";
88 return 0;94 return 0;
89 }95 }
9096
97 //Dynamic folder home
98 view.engine()->rootContext()->setContextProperty("workdir", getNamedArgument(args, "--workdir", "$HOME"));
99
91 // Desktop doesn't have yet Unity8 and so no unity greeter either. Consequently it doesn't100 // Desktop doesn't have yet Unity8 and so no unity greeter either. Consequently it doesn't
92 // also have any "PIN code" or "Password" extra authentication. Don't require any extra101 // also have any "PIN code" or "Password" extra authentication. Don't require any extra
93 // authentication there by default102 // authentication there by default
94103
=== modified file 'src/app/qml/TerminalComponent.qml'
--- src/app/qml/TerminalComponent.qml 2014-11-16 22:38:02 +0000
+++ src/app/qml/TerminalComponent.qml 2015-03-23 17:48:21 +0000
@@ -15,7 +15,7 @@
1515
16 session: QMLTermSession {16 session: QMLTermSession {
17 id: terminalSession17 id: terminalSession
18 initialWorkingDirectory: "$HOME"18 initialWorkingDirectory: workdir
19 }19 }
2020
21 QMLTermScrollbar {21 QMLTermScrollbar {

Subscribers

People subscribed via source and target branches