Merge lp:~dbarth/ubuntu-calendar-app/push-helper into lp:ubuntu-calendar-app

Proposed by David Barth
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 740
Merged at revision: 758
Proposed branch: lp:~dbarth/ubuntu-calendar-app/push-helper
Merge into: lp:ubuntu-calendar-app
Diff against target: 71 lines (+21/-2)
6 files modified
click/CMakeLists.txt (+1/-1)
click/calendar-helper-apparmor.json (+7/-0)
click/calendar.apparmor (+2/-1)
click/manifest.json.in (+4/-0)
click/push-helper (+4/-0)
click/push-helper.json (+3/-0)
To merge this branch: bzr merge lp:~dbarth/ubuntu-calendar-app/push-helper
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
David Barth (community) Approve
Review via email: mp+280697@code.launchpad.net

Commit message

Integrate the Calendar app in the system notifications settings.

Description of the change

Integrate the Calendar app in the system notifications settings.

To post a comment you must log in.
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

This shouldn't land until https://requests.ci-train.ubuntu.com/#/ticket/790 does. It adds the enable/disable switch in system settings -> notifications, but that won't work until the above i-d patch lands.

740. By David Barth

rollback po file change

Revision history for this message
David Barth (dbarth) wrote :

The indicator-datetime work is ready now.
This branch and others are ready for landing in silo 003
+1 for me

review: Approve
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) :
review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'click/CMakeLists.txt'
--- click/CMakeLists.txt 2014-09-29 20:44:47 +0000
+++ click/CMakeLists.txt 2016-02-03 17:15:41 +0000
@@ -3,7 +3,7 @@
3 set(BZR_REVNO "latest")3 set(BZR_REVNO "latest")
4 endif(NOT BZR_REVNO)4 endif(NOT BZR_REVNO)
5 configure_file(manifest.json.in ${CMAKE_CURRENT_BINARY_DIR}/manifest.json)5 configure_file(manifest.json.in ${CMAKE_CURRENT_BINARY_DIR}/manifest.json)
6 install(FILES ${CMAKE_CURRENT_BINARY_DIR}/manifest.json calendar.apparmor6 install(FILES ${CMAKE_CURRENT_BINARY_DIR}/manifest.json calendar.apparmor push-helper push-helper.json calendar-helper-apparmor.json
7 DESTINATION ${CMAKE_INSTALL_PREFIX})7 DESTINATION ${CMAKE_INSTALL_PREFIX})
88
9 # make the click files visible in qtcreator9 # make the click files visible in qtcreator
1010
=== added file 'click/calendar-helper-apparmor.json'
--- click/calendar-helper-apparmor.json 1970-01-01 00:00:00 +0000
+++ click/calendar-helper-apparmor.json 2016-02-03 17:15:41 +0000
@@ -0,0 +1,7 @@
1{
2 "template": "ubuntu-push-helper",
3 "policy_groups": [
4 "push-notification-client"
5 ],
6 "policy_version": 1.2
7}
08
=== modified file 'click/calendar.apparmor'
--- click/calendar.apparmor 2015-03-28 11:31:47 +0000
+++ click/calendar.apparmor 2016-02-03 17:15:41 +0000
@@ -3,7 +3,8 @@
3 "calendar",3 "calendar",
4 "networking",4 "networking",
5 "contacts",5 "contacts",
6 "accounts"6 "accounts",
7 "push-notification-client"
7 ],8 ],
8 "policy_version": 1.29 "policy_version": 1.2
9}10}
1011
=== modified file 'click/manifest.json.in'
--- click/manifest.json.in 2014-12-28 23:12:44 +0000
+++ click/manifest.json.in 2016-02-03 17:15:41 +0000
@@ -8,6 +8,10 @@
8 "apparmor": "calendar.apparmor",8 "apparmor": "calendar.apparmor",
9 "desktop": "@DESKTOP_FILE@",9 "desktop": "@DESKTOP_FILE@",
10 "urls": "@URLS_FILE@"10 "urls": "@URLS_FILE@"
11 },
12 "calendar-helper": {
13 "apparmor": "calendar-helper-apparmor.json",
14 "push-helper": "push-helper.json"
11 }15 }
12 },16 },
13 "icon": "@ICON@",17 "icon": "@ICON@",
1418
=== added file 'click/push-helper'
--- click/push-helper 1970-01-01 00:00:00 +0000
+++ click/push-helper 2016-02-03 17:15:41 +0000
@@ -0,0 +1,4 @@
1#!/usr/lib/initramfs-tools/bin/busybox static-sh
2cp $1 $2
3
4# This is just a temporary hack!
0\ No newline at end of file5\ No newline at end of file
16
=== added file 'click/push-helper.json'
--- click/push-helper.json 1970-01-01 00:00:00 +0000
+++ click/push-helper.json 2016-02-03 17:15:41 +0000
@@ -0,0 +1,3 @@
1{
2 "exec": "push-helper"
3}

Subscribers

People subscribed via source and target branches

to status/vote changes: