Merge lp:~darkxst/ubuntu/utopic/gnome-settings-daemon/lp1372346-nodatetime into lp:~ubuntu-desktop/gnome-settings-daemon/ubuntu

Proposed by Tim Lunn
Status: Merged
Approved by: Robert Ancell
Approved revision: 477
Merged at revision: 477
Proposed branch: lp:~darkxst/ubuntu/utopic/gnome-settings-daemon/lp1372346-nodatetime
Merge into: lp:~ubuntu-desktop/gnome-settings-daemon/ubuntu
Diff against target: 121 lines (+88/-2)
4 files modified
debian/changelog (+7/-0)
debian/control.in (+2/-2)
debian/patches/geoclue-build-fixes.patch (+78/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~darkxst/ubuntu/utopic/gnome-settings-daemon/lp1372346-nodatetime
Reviewer Review Type Date Requested Status
Robert Ancell Approve
Review via email: mp+236639@code.launchpad.net

Description of the change

don't build the new datetime plugin since it requires geoclue-2.0.

A seperate patch for g-c-c will be required to hide the "Automatic Timezone" setting, since that won't work without the datetime plugin.

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Makes sense.

review: Needs Fixing
Revision history for this message
Robert Ancell (robert-ancell) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2014-09-30 12:36:34 +0000
+++ debian/changelog 2014-09-30 23:09:07 +0000
@@ -1,3 +1,10 @@
1gnome-settings-daemon (3.12.2-1ubuntu2) utopic; urgency=medium
2
3 * debian/patches/geoclue-build-fixes.patch: disable build of new
4 datetime plugin since geoclue-2.0 is not currently in main.
5
6 -- Tim Lunn <tim@feathertop.org> Wed, 01 Oct 2014 07:45:02 +1000
7
1gnome-settings-daemon (3.12.2-1ubuntu1) utopic; urgency=medium8gnome-settings-daemon (3.12.2-1ubuntu1) utopic; urgency=medium
29
3 * New Upstream Release (LP: #1372346)10 * New Upstream Release (LP: #1372346)
411
=== modified file 'debian/control.in'
--- debian/control.in 2014-09-23 23:33:37 +0000
+++ debian/control.in 2014-09-30 23:09:07 +0000
@@ -38,8 +38,8 @@
38 xserver-xorg-input-wacom [!hurd-any !kfreebsd-any !s390 !s390x],38 xserver-xorg-input-wacom [!hurd-any !kfreebsd-any !s390 !s390x],
39 librsvg2-dev (>= 2.36.2),39 librsvg2-dev (>= 2.36.2),
40 libgweather-3-dev (>= 3.9.5),40 libgweather-3-dev (>= 3.9.5),
41 libgeocode-glib-dev (>= 3.10.0),41# libgeocode-glib-dev (>= 3.10.0),
42 geoclue-2.0 (>= 2.1.2),42# geoclue-2.0 (>= 2.1.2),
43 xkb-data,43 xkb-data,
44 libxkbfile-dev,44 libxkbfile-dev,
45Standards-Version: 3.9.545Standards-Version: 3.9.5
4646
=== added file 'debian/patches/geoclue-build-fixes.patch'
--- debian/patches/geoclue-build-fixes.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/geoclue-build-fixes.patch 2014-09-30 23:09:07 +0000
@@ -0,0 +1,78 @@
1From 4faa5581f6bb568fa5d60bea533f0df4eaf5c5ed Mon Sep 17 00:00:00 2001
2From: Tim Lunn <tim@feathertop.org>
3Date: Wed, 1 Oct 2014 07:42:06 +1000
4Subject: [PATCH] disable build of new datetime panel if geoclue-2.0 is not
5 available
6
7---
8 configure.ac | 25 +++++++++++++++----------
9 plugins/Makefile.am | 7 ++++++-
10 2 files changed, 21 insertions(+), 11 deletions(-)
11
12diff --git a/configure.ac b/configure.ac
13index c42ea8b..a52ace8 100644
14--- a/configure.ac
15+++ b/configure.ac
16@@ -234,18 +234,23 @@ dnl ---------------------------------------------------------------------------
17 AC_CHECK_LIBM
18 AC_SUBST(LIBM)
19
20-PKG_CHECK_MODULES(DATETIME,
21- geoclue-2.0 >= $GEOCLUE_REQUIRED_VERSION
22- geocode-glib-1.0 >= $GEOCODE_GLIB_REQUIRED_VERSION
23- gweather-3.0 >= $LIBGWEATHER_REQUIRED_VERSION
24- polkit-gobject-1 >= $POLKIT_REQUIRED_VERSION
25-)
26+PKG_CHECK_MODULES(GEOCLUE2, geoclue-2.0, have_geoclue="yes", have_geoclue="no")
27+if test "x$have_geoclue" = "xyes"; then
28
29-GEOCLUE_DBUS_INTERFACE_XML=`pkg-config --variable=dbus_interface geoclue-2.0`
30-if test "x$GEOCLUE_DBUS_INTERFACE_XML" = "x"; then
31- AC_MSG_ERROR([Cannot find dbus_interface variable in geoclue-2.0.pc])
32+ PKG_CHECK_MODULES(DATETIME,
33+ geoclue-2.0 >= $GEOCLUE_REQUIRED_VERSION
34+ geocode-glib-1.0 >= $GEOCODE_GLIB_REQUIRED_VERSION
35+ gweather-3.0 >= $LIBGWEATHER_REQUIRED_VERSION
36+ polkit-gobject-1 >= $POLKIT_REQUIRED_VERSION
37+ )
38+
39+ GEOCLUE_DBUS_INTERFACE_XML=`pkg-config --variable=dbus_interface geoclue-2.0`
40+ if test "x$GEOCLUE_DBUS_INTERFACE_XML" = "x"; then
41+ AC_MSG_ERROR([Cannot find dbus_interface variable in geoclue-2.0.pc])
42+ fi
43+ AC_SUBST(GEOCLUE_DBUS_INTERFACE_XML)
44 fi
45-AC_SUBST(GEOCLUE_DBUS_INTERFACE_XML)
46+AM_CONDITIONAL(HAVE_GEOCLUE2, test x$have_geoclue = xyes)
47
48 dnl ---------------------------------------------------------------------------
49 dnl - wacom (disabled for s390/s390x and non Linux platforms)
50diff --git a/plugins/Makefile.am b/plugins/Makefile.am
51index 7bb01f0..7bd261d 100644
52--- a/plugins/Makefile.am
53+++ b/plugins/Makefile.am
54@@ -6,7 +6,6 @@ enabled_plugins = \
55 clipboard \
56 color \
57 cursor \
58- datetime \
59 dummy \
60 power \
61 housekeeping \
62@@ -28,6 +27,12 @@ else
63 disabled_plugins += smartcard
64 endif
65
66+if HAVE_GEOCLUE2
67+enabled_plugins += datetime
68+else
69+disabled_plugins += datetime
70+endif
71+
72 if HAVE_GUDEV
73 enabled_plugins += orientation
74 else
75--
762.1.0
77
78
079
=== modified file 'debian/patches/series'
--- debian/patches/series 2014-09-23 23:33:37 +0000
+++ debian/patches/series 2014-09-30 23:09:07 +0000
@@ -12,3 +12,4 @@
12revert_background_dropping.patch12revert_background_dropping.patch
13revert-gsettings-removals.patch13revert-gsettings-removals.patch
14revert_media-keys_fix_battery_key.patch14revert_media-keys_fix_battery_key.patch
15geoclue-build-fixes.patch

Subscribers

People subscribed via source and target branches

to all changes: