Merge lp:~darkxst/ubuntu/utopic/gnome-control-center/lp1372346-noautotz into lp:~ubuntu-desktop/gnome-control-center/ubuntu

Proposed by Tim Lunn
Status: Merged
Approved by: Robert Ancell
Approved revision: 649
Merged at revision: 649
Proposed branch: lp:~darkxst/ubuntu/utopic/gnome-control-center/lp1372346-noautotz
Merge into: lp:~ubuntu-desktop/gnome-control-center/ubuntu
Diff against target: 133 lines (+113/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/revert_automatic_timezone.patch (+105/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~darkxst/ubuntu/utopic/gnome-control-center/lp1372346-noautotz
Reviewer Review Type Date Requested Status
Robert Ancell Approve
Review via email: mp+236641@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Makes sense.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2014-09-30 12:52:05 +0000
+++ debian/changelog 2014-09-30 23:31:59 +0000
@@ -1,3 +1,10 @@
1gnome-control-center (1:3.12.1-5ubuntu2) UNRELEASED; urgency=medium
2
3 * debian/patches/revert_automatic_timezone.patch: datetime plugin
4 is disabled since it requires geoclue-2.0 which is in universe
5
6 -- Tim Lunn <tim@feathertop.org> Wed, 01 Oct 2014 09:02:19 +1000
7
1gnome-control-center (1:3.12.1-5ubuntu1) utopic; urgency=medium8gnome-control-center (1:3.12.1-5ubuntu1) utopic; urgency=medium
29
3 * New Upstream Release (LP: #1372346)10 * New Upstream Release (LP: #1372346)
411
=== added file 'debian/patches/revert_automatic_timezone.patch'
--- debian/patches/revert_automatic_timezone.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/revert_automatic_timezone.patch 2014-09-30 23:31:59 +0000
@@ -0,0 +1,105 @@
1From 6f07b9014326e3234af305743c94018117a6001b Mon Sep 17 00:00:00 2001
2From: Tim Lunn <tim@feathertop.org>
3Date: Wed, 1 Oct 2014 08:04:06 +1000
4Subject: [PATCH] Revert "datetime: Show the automatic timezone switch"
5
6This reverts commit c68f9eca501b662fd819bab1ae021098a7cdaf9b.
7---
8 panels/datetime/cc-datetime-panel.c | 25 ++-----------------------
9 panels/datetime/datetime.ui | 1 -
10 2 files changed, 2 insertions(+), 24 deletions(-)
11
12diff --git a/panels/datetime/cc-datetime-panel.c b/panels/datetime/cc-datetime-panel.c
13index ec76d22..ec3cf0c 100644
14--- a/panels/datetime/cc-datetime-panel.c
15+++ b/panels/datetime/cc-datetime-panel.c
16@@ -64,9 +64,6 @@ enum {
17
18 #define FILECHOOSER_SCHEMA "org.gtk.Settings.FileChooser"
19
20-#define DATETIME_SCHEMA "org.gnome.desktop.datetime"
21-#define AUTO_TIMEZONE_KEY "automatic-timezone"
22-
23 struct _CcDateTimePanelPrivate
24 {
25 GtkBuilder *builder;
26@@ -83,7 +80,6 @@ struct _CcDateTimePanelPrivate
27 GDateTime *date;
28
29 GSettings *clock_settings;
30- GSettings *datetime_settings;
31 GSettings *filechooser_settings;
32 GDesktopClockFormat clock_format;
33 gboolean ampm_available;
34@@ -133,7 +129,6 @@ cc_date_time_panel_dispose (GObject *object)
35 g_clear_object (&priv->dtm);
36 g_clear_object (&priv->permission);
37 g_clear_object (&priv->clock_settings);
38- g_clear_object (&priv->datetime_settings);
39 g_clear_object (&priv->filechooser_settings);
40
41 g_clear_pointer (&priv->date, g_date_time_unref);
42@@ -752,17 +747,15 @@ on_permission_changed (GPermission *permission,
43 gpointer data)
44 {
45 CcDateTimePanelPrivate *priv = CC_DATE_TIME_PANEL (data)->priv;
46- gboolean allowed, auto_timezone, using_ntp;
47+ gboolean allowed, using_ntp;
48
49 allowed = (priv->permission == NULL || g_permission_get_allowed (priv->permission));
50 using_ntp = gtk_switch_get_active (GTK_SWITCH (W("network_time_switch")));
51- auto_timezone = gtk_switch_get_active (GTK_SWITCH (W("auto_timezone_switch")));
52
53 /* All the widgets but the lock button and the 24h setting */
54 gtk_widget_set_sensitive (W("auto-datetime-row"), allowed);
55- gtk_widget_set_sensitive (W("auto-timezone-row"), allowed);
56 gtk_widget_set_sensitive (W("datetime-button"), allowed && !using_ntp);
57- gtk_widget_set_sensitive (W("timezone-button"), allowed && !auto_timezone);
58+ gtk_widget_set_sensitive (W("timezone-button"), allowed);
59
60 /* Hide the subdialogs if we no longer have permissions */
61 if (!allowed)
62@@ -953,10 +946,6 @@ list_box_row_activated (GtkListBox *listbox,
63 {
64 toggle_switch (W ("network_time_switch"));
65 }
66- else if (!g_strcmp0 (widget_name, "auto-timezone-row"))
67- {
68- toggle_switch (W ("auto_timezone_switch"));
69- }
70 else if ((found = g_strrstr (widget_name, "button")))
71 {
72 /* replace "button" with "dialog" */
73@@ -1292,16 +1281,6 @@ cc_date_time_panel_init (CcDateTimePanel *self)
74 g_signal_connect (W("network_time_switch"), "notify::active",
75 G_CALLBACK (change_ntp), self);
76
77- /* Timezone settings */
78- bind_switch_to_row (self,
79- W ("auto_timezone_switch"),
80- W ("timezone-button"));
81-
82- priv->datetime_settings = g_settings_new (DATETIME_SCHEMA);
83- g_settings_bind (priv->datetime_settings, AUTO_TIMEZONE_KEY,
84- W ("auto_timezone_switch"), "active",
85- G_SETTINGS_BIND_DEFAULT);
86-
87 /* Clock settings */
88 priv->clock_settings = g_settings_new (CLOCK_SCHEMA);
89
90diff --git a/panels/datetime/datetime.ui b/panels/datetime/datetime.ui
91index c7cdcf2..0c01db6 100644
92--- a/panels/datetime/datetime.ui
93+++ b/panels/datetime/datetime.ui
94@@ -548,7 +548,6 @@
95 <property name="can_focus">True</property>
96 <child>
97 <object class="GtkBox" id="box3">
98- <property name="visible">True</property>
99 <property name="can_focus">False</property>
100 <property name="spacing">50</property>
101 <child>
102--
1032.1.0
104
105
0106
=== modified file 'debian/patches/series'
--- debian/patches/series 2014-09-30 05:15:58 +0000
+++ debian/patches/series 2014-09-30 23:31:59 +0000
@@ -14,3 +14,4 @@
14ubuntu-gnome-version.patch14ubuntu-gnome-version.patch
15revert_new_bluetooth.patch15revert_new_bluetooth.patch
16revert-bluetooth-BlueZ5-interface.patch16revert-bluetooth-BlueZ5-interface.patch
17revert_automatic_timezone.patch

Subscribers

People subscribed via source and target branches