Merge lp:~dannf/ubuntu/trusty/base-installer/lp1247601 into lp:ubuntu/trusty/base-installer

Proposed by dann frazier
Status: Work in progress
Proposed branch: lp:~dannf/ubuntu/trusty/base-installer/lp1247601
Merge into: lp:ubuntu/trusty/base-installer
Diff against target: 48 lines (+14/-6)
3 files modified
debian/changelog (+7/-0)
kernel/armel.sh (+1/-1)
library.sh (+6/-5)
To merge this branch: bzr merge lp:~dannf/ubuntu/trusty/base-installer/lp1247601
Reviewer Review Type Date Requested Status
James Page Abstain
Review via email: mp+193834@code.launchpad.net
To post a comment you must log in.
Revision history for this message
James Page (james-page) wrote :

Hi Dann

Thanks for the merge proposal; this looks OK but as this touches the base-installer, I'd prefer that someone closer to this package review and merge if its good.

review: Abstain

Unmerged revisions

108. By dann frazier

Add exynos5 subarch kernel support (LP: #1247601)

107. By dann frazier

Allow installation of kernels from universe (LP: #1247601)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-09-10 15:15:59 +0000
+++ debian/changelog 2013-11-04 18:56:39 +0000
@@ -1,3 +1,10 @@
1base-installer (1.122ubuntu18) UNRELEASED; urgency=low
2
3 * Allow installation of kernels from universe (LP: #1247601)
4 * Add exynos5 subarch kernel support (LP: #1247601)
5
6 -- dann frazier <dann.frazier@canonical.com> Fri, 01 Nov 2013 16:20:44 -0600
7
1base-installer (1.122ubuntu17) saucy; urgency=low8base-installer (1.122ubuntu17) saucy; urgency=low
29
3 * Add generic-lpae the the allowed list of subarches in armhf/armel.10 * Add generic-lpae the the allowed list of subarches in armhf/armel.
411
=== modified file 'kernel/armel.sh'
--- kernel/armel.sh 2013-09-10 15:15:59 +0000
+++ kernel/armel.sh 2013-11-04 18:56:39 +0000
@@ -1,6 +1,6 @@
1arch_get_kernel_flavour () {1arch_get_kernel_flavour () {
2 case "$SUBARCH" in2 case "$SUBARCH" in
3 armadaxp|dove|generic-lpae|generic|imx51|omap|omap4|iop32x|iop33x|ixp4xx|kirkwood|orion5x|versatile|mx5)3 armadaxp|dove|exynos5|generic-lpae|generic|imx51|omap|omap4|iop32x|iop33x|ixp4xx|kirkwood|orion5x|versatile|mx5)
4 echo "$SUBARCH"4 echo "$SUBARCH"
5 return 0 ;;5 return 0 ;;
6 ads)6 ads)
77
=== modified file 'library.sh'
--- library.sh 2013-07-19 11:30:15 +0000
+++ library.sh 2013-11-04 18:56:39 +0000
@@ -330,11 +330,12 @@
330 db_get mirror/$PROTOCOL/directory || mirror_error=1330 db_get mirror/$PROTOCOL/directory || mirror_error=1
331 DIRECTORY="$RET"331 DIRECTORY="$RET"
332332
333 if db_get apt-setup/restricted && [ "$RET" = false ]; then333 COMPONENTS="main"
334 COMPONENTS="main"334 for optcomp in universe restricted; do
335 else335 if db_get apt-setup/$optcomp && [ "$RET" = true ]; then
336 COMPONENTS="main,restricted"336 COMPONENTS="$COMPONENTS,$optcomp"
337 fi337 fi
338 done
338339
339 if [ "$mirror_error" = 1 ] || [ -z "$PROTOCOL" ] || [ -z "$MIRROR" ]; then340 if [ "$mirror_error" = 1 ] || [ -z "$PROTOCOL" ] || [ -z "$MIRROR" ]; then
340 exit_error base-installer/cannot_install341 exit_error base-installer/cannot_install

Subscribers

People subscribed via source and target branches

to all changes: