Merge lp:~daker/loco-team-portal/ld-languages-menu into lp:loco-team-portal
Proposed by
Adnane Belmadiaf
Status: | Rejected | ||||||||
---|---|---|---|---|---|---|---|---|---|
Rejected by: | Adnane Belmadiaf | ||||||||
Proposed branch: | lp:~daker/loco-team-portal/ld-languages-menu | ||||||||
Merge into: | lp:loco-team-portal | ||||||||
Diff against target: |
124 lines (+44/-7) 5 files modified
loco_directory/common/context_processors.py (+7/-0) loco_directory/common/utils.py (+30/-3) loco_directory/common/views.py (+4/-2) loco_directory/settings.py (+1/-0) loco_directory/templates/base.html (+2/-2) |
||||||||
To merge this branch: | bzr merge lp:~daker/loco-team-portal/ld-languages-menu | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Hall (community) | Needs Fixing | ||
Daniel Holbach (community) | Needs Information | ||
Review via email: mp+42760@code.launchpad.net |
To post a comment you must log in.
Unmerged revisions
- 341. By Adnane Belmadiaf
-
* Refactoring code to reduce the number of calls
- 340. By Adnane Belmadiaf
-
* Removed unused gettext import
- 339. By Adnane Belmadiaf
-
* Removed the print statement
- 338. By Adnane Belmadiaf
-
* Fixed bug 648296
* Fixed bug 648293
Thanks a lot for your work on this.
A few things: common/ utils.py sys and gettext are unnecessarily imported. common/ utils.py executed? I get the feeling that it's even for a simple page called quite often (I just added a debug print message.) and every time it reads a bunch of directories and files. Is there a way how we can make this run less often?
- In loco_directory/
- How often is check_for_language in loco_directory/