Merge lp:~cyphermox/overlay-scrollbar/fix-second-use into lp:overlay-scrollbar

[Mathieu Trudel-Lapierre]

Fix scrollbars not showing up again after first use on GTK 3.8.

Fix scrollbars not showing up again after first use on GTK 3.8.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:372
http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-ci/3/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-coverity-check/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-raring-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-raring-armhf-ci/3
Coverity artifacts:
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/22/artifact/results/coverity/NO_COVERITY_DEFECTS.txt

Click here to trigger a rebuild:
http://s-jenkins:8080/job/overlay-scrollbar-ci/3/rebuild

review: Approve (continuous-integration)

[Mathieu Trudel-Lapierre (cyphermox)]

Actually just noticed it's wrong for horizontal scroll.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:373
http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-ci/4/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-coverity-check/23/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-raring-amd64-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-raring-armhf-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-raring-i386-ci/1

Click here to trigger a rebuild:
http://s-jenkins:8080/job/overlay-scrollbar-ci/4/rebuild

review: Needs Fixing (continuous-integration)

[Allan LeSage (allanlesage)]

Investigating this failure, one min pls.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:373
http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-ci/5/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-coverity-check/27
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-raring-amd64-ci/5
    FAILURE: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-raring-armhf-ci/5/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-raring-i386-ci/2
Coverity artifacts:
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/27/artifact/results/coverity/NO_COVERITY_DEFECTS.txt

Click here to trigger a rebuild:
http://s-jenkins:8080/job/overlay-scrollbar-ci/5/rebuild

review: Needs Fixing (continuous-integration)

[Allan LeSage (allanlesage)]

We're short on armhf testers, will attempt again.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:373
http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-ci/6/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-coverity-check/28
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-raring-amd64-ci/6
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-raring-armhf-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-raring-i386-ci/3
Coverity artifacts:
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/28/artifact/results/coverity/NO_COVERITY_DEFECTS.txt

Click here to trigger a rebuild:
http://s-jenkins:8080/job/overlay-scrollbar-ci/6/rebuild

review: Approve (continuous-integration)

[Andrea Cimitan (cimi)]

I didn't try, but I am sure the patch "works" against the bug.
However, I don't think the patch is the right approach.
In particular, I can't see why we should resize a window every 'map' event, it just doesn't seem right to me. It should be handled by Gtk+, I believe this is showing a Gtk+ bug instead, especially looks like a regression.

Best approach I recommend is to fix Gtk+ instead, and/or seeing the real reason for the failure.

In case we cannot find our way through Gtk+, we will merge this patch with a big FIXME linked to a Gtk+ bug report.

review: Disapprove

Unmerged revisions

373. By Mathieu Trudel-Lapierre on 2013-05-13

Properly handle thumb orientation

372. By Mathieu Trudel-Lapierre on 2013-05-04

Fix scrollbars not showing up again after first use on GTK 3.8.

=== modified file 'os/os-thumb.c'
--- os/os-thumb.c	2013-02-02 00:46:51 +0000
+++ os/os-thumb.c	2013-05-13 15:06:28 +0000
@@ -978,6 +978,11 @@
       gtk_grab_remove (priv->grabbed_widget);
     }
 
+  if (priv->orientation == GTK_ORIENTATION_VERTICAL)
+    os_thumb_resize (thumb, THUMB_WIDTH, THUMB_HEIGHT);
+  else
+    os_thumb_resize (thumb, THUMB_HEIGHT, THUMB_WIDTH);
+
   GTK_WIDGET_CLASS (os_thumb_parent_class)->map (widget);
 }