Merge lp:~coolyashish/postorius/add_email_address_in_settings into lp:postorius

[Ashish]

Previously we are getting error on add email address page in user's settings as there is not email_confirmation_from set in the send_confirmation_link function in AddressConfirmationProfile model. This change adds the required email in the function.

[Abhilash Raj (raj-abhilash1)]

We don't want to send confirmation email from the user's email, it should be from listowner or some other address (like noreply@domain or something).

[Terri (terriko)]

Abhilash has a more complete fix here https://code.launchpad.net/~raj-abhilash1/postorius/lp1437866

Unmerged revisions

206. By Ashish on 2015-03-13

EMAIL_CONFIRMATION_FROM in AddressConfirmationProfile.

=== modified file 'src/postorius/models.py'
--- src/postorius/models.py	2015-02-09 14:35:44 +0000
+++ src/postorius/models.py	2015-03-13 18:25:29 +0000
@@ -291,5 +291,5 @@
             settings, 'EMAIL_CONFIRMATION_SUBJECT', u'Confirmation needed')
         send_mail(email_subject,
                   get_template(template_path).render(template_context),
-                  getattr(settings, 'EMAIL_CONFIRMATION_FROM'),
+                  getattr(settings, 'EMAIL_CONFIRMATION_FROM', self.user.email),
                   [self.email])