Merge lp:~compiz-team/compiz-core/compiz-core.fix_860286 into lp:compiz-core/0.9.5

Proposed by Sam Spilsbury
Status: Merged
Merged at revision: 2839
Proposed branch: lp:~compiz-team/compiz-core/compiz-core.fix_860286
Merge into: lp:compiz-core/0.9.5
Diff against target: 81 lines (+16/-9)
2 files modified
plugins/composite/src/window.cpp (+4/-4)
plugins/opengl/src/paint.cpp (+12/-5)
To merge this branch: bzr merge lp:~compiz-team/compiz-core/compiz-core.fix_860286
Reviewer Review Type Date Requested Status
Robert Carr (community) Approve
Review via email: mp+77151@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Robert Carr (robertcarr) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugins/composite/src/window.cpp'
--- plugins/composite/src/window.cpp 2011-09-19 12:54:22 +0000
+++ plugins/composite/src/window.cpp 2011-09-27 11:57:56 +0000
@@ -268,7 +268,7 @@
268 return;268 return;
269269
270 if (priv->window->shaded () ||270 if (priv->window->shaded () ||
271 (priv->window->isViewable () && priv->damaged))271 (priv->window->isViewable ()))
272 {272 {
273 int x1, x2, y1, y2;273 int x1, x2, y1, y2;
274274
@@ -339,7 +339,7 @@
339 return;339 return;
340340
341 if (priv->window->shaded () || force ||341 if (priv->window->shaded () || force ||
342 (priv->window->isViewable () && priv->damaged))342 (priv->window->isViewable ()))
343 {343 {
344 int border = priv->window->geometry ().border ();344 int border = priv->window->geometry ().border ();
345345
@@ -561,7 +561,7 @@
561 CompSize size = CompSize ();561 CompSize size = CompSize ();
562562
563563
564 if (window->shaded () || (window->isViewable () && damaged))564 if (window->shaded () || (window->isViewable ()))
565 {565 {
566 int x, y, x1, x2, y1, y2;566 int x, y, x1, x2, y1, y2;
567567
@@ -618,7 +618,7 @@
618void618void
619PrivateCompositeWindow::moveNotify (int dx, int dy, bool now)619PrivateCompositeWindow::moveNotify (int dx, int dy, bool now)
620{620{
621 if (window->shaded () || (window->isViewable () && damaged))621 if (window->shaded () || (window->isViewable ()))
622 {622 {
623 int x, y, x1, x2, y1, y2;623 int x, y, x1, x2, y1, y2;
624624
625625
=== modified file 'plugins/opengl/src/paint.cpp'
--- plugins/opengl/src/paint.cpp 2011-09-16 06:51:02 +0000
+++ plugins/opengl/src/paint.cpp 2011-09-27 11:57:56 +0000
@@ -241,8 +241,15 @@
241241
242 if (!w->shaded ())242 if (!w->shaded ())
243 {243 {
244 if (!w->isViewable () ||244 /* Non-damaged windows don't have valid pixmap
245 !CompositeWindow::get (w)->damaged ())245 * contents and we aren't displaying them yet
246 * so don't factor them into occlusion detection */
247 if (!gw->priv->cWindow->damaged ())
248 {
249 gw->priv->clip = region;
250 continue;
251 }
252 if (!w->isViewable ())
246 continue;253 continue;
247 }254 }
248255
@@ -322,8 +329,7 @@
322329
323 if (!w->shaded ())330 if (!w->shaded ())
324 {331 {
325 if (!w->isViewable () ||332 if (!w->isViewable ())
326 !CompositeWindow::get (w)->damaged ())
327 continue;333 continue;
328 }334 }
329335
@@ -1171,7 +1177,8 @@
1171 if (reg.isEmpty ())1177 if (reg.isEmpty ())
1172 return true;1178 return true;
11731179
1174 if (!priv->window->isViewable ())1180 if (!priv->window->isViewable () ||
1181 !priv->cWindow->damaged ())
1175 return true;1182 return true;
11761183
1177 if (priv->textures.empty () && !bind ())1184 if (priv->textures.empty () && !bind ())

Subscribers

People subscribed via source and target branches