Launchpad itself

Merge lp:~cjwatson/launchpad/no-default-http-proxy into lp:launchpad

  1. no-default-http-proxy
  2. Merge into devel
Proposed by Colin Watson
Status: Merged
Merged at revision: 18704
Proposed branch: lp:~cjwatson/launchpad/no-default-http-proxy
Merge into: lp:launchpad
Diff against target: 12 lines (+1/-1)
1 file modified
lib/lp/services/config/schema-lazr.conf (+1/-1)
To merge this branch: bzr merge lp:~cjwatson/launchpad/no-default-http-proxy
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+348540@code.launchpad.net

Commit message

Don't set http_proxy by default.

Description of the change

It's now set in lp-production-configs for deployments on Canonical networks, and anyone else is unlikely to want squid.internal.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

I'm going to self-approve this, as it's pretty trivial and it fixes a current test failure on buildbot.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/services/config/schema-lazr.conf'
--- lib/lp/services/config/schema-lazr.conf 2018-06-06 12:46:56 +0000
+++ lib/lp/services/config/schema-lazr.conf 2018-06-26 15:01:25 +0000
@@ -915,7 +915,7 @@
915# not the Launchpad section? At the moment, there are only scripts915# not the Launchpad section? At the moment, there are only scripts
916# using this.916# using this.
917# datatype: string917# datatype: string
918http_proxy: http://squid.internal:3128/918http_proxy: none
919919
920# Session cookies being sent to a subdomain of the parent920# Session cookies being sent to a subdomain of the parent
921# domains listed here will be sent to the parent domain,921# domains listed here will be sent to the parent domain,