Merge lp:~cjwatson/launchpad/global-urlfetch-timeout into lp:launchpad
Proposed by
Colin Watson
Status: | Merged |
---|---|
Merged at revision: | 18910 |
Proposed branch: | lp:~cjwatson/launchpad/global-urlfetch-timeout |
Merge into: | lp:launchpad |
Diff against target: |
145 lines (+15/-16) 4 files modified
lib/lp/services/config/schema-lazr.conf (+4/-0) lib/lp/services/mail/tests/test_signedmessage.py (+7/-1) lib/lp/services/tests/test_timeout.py (+1/-13) lib/lp/services/timeout.py (+3/-2) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/global-urlfetch-timeout |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+364669@code.launchpad.net |
Commit message
Give urlfetch a default timeout, fixing a regression in process-mail.
Description of the change
The default timeout assertion has been driving me nuts ever since I started converting more things to urlfetch, so let's make urlfetch have a reasonable default for scripts. Contexts with a timeout budget need to override this, of course, but they generally already do.
In theory this should obviate a number of more specific timeout configuration items, but I decided to leave those alone in case they need isolated overrides for some reason; we can just avoid adding more unless they're specifically needed.
To post a comment you must log in.