Merge ~cjwatson/launchpad:bpb-librarian-auth into launchpad:master
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 95779342f992f0c90be8fc33a26dfc2f5470888d |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:bpb-librarian-auth |
Merge into: | launchpad:master |
Diff against target: |
223 lines (+37/-58) 2 files modified
lib/lp/soyuz/model/binarypackagebuildbehaviour.py (+8/-25) lib/lp/soyuz/tests/test_binarypackagebuildbehaviour.py (+29/-33) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jürgen Gmach | Approve | ||
Review via email: mp+429703@code.launchpad.net |
Commit message
Fetch files for private BPBs from librarian
Description of the change
This will allow us to lift the requirement for the source for private binary package builds to be published before we can dispatch them. We were already using macaroon authentication for private source files due to the `SnapBase` work last year; this just switches from having the private PPA server do the authorization to having the librarian do it.
We now always fetch files for binary package builds using HTTPS, even for public builds, which seems like a better idea now that we no longer need the long-fat-pipe mitigations for Boston builders.
This is roughly half of https:/