Merge ~cjwatson/launchpad:py3-signing-proxy into launchpad:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 4c6e2c957557b1680864e0ce79cff6a1e8e6c421 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:py3-signing-proxy |
Merge into: | launchpad:master |
Diff against target: |
151 lines (+25/-18) 3 files modified
lib/lp/services/signing/proxy.py (+11/-6) lib/lp/services/signing/tests/test_proxy.py (+13/-11) lib/lp/services/signing/tests/test_signingkey.py (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Cristian Gonzalez (community) | Approve | ||
Review via email: mp+399081@code.launchpad.net |
Commit message
lp.services.
Description of the change
base64 operates on bytes while json generally operates on text, so a good deal of explicit encoding and decoding is needed.
To post a comment you must log in.
Looks well encoded :)!