Merge lp:~cjwatson/brz/lp-test-uris into lp:brz

Proposed by Colin Watson
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merge reported by: The Breezy Bot
Merged at revision: not available
Proposed branch: lp:~cjwatson/brz/lp-test-uris
Merge into: lp:brz
Diff against target: 60 lines (+9/-9)
3 files modified
breezy/plugins/launchpad/test_lp_directory.py (+2/-2)
breezy/plugins/launchpad/test_lp_service.py (+6/-6)
breezy/plugins/launchpad/uris.py (+1/-1)
To merge this branch: bzr merge lp:~cjwatson/brz/lp-test-uris
Reviewer Review Type Date Requested Status
Jelmer Vernooij Approve
Review via email: mp+393711@code.launchpad.net

Commit message

Define a Launchpad 'test' domain rather than 'dev'.

Description of the change

We had to change Launchpad's development setup to use launchpad.test rather than launchpad.dev a while back, since Google bought .dev and added it to HSTS preload lists.

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) :
review: Approve
Revision history for this message
The Breezy Bot (the-breezy-bot) wrote :
Revision history for this message
The Breezy Bot (the-breezy-bot) wrote :
Revision history for this message
Colin Watson (cjwatson) wrote :

Could you retry the landing, please? I've fixed the broken test.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'breezy/plugins/launchpad/test_lp_directory.py'
--- breezy/plugins/launchpad/test_lp_directory.py 2020-02-07 02:14:30 +0000
+++ breezy/plugins/launchpad/test_lp_directory.py 2020-11-17 10:58:28 +0000
@@ -209,8 +209,8 @@
209 'lp:///apt')209 'lp:///apt')
210 self.assertResolve('bzr+ssh://bazaar.launchpad.net/+branch/apt',210 self.assertResolve('bzr+ssh://bazaar.launchpad.net/+branch/apt',
211 'lp://production/apt')211 'lp://production/apt')
212 self.assertResolve('bzr+ssh://bazaar.launchpad.dev/+branch/apt',212 self.assertResolve('bzr+ssh://bazaar.launchpad.test/+branch/apt',
213 'lp://dev/apt')213 'lp://test/apt')
214 self.assertResolve('bzr+ssh://bazaar.staging.launchpad.net/+branch/apt',214 self.assertResolve('bzr+ssh://bazaar.staging.launchpad.net/+branch/apt',
215 'lp://staging/apt')215 'lp://staging/apt')
216 self.assertResolve('bzr+ssh://bazaar.qastaging.launchpad.net/+branch/apt',216 self.assertResolve('bzr+ssh://bazaar.qastaging.launchpad.net/+branch/apt',
217217
=== modified file 'breezy/plugins/launchpad/test_lp_service.py'
--- breezy/plugins/launchpad/test_lp_service.py 2020-02-07 02:14:30 +0000
+++ breezy/plugins/launchpad/test_lp_service.py 2020-11-17 10:58:28 +0000
@@ -57,9 +57,9 @@
57 self.assertEqual('https://xmlrpc.staging.launchpad.net/bazaar/',57 self.assertEqual('https://xmlrpc.staging.launchpad.net/bazaar/',
58 service.service_url)58 service.service_url)
5959
60 def test_dev_service(self):60 def test_test_service(self):
61 service = LaunchpadService(lp_instance='dev')61 service = LaunchpadService(lp_instance='test')
62 self.assertEqual('https://xmlrpc.launchpad.dev/bazaar/',62 self.assertEqual('https://xmlrpc.launchpad.test/bazaar/',
63 service.service_url)63 service.service_url)
6464
65 def test_demo_service(self):65 def test_demo_service(self):
@@ -170,12 +170,12 @@
170 self.assertEqual(170 self.assertEqual(
171 'https://code.staging.launchpad.net/~foo/bar/baz', web_url)171 'https://code.staging.launchpad.net/~foo/bar/baz', web_url)
172172
173 def test_dev_url(self):173 def test_test_url(self):
174 service = LaunchpadService(lp_instance='dev')174 service = LaunchpadService(lp_instance='test')
175 web_url = service.get_web_url_from_branch_url(175 web_url = service.get_web_url_from_branch_url(
176 'bzr+ssh://bazaar.launchpad.net/~foo/bar/baz')176 'bzr+ssh://bazaar.launchpad.net/~foo/bar/baz')
177 self.assertEqual(177 self.assertEqual(
178 'https://code.launchpad.dev/~foo/bar/baz', web_url)178 'https://code.launchpad.test/~foo/bar/baz', web_url)
179179
180 def test_demo_url(self):180 def test_demo_url(self):
181 service = LaunchpadService(lp_instance='demo')181 service = LaunchpadService(lp_instance='demo')
182182
=== modified file 'breezy/plugins/launchpad/uris.py'
--- breezy/plugins/launchpad/uris.py 2020-02-18 01:57:45 +0000
+++ breezy/plugins/launchpad/uris.py 2020-11-17 10:58:28 +0000
@@ -26,7 +26,7 @@
26 'staging': 'staging.launchpad.net',26 'staging': 'staging.launchpad.net',
27 'qastaging': 'qastaging.launchpad.net',27 'qastaging': 'qastaging.launchpad.net',
28 'demo': 'demo.launchpad.net',28 'demo': 'demo.launchpad.net',
29 'dev': 'launchpad.dev',29 'test': 'launchpad.test',
30 }30 }
3131
32LAUNCHPAD_BAZAAR_DOMAINS = [32LAUNCHPAD_BAZAAR_DOMAINS = [

Subscribers

People subscribed via source and target branches