Merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-04 into lp:ubuntu-filemanager-app

Proposed by Carlos Jose Mazieri
Status: Merged
Approved by: Arto Jalkanen
Approved revision: 462
Merged at revision: 469
Proposed branch: lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-04
Merge into: lp:ubuntu-filemanager-app
Prerequisite: lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-03
Diff against target: 112 lines (+23/-12)
6 files modified
src/plugin/folderlistmodel/diriteminfo.cpp (+9/-0)
src/plugin/folderlistmodel/diriteminfo.h (+1/-0)
src/plugin/folderlistmodel/smb/smblistworker.cpp (+9/-4)
src/plugin/folderlistmodel/smb/smblistworker.h (+2/-2)
src/plugin/folderlistmodel/smb/smblocation.cpp (+1/-1)
src/plugin/folderlistmodel/urliteminfo.cpp (+1/-5)
To merge this branch: bzr merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-04
Reviewer Review Type Date Requested Status
Arto Jalkanen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+270338@code.launchpad.net

Commit message

forcing Executable/Readable for hosts, it will make them act as folder when they do not have access (needs authentication)

Description of the change

forcing hosts to be visible even they require authentication

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Arto Jalkanen (ajalkane) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/plugin/folderlistmodel/diriteminfo.cpp'
--- src/plugin/folderlistmodel/diriteminfo.cpp 2015-07-11 21:21:16 +0000
+++ src/plugin/folderlistmodel/diriteminfo.cpp 2015-09-07 21:32:15 +0000
@@ -579,3 +579,12 @@
579 }579 }
580 return ret;580 return ret;
581}581}
582
583
584void DirItemInfo::setAsHost()
585{
586 d_ptr->_isHost = true;
587 d_ptr->_exists = true;
588 d_ptr->_isReadable = true;
589 d_ptr->_isExecutable = true;
590}
582591
=== modified file 'src/plugin/folderlistmodel/diriteminfo.h'
--- src/plugin/folderlistmodel/diriteminfo.h 2015-02-22 20:59:32 +0000
+++ src/plugin/folderlistmodel/diriteminfo.h 2015-09-07 21:32:15 +0000
@@ -111,6 +111,7 @@
111 virtual void setFile(const QString &dir, const QString & file); 111 virtual void setFile(const QString &dir, const QString & file);
112 virtual bool permission(QFile::Permissions permissions) const;112 virtual bool permission(QFile::Permissions permissions) const;
113 void fillFromStatBuf(const struct stat& statBuffer);113 void fillFromStatBuf(const struct stat& statBuffer);
114 void setAsHost();
114115
115public:116public:
116 static QString removeExtraSlashes(const QString &url, int firstSlashIndex = -1);117 static QString removeExtraSlashes(const QString &url, int firstSlashIndex = -1);
117118
=== modified file 'src/plugin/folderlistmodel/smb/smblistworker.cpp'
--- src/plugin/folderlistmodel/smb/smblistworker.cpp 2015-05-20 16:18:07 +0000
+++ src/plugin/folderlistmodel/smb/smblistworker.cpp 2015-09-07 21:32:15 +0000
@@ -25,11 +25,11 @@
25SmbListWorker::SmbListWorker(const QString &pathName,25SmbListWorker::SmbListWorker(const QString &pathName,
26 QDir::Filter filter,26 QDir::Filter filter,
27 const bool isRecursive,27 const bool isRecursive,
28 bool parentIsHost,28 DirItemInfo * parentItem,
29 Const_SmbUtil_Ptr smb)29 Const_SmbUtil_Ptr smb)
30 : DirListWorker(pathName, filter, isRecursive) 30 : DirListWorker(pathName, filter, isRecursive)
31 , SmbObject(pathName, smb)31 , SmbObject(pathName, smb)
32 , m_parentIsHost(parentIsHost)32 , m_parent(parentItem)
33{33{
34 mLoaderType = NetworkLoader;34 mLoaderType = NetworkLoader;
35}35}
@@ -51,9 +51,14 @@
51 {51 {
52 QString next = dir.next();52 QString next = dir.next();
53 SmbItemInfo item (next, m_smb);53 SmbItemInfo item (next, m_smb);
54 if (m_parentIsHost)54 if (m_parent)
55 {55 {
56 item.setAsShare();56 if (m_parent->isHost()) {
57 item.setAsShare();
58 }
59 else if (m_parent->isWorkGroup()) {
60 item.setAsHost();
61 }
57 }62 }
58 smbContent.append(item);63 smbContent.append(item);
59 }64 }
6065
=== modified file 'src/plugin/folderlistmodel/smb/smblistworker.h'
--- src/plugin/folderlistmodel/smb/smblistworker.h 2015-05-20 16:18:07 +0000
+++ src/plugin/folderlistmodel/smb/smblistworker.h 2015-09-07 21:32:15 +0000
@@ -29,12 +29,12 @@
29{29{
30 Q_OBJECT30 Q_OBJECT
31public:31public:
32 explicit SmbListWorker(const QString &pathName, QDir::Filter filter, const bool isRecursive, bool parentIsHost, Const_SmbUtil_Ptr smb);32 explicit SmbListWorker(const QString &pathName, QDir::Filter filter, const bool isRecursive, DirItemInfo * parentItem, Const_SmbUtil_Ptr smb);
3333
34private:34private:
35 DirItemInfoList getNetworkContent();35 DirItemInfoList getNetworkContent();
36private:36private:
37 bool m_parentIsHost;37 DirItemInfo * m_parent;
38};38};
3939
40#endif // SMBLISTWORKER_H40#endif // SMBLISTWORKER_H
4141
=== modified file 'src/plugin/folderlistmodel/smb/smblocation.cpp'
--- src/plugin/folderlistmodel/smb/smblocation.cpp 2015-07-15 17:42:37 +0000
+++ src/plugin/folderlistmodel/smb/smblocation.cpp 2015-09-07 21:32:15 +0000
@@ -88,7 +88,7 @@
8888
89DirListWorker * SmbLocation::newListWorker(const QString &urlPath, QDir::Filter filter, const bool isRecursive)89DirListWorker * SmbLocation::newListWorker(const QString &urlPath, QDir::Filter filter, const bool isRecursive)
90{90{
91 return new SmbListWorker(urlPath,filter,isRecursive, m_info ? m_info->isHost() : false, m_smb);91 return new SmbListWorker(urlPath,filter,isRecursive, m_info, m_smb);
92}92}
9393
9494
9595
=== modified file 'src/plugin/folderlistmodel/urliteminfo.cpp'
--- src/plugin/folderlistmodel/urliteminfo.cpp 2015-03-14 17:38:50 +0000
+++ src/plugin/folderlistmodel/urliteminfo.cpp 2015-09-07 21:32:15 +0000
@@ -105,11 +105,7 @@
105 if (url.path().isEmpty())105 if (url.path().isEmpty())
106 {106 {
107 //!< initial set is "host", Samba shares also have Workspace which will be handled in \ref SmbItemInfo107 //!< initial set is "host", Samba shares also have Workspace which will be handled in \ref SmbItemInfo
108 d_ptr->_isHost = true;108 setAsHost();
109 //set as it exists so far
110 d_ptr->_exists = true;
111 d_ptr->_isReadable = true;
112 d_ptr->_isExecutable = true;
113 }109 }
114 }110 }
115}111}

Subscribers

People subscribed via source and target branches