Merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-01 into lp:ubuntu-filemanager-app

Proposed by Carlos Jose Mazieri
Status: Merged
Approved by: Arto Jalkanen
Approved revision: 474
Merged at revision: 484
Proposed branch: lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-01
Merge into: lp:ubuntu-filemanager-app
Diff against target: 17 lines (+7/-0)
1 file modified
src/plugin/folderlistmodel/net/netauthenticationdata.cpp (+7/-0)
To merge this branch: bzr merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-01
Reviewer Review Type Date Requested Status
Arto Jalkanen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+273333@code.launchpad.net

Commit message

Improved Authentication saving/using by trying the host only when there is no user/password for a such URL which has path

Description of the change

Improved Authentication saving/using by trying the host only when there is no user/password for a such URL which has path

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Arto Jalkanen (ajalkane) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/plugin/folderlistmodel/net/netauthenticationdata.cpp'
--- src/plugin/folderlistmodel/net/netauthenticationdata.cpp 2015-03-01 15:32:42 +0000
+++ src/plugin/folderlistmodel/net/netauthenticationdata.cpp 2015-10-04 15:43:35 +0000
@@ -78,6 +78,13 @@
78 if (!url.isEmpty())78 if (!url.isEmpty())
79 {79 {
80 ret = m_urlEntries.value(url);80 ret = m_urlEntries.value(url);
81 if (ret == 0)
82 {
83 //try to match cases where a more complete URL like smb://host/share/directory was entered and smb://host had been saved before
84 QUrl hostUrl(url);
85 hostUrl.setPath(QLatin1String(0));
86 ret = m_urlEntries.value(hostUrl.toString());
87 }
81 }88 }
82 return ret;89 return ret;
83}90}

Subscribers

People subscribed via source and target branches